From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] Revert "alsa-utils: amidi option needs seq support in alsa-lib"
Date: Sat, 12 Aug 2017 12:01:35 +0200 [thread overview]
Message-ID: <20170812100135.GC3021@scaer> (raw)
In-Reply-To: <20170811212103.24433-2-thomas.petazzoni@free-electrons.com>
Thomas, All,
On 2017-08-11 23:21 +0200, Thomas Petazzoni spake thusly:
> This reverts commit c69088b8c35177cecdd0f1f385c13f5b2c509f1d, which is
> no longer needed now that alsa-lib has been fixed properly.
>
> Indeed, this commit was made because alsa-utils failed to build with:
>
> /home/buildroot/build/instance-0/output/host/usr/xtensa-buildroot-linux-uclibc/sysroot/usr/lib/libasound.a(pcm_dmix.o): In function `snd_pcm_dmix_htimestamp':
> pcm_dmix.c:(.text+0x5c0): warning:
> /home/buildroot/build/instance-0/output/host/usr/xtensa-buildroot-linux-uclibc/sysroot/usr/lib/libasound.a(rawmidi_symbols.o):(.data.rel+0x4): undefined reference to `_snd_module_rawmidi_virt'
> collect2: error: ld returned 1 exit status
>
> Which is exactly the problem that we fixed in alsa-lib by making sure
> that rawmidi_symbols.c doesn't reference symbols from rawmidi_virt.c
> when SEQ support is not enabled.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/alsa-utils/Config.in | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/package/alsa-utils/Config.in b/package/alsa-utils/Config.in
> index d3fd18d..1a48fc0 100644
> --- a/package/alsa-utils/Config.in
> +++ b/package/alsa-utils/Config.in
> @@ -49,7 +49,6 @@ config BR2_PACKAGE_ALSA_UTILS_ALSATPLG
> config BR2_PACKAGE_ALSA_UTILS_AMIDI
> bool "amidi"
> select BR2_PACKAGE_ALSA_LIB_RAWMIDI
> - select BR2_PACKAGE_ALSA_LIB_SEQ
>
> config BR2_PACKAGE_ALSA_UTILS_AMIXER
> bool "amixer"
> --
> 2.9.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2017-08-12 10:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 21:21 [Buildroot] [PATCH 1/2] alsa-lib: add patch to fix incorrect code dependency Thomas Petazzoni
2017-08-11 21:21 ` [Buildroot] [PATCH 2/2] Revert "alsa-utils: amidi option needs seq support in alsa-lib" Thomas Petazzoni
2017-08-12 10:01 ` Yann E. MORIN [this message]
2017-08-12 10:00 ` [Buildroot] [PATCH 1/2] alsa-lib: add patch to fix incorrect code dependency Yann E. MORIN
2017-08-12 11:50 ` Thomas Petazzoni
2017-08-12 16:30 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170812100135.GC3021@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox