From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] whois: fix build with NLS disabled
Date: Mon, 14 Aug 2017 22:02:35 +0200 [thread overview]
Message-ID: <20170814220235.6e869241@windsurf> (raw)
In-Reply-To: <37040459db3e6ca01e2dc8236cf57a993f1831ed.1502649259.git.baruch@tkos.co.il>
Hello,
On Sun, 13 Aug 2017 21:34:17 +0300, Baruch Siach wrote:
> whois build uses the xgettext utility to build translation files.
> This utility may not be available when NLS is disabled. Omit the pos and
> install-pos Makefile targets from the default and the install targets
> when NLS is disabled, respectively.
>
> Fixes:
> http://autobuild.buildroot.net/results/862/862d8165a59711c970c65d90009a527315a1a6b4/
> http://autobuild.buildroot.net/results/b62/b62ec9d6f350e409731d47ffb585344c516944e8/
> http://autobuild.buildroot.net/results/be2/be28d06ae004a46c87133d6f07709c6f909288d8/
>
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Since there is an active upstream at https://github.com/rfc1036/whois,
what about doing something upstreamable, such as introducing an
HAVE_NLS variable, which the Makefile uses to determine if PO files
should be built or not?
The Makefile already supports HAVE_LIBIDN, HAVE_ICONV, HAVE_XCRYPT,
etc. so introducing HAVE_NLS should fit quite well into this, and it
really is a simple patch to do.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-08-14 20:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-13 18:34 [Buildroot] [PATCH 1/3] whois: fix build with NLS disabled Baruch Siach
2017-08-13 18:34 ` [Buildroot] [PATCH 2/3] whois: use github repo as home page Baruch Siach
2017-08-14 20:03 ` Thomas Petazzoni
2017-08-15 4:14 ` Baruch Siach
2017-08-15 10:10 ` Arnout Vandecappelle
2017-08-15 10:56 ` Thomas Petazzoni
2017-08-15 11:20 ` Baruch Siach
2017-08-15 12:07 ` Thomas Petazzoni
2017-08-15 15:23 ` Arnout Vandecappelle
2017-08-13 18:34 ` [Buildroot] [PATCH 3/3] whois: bump to version 5.2.17 Baruch Siach
2017-08-15 4:18 ` Baruch Siach
2017-08-15 8:40 ` Thomas Petazzoni
2017-08-15 10:12 ` Arnout Vandecappelle
2017-08-15 10:54 ` Thomas Petazzoni
2017-08-15 16:22 ` Arnout Vandecappelle
2017-09-06 9:03 ` Peter Korsgaard
2017-08-14 20:02 ` Thomas Petazzoni [this message]
2017-08-16 21:09 ` [Buildroot] [PATCH 1/3] whois: fix build with NLS disabled Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170814220235.6e869241@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox