[Buildroot] [PATCH] toolchain/internal: not aailable for a few mips cores

[Buildroot] [PATCH] toolchain/internal: not aailable for a few mips cores

[Yann E. MORIN]

Commit 1b974425 (MIPS: add support for M6201 cores) xplained that the
new core was not supported by upstream gcc, and as of gcc-8-trunk that's
stil lthe case.

Ditto for 3cfbeb83 (MIPS: add support for P6600 cores).

This means that we currently elect to build an internal tolchain for
those cores, yet we have no suitable gcc version.

Disable the internal backend in this case.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/gcc/Config.in.host | 7 +------
 toolchain/Config.in        | 2 ++
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host
index 485755a15d..77ea8ff374 100644
--- a/package/gcc/Config.in.host
+++ b/package/gcc/Config.in.host
@@ -50,8 +50,7 @@ config BR2_GCC_VERSION_5_X
 	# musl ppc64 unsupported
 	depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_powerpc64 || BR2_powerpc64le))
 	# Unsupported MIPS cores
-	depends on !BR2_mips_interaptiv && !BR2_mips_m5150 && \
-		!BR2_mips_m6250 && !BR2_mips_i6400 && !BR2_mips_p6600
+	depends on !BR2_mips_interaptiv && !BR2_mips_m5150 && !BR2_mips_i6400
 	# musl mips64 unsupported
 	depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_mips64 || BR2_mips64el))
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_5
@@ -61,8 +60,6 @@ config BR2_GCC_VERSION_6_X
 	# Broken or unsupported architectures
 	depends on !BR2_arc
 	depends on !BR2_or1k
-	# Unsupported MIPS cores
-	depends on !BR2_mips_m6250 && !BR2_mips_p6600
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_6
 
 config BR2_GCC_VERSION_7_X
@@ -70,8 +67,6 @@ config BR2_GCC_VERSION_7_X
 	# Broken or unsupported architectures
 	depends on !BR2_arc
 	depends on !BR2_or1k
-	# Unsupported MIPS cores
-	depends on !BR2_mips_m6250 && !BR2_mips_p6600
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_7
 
 endchoice
diff --git a/toolchain/Config.in b/toolchain/Config.in
index 15ee335481..584d053058 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -48,6 +48,8 @@ config BR2_TOOLCHAIN_BUILDROOT
 	depends on !BR2_bf608
 	depends on !BR2_bf609
 	depends on !BR2_csky
+	depends on !BR2_mips_m6250
+	depends on !BR2_mips_p6600
 
 config BR2_TOOLCHAIN_EXTERNAL
 	bool "External toolchain"
-- 
2.11.0

[Buildroot] [PATCH] toolchain/internal: not aailable for a few mips cores

[Arnout Vandecappelle]

On 17-08-17 22:26, Yann E. MORIN wrote:
> Commit 1b974425 (MIPS: add support for M6201 cores) xplained that the
> new core was not supported by upstream gcc, and as of gcc-8-trunk that's
> stil lthe case.
> 
> Ditto for 3cfbeb83 (MIPS: add support for P6600 cores).
> 
> This means that we currently elect to build an internal tolchain for
> those cores, yet we have no suitable gcc version.
> 
> Disable the internal backend in this case.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  package/gcc/Config.in.host | 7 +------
>  toolchain/Config.in        | 2 ++
>  2 files changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host
> index 485755a15d..77ea8ff374 100644
> --- a/package/gcc/Config.in.host
> +++ b/package/gcc/Config.in.host
> @@ -50,8 +50,7 @@ config BR2_GCC_VERSION_5_X
>  	# musl ppc64 unsupported
>  	depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_powerpc64 || BR2_powerpc64le))
>  	# Unsupported MIPS cores
> -	depends on !BR2_mips_interaptiv && !BR2_mips_m5150 && \
> -		!BR2_mips_m6250 && !BR2_mips_i6400 && !BR2_mips_p6600
> +	depends on !BR2_mips_interaptiv && !BR2_mips_m5150 && !BR2_mips_i6400

 I wouldn't remove the conditions here. If these cores are supported in GCC 8,
then we would have to re-introduce them...

 Regards,
 Arnout

[snip]

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH] toolchain/internal: not aailable for a few mips cores

[Yann E. MORIN]

Arnout, All,

On 2017-08-18 00:20 +0200, Arnout Vandecappelle spake thusly:
> On 17-08-17 22:26, Yann E. MORIN wrote:
> > Commit 1b974425 (MIPS: add support for M6201 cores) xplained that the
> > new core was not supported by upstream gcc, and as of gcc-8-trunk that's
> > stil lthe case.
> > 
> > Ditto for 3cfbeb83 (MIPS: add support for P6600 cores).
> > 
> > This means that we currently elect to build an internal tolchain for
> > those cores, yet we have no suitable gcc version.
> > 
> > Disable the internal backend in this case.
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > ---
> >  package/gcc/Config.in.host | 7 +------
> >  toolchain/Config.in        | 2 ++
> >  2 files changed, 3 insertions(+), 6 deletions(-)
> > 
> > diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host
> > index 485755a15d..77ea8ff374 100644
> > --- a/package/gcc/Config.in.host
> > +++ b/package/gcc/Config.in.host
> > @@ -50,8 +50,7 @@ config BR2_GCC_VERSION_5_X
> >  	# musl ppc64 unsupported
> >  	depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_powerpc64 || BR2_powerpc64le))
> >  	# Unsupported MIPS cores
> > -	depends on !BR2_mips_interaptiv && !BR2_mips_m5150 && \
> > -		!BR2_mips_m6250 && !BR2_mips_i6400 && !BR2_mips_p6600
> > +	depends on !BR2_mips_interaptiv && !BR2_mips_m5150 && !BR2_mips_i6400
> 
>  I wouldn't remove the conditions here. If these cores are supported in GCC 8,
> then we would have to re-introduce them...

I disagree:

  - for the existing exclusions, there is no corresponding exclusions in
    the gcc choice, so we'll have to add them should a newer gcc
    supports them;

  - and for those, it will actually be easier: we'll have this commit to
    just revert. And not evem that, because my ultimate goal is that
    each architecture defines what minimum gcc version it requires:
        https://git.buildroot.org/~ymorin/git/buildroot/log/?h=yem/aarch64-cpus
    with the change to gcc and ARM:
        https://git.buildroot.org/~ymorin/git/buildroot/commit/?h=yem/aarch64-cpus&id=95fec656d85fbed488cc666848ecacf011850a93
        https://git.buildroot.org/~ymorin/git/buildroot/commit/?h=yem/aarch64-cpus&id=18d10caf174129479e47df3c04d799e285870db3

But until then, this patch is still needed.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] toolchain/internal: not aailable for a few mips cores

[Thomas Petazzoni]

Hello,

On Thu, 17 Aug 2017 22:26:47 +0200, Yann E. MORIN wrote:
> Commit 1b974425 (MIPS: add support for M6201 cores) xplained that the
> new core was not supported by upstream gcc, and as of gcc-8-trunk that's
> stil lthe case.
> 
> Ditto for 3cfbeb83 (MIPS: add support for P6600 cores).
> 
> This means that we currently elect to build an internal tolchain for
> those cores, yet we have no suitable gcc version.
> 
> Disable the internal backend in this case.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  package/gcc/Config.in.host | 7 +------
>  toolchain/Config.in        | 2 ++
>  2 files changed, 3 insertions(+), 6 deletions(-)

Applied to master, after fixing a number of typos here and there :)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com