* [Buildroot] [PATCH 1/2] configs/imx6q-sabresd_qt5: Remove BR2_TOOLCHAIN_BUILDROOT_GLIBC
@ 2017-08-21 18:20 Fabio Estevam
2017-08-21 18:20 ` [Buildroot] [PATCH 2/2] configs/imx6q-sabresd_qt5: Remove CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE Fabio Estevam
2017-08-21 21:26 ` [Buildroot] [PATCH 1/2] configs/imx6q-sabresd_qt5: Remove BR2_TOOLCHAIN_BUILDROOT_GLIBC Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Fabio Estevam @ 2017-08-21 18:20 UTC (permalink / raw)
To: buildroot
From: Fabio Estevam <festevam@gmail.com>
There is no need to select BR2_TOOLCHAIN_BUILDROOT_GLIBC, so just remove it.
Suggested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
configs/imx6q-sabresd_qt5_defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/configs/imx6q-sabresd_qt5_defconfig b/configs/imx6q-sabresd_qt5_defconfig
index 0b4e961..801b256 100644
--- a/configs/imx6q-sabresd_qt5_defconfig
+++ b/configs/imx6q-sabresd_qt5_defconfig
@@ -10,7 +10,6 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_11=y
# Additional features needed for packages
BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
-BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
# System
BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] configs/imx6q-sabresd_qt5: Remove CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE
2017-08-21 18:20 [Buildroot] [PATCH 1/2] configs/imx6q-sabresd_qt5: Remove BR2_TOOLCHAIN_BUILDROOT_GLIBC Fabio Estevam
@ 2017-08-21 18:20 ` Fabio Estevam
2017-08-21 19:51 ` Arnout Vandecappelle
2017-08-21 21:26 ` [Buildroot] [PATCH 1/2] configs/imx6q-sabresd_qt5: Remove BR2_TOOLCHAIN_BUILDROOT_GLIBC Thomas Petazzoni
1 sibling, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2017-08-21 18:20 UTC (permalink / raw)
To: buildroot
From: Fabio Estevam <festevam@gmail.com>
Selecting CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y causes touchscreen
to behave incorrectly, leading to missed touch events, so remove this
option.
Keep the fragment file as sent in the original patch submission.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
board/freescale/imx6q-sabresd/linux_qt5.fragment | 1 -
1 file changed, 1 deletion(-)
diff --git a/board/freescale/imx6q-sabresd/linux_qt5.fragment b/board/freescale/imx6q-sabresd/linux_qt5.fragment
index 5c0505e..f244ba8 100644
--- a/board/freescale/imx6q-sabresd/linux_qt5.fragment
+++ b/board/freescale/imx6q-sabresd/linux_qt5.fragment
@@ -1,4 +1,3 @@
# Currently kernel mainline exhibits issues when running cpufreq as ondemand
# governor on mx6.
# CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND is not set
-CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] configs/imx6q-sabresd_qt5: Remove CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE
2017-08-21 18:20 ` [Buildroot] [PATCH 2/2] configs/imx6q-sabresd_qt5: Remove CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE Fabio Estevam
@ 2017-08-21 19:51 ` Arnout Vandecappelle
2017-08-21 20:51 ` Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: Arnout Vandecappelle @ 2017-08-21 19:51 UTC (permalink / raw)
To: buildroot
On 21-08-17 20:20, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@gmail.com>
>
> Selecting CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y causes touchscreen
> to behave incorrectly, leading to missed touch events, so remove this
> option.
The default *is* performance, so removing the line will set it to performance.
So I double-checked and indeed, I get the same .config before and after your patch.
Am I missing something?
I added that line to make it explicit what is selected, which apparently was a
good idea :-)
Regards,
Arnout
>
> Keep the fragment file as sent in the original patch submission.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> board/freescale/imx6q-sabresd/linux_qt5.fragment | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/board/freescale/imx6q-sabresd/linux_qt5.fragment b/board/freescale/imx6q-sabresd/linux_qt5.fragment
> index 5c0505e..f244ba8 100644
> --- a/board/freescale/imx6q-sabresd/linux_qt5.fragment
> +++ b/board/freescale/imx6q-sabresd/linux_qt5.fragment
> @@ -1,4 +1,3 @@
> # Currently kernel mainline exhibits issues when running cpufreq as ondemand
> # governor on mx6.
> # CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND is not set
> -CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] configs/imx6q-sabresd_qt5: Remove CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE
2017-08-21 19:51 ` Arnout Vandecappelle
@ 2017-08-21 20:51 ` Fabio Estevam
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2017-08-21 20:51 UTC (permalink / raw)
To: buildroot
On Mon, Aug 21, 2017 at 4:51 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
>
>
> On 21-08-17 20:20, Fabio Estevam wrote:
>> From: Fabio Estevam <festevam@gmail.com>
>>
>> Selecting CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y causes touchscreen
>> to behave incorrectly, leading to missed touch events, so remove this
>> option.
>
> The default *is* performance, so removing the line will set it to performance.
> So I double-checked and indeed, I get the same .config before and after your patch.
Thanks for the clarification. Should be a different issue that I faced
then. Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] configs/imx6q-sabresd_qt5: Remove BR2_TOOLCHAIN_BUILDROOT_GLIBC
2017-08-21 18:20 [Buildroot] [PATCH 1/2] configs/imx6q-sabresd_qt5: Remove BR2_TOOLCHAIN_BUILDROOT_GLIBC Fabio Estevam
2017-08-21 18:20 ` [Buildroot] [PATCH 2/2] configs/imx6q-sabresd_qt5: Remove CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE Fabio Estevam
@ 2017-08-21 21:26 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2017-08-21 21:26 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 21 Aug 2017 15:20:51 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@gmail.com>
>
> There is no need to select BR2_TOOLCHAIN_BUILDROOT_GLIBC, so just remove it.
>
> Suggested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> configs/imx6q-sabresd_qt5_defconfig | 1 -
> 1 file changed, 1 deletion(-)
Applied to next, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-21 21:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-21 18:20 [Buildroot] [PATCH 1/2] configs/imx6q-sabresd_qt5: Remove BR2_TOOLCHAIN_BUILDROOT_GLIBC Fabio Estevam
2017-08-21 18:20 ` [Buildroot] [PATCH 2/2] configs/imx6q-sabresd_qt5: Remove CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE Fabio Estevam
2017-08-21 19:51 ` Arnout Vandecappelle
2017-08-21 20:51 ` Fabio Estevam
2017-08-21 21:26 ` [Buildroot] [PATCH 1/2] configs/imx6q-sabresd_qt5: Remove BR2_TOOLCHAIN_BUILDROOT_GLIBC Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox