* [Buildroot] [PATCH 1/1] package/x11r7/xlib_libXpm: needs host-gettext
@ 2017-08-22 17:03 Bernd Kuhls
2017-08-22 21:01 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Bernd Kuhls @ 2017-08-22 17:03 UTC (permalink / raw)
To: buildroot
https://git.buildroot.net/buildroot/commit/package/x11r7?id=e398ec92e9ad04e5bbae32f03cd18a53b5761517
removed the host-gettext dependency. Since then building the
package fails on hosts without the xgettext binary:
/bin/sh: xgettext: command not found
Fixes
http://autobuild.buildroot.net/results/75c/75c50e617349d327713cba9bc97163bb2c9a6943/
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/x11r7/xlib_libXpm/xlib_libXpm.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/x11r7/xlib_libXpm/xlib_libXpm.mk b/package/x11r7/xlib_libXpm/xlib_libXpm.mk
index e781a8b518..ec50a42228 100644
--- a/package/x11r7/xlib_libXpm/xlib_libXpm.mk
+++ b/package/x11r7/xlib_libXpm/xlib_libXpm.mk
@@ -14,6 +14,6 @@ XLIB_LIBXPM_INSTALL_STAGING = YES
XLIB_LIBXPM_AUTORECONF = YES
XLIB_LIBXPM_DEPENDENCIES = xlib_libX11 xlib_libXext xlib_libXt xproto_xproto \
$(if $(BR2_PACKAGE_LIBICONV),libiconv) \
- $(TARGET_NLS_DEPENDENCIES)
+ host-gettext $(TARGET_NLS_DEPENDENCIES)
$(eval $(autotools-package))
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/x11r7/xlib_libXpm: needs host-gettext
2017-08-22 17:03 [Buildroot] [PATCH 1/1] package/x11r7/xlib_libXpm: needs host-gettext Bernd Kuhls
@ 2017-08-22 21:01 ` Thomas Petazzoni
2018-01-07 17:57 ` Bernd Kuhls
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2017-08-22 21:01 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 22 Aug 2017 19:03:04 +0200, Bernd Kuhls wrote:
> https://git.buildroot.net/buildroot/commit/package/x11r7?id=e398ec92e9ad04e5bbae32f03cd18a53b5761517
> removed the host-gettext dependency. Since then building the
> package fails on hosts without the xgettext binary:
>
> /bin/sh: xgettext: command not found
>
> Fixes
> http://autobuild.buildroot.net/results/75c/75c50e617349d327713cba9bc97163bb2c9a6943/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/x11r7/xlib_libXpm/xlib_libXpm.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/x11r7/xlib_libXpm/xlib_libXpm.mk b/package/x11r7/xlib_libXpm/xlib_libXpm.mk
> index e781a8b518..ec50a42228 100644
> --- a/package/x11r7/xlib_libXpm/xlib_libXpm.mk
> +++ b/package/x11r7/xlib_libXpm/xlib_libXpm.mk
> @@ -14,6 +14,6 @@ XLIB_LIBXPM_INSTALL_STAGING = YES
> XLIB_LIBXPM_AUTORECONF = YES
> XLIB_LIBXPM_DEPENDENCIES = xlib_libX11 xlib_libXext xlib_libXt xproto_xproto \
> $(if $(BR2_PACKAGE_LIBICONV),libiconv) \
> - $(TARGET_NLS_DEPENDENCIES)
> + host-gettext $(TARGET_NLS_DEPENDENCIES)
This is not a great fix. Indeed, TARGET_NLS_DEPENDENCIES already
contains host-gettext, but only if BR2_ENABLE_SYSTEM_NLS=y.
So instead, what we need, is to make sure xlib_libXpm doesn't build its
PO files if --disable-nls is passed.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-07 17:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-22 17:03 [Buildroot] [PATCH 1/1] package/x11r7/xlib_libXpm: needs host-gettext Bernd Kuhls
2017-08-22 21:01 ` Thomas Petazzoni
2018-01-07 17:57 ` Bernd Kuhls
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox