Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] bcusdk: enable tpuarts support in eibd
Date: Thu, 24 Aug 2017 23:11:35 +0200	[thread overview]
Message-ID: <20170824231135.4a4a8e98@windsurf> (raw)
In-Reply-To: <20170824073008.GB22055@airbook.vandijck-laurijssen.be>

Hello,

On Thu, 24 Aug 2017 09:30:08 +0200, Kurt Van Dijck wrote:
> Hey,
> 
> Please find my patch below.
> It enables an extra interface type for eibd.
> I don't understand why it wasn't there.
> 
> Kind regards,
> Kurt
> 
> --
> commit e62160001f09bff9be8e74b6d47da11c349bb2a6
> Author: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> Date:   Thu Aug 24 09:16:36 2017
> 
>     bcusdk: enable tpuarts support in eibd
>     
>     This commit will enable tpuarts in eibd as well.
>     tpuarts is equally important to FT1.2.
>     It makes no sense to enable only some interfaces.
>     
>     Signed-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>

Thanks, I've applied your patch to the next branch. However, I have a
few comments/questions:

 - Could you use "git send-email" next time to send your patch? Indeed
   the formatting of your patch was not correct, so I had to fix it up
   manually. I.e you shouldn't be adding a "personal" message at the
   top of the patch, but just e-mail out the output of "git
   format-patch", which is exactly what "git send-email" guarantees to
   do correctly.

 - I've added to the commit log some information about the size
   increase caused by this new option. Since it's just 8 KB, it doesn't
   justify adding a new Buildroot Config.in option.

 - Our DEVELOPERS file doesn't list anyone looking after the bcusdk
   package. Would you be willing to take care of this package, since
   you're using it? Basically, it only means that you would be
   receiving notifications when there are build failures on this
   package, and potentially be CC'ed on patches touching this package.

Thanks a lot for your contribution!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-08-24 21:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24  7:30 [Buildroot] [PATCH] bcusdk: enable tpuarts support in eibd Kurt Van Dijck
2017-08-24 21:11 ` Thomas Petazzoni [this message]
2017-08-25  7:15   ` Kurt Van Dijck
2017-08-25 12:31     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170824231135.4a4a8e98@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox