Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] bcusdk: enable tpuarts support in eibd
Date: Fri, 25 Aug 2017 14:31:16 +0200	[thread overview]
Message-ID: <20170825143116.52906566@windsurf> (raw)
In-Reply-To: <20170825071511.GA18332@airbook.vandijck-laurijssen.be>

Hello,

On Fri, 25 Aug 2017 09:15:11 +0200, Kurt Van Dijck wrote:
> >  - Could you use "git send-email" next time to send your patch? Indeed
> >    the formatting of your patch was not correct, so I had to fix it up
> >    manually. I.e you shouldn't be adding a "personal" message at the
> >    top of the patch, but just e-mail out the output of "git
> >    format-patch", which is exactly what "git send-email" guarantees to
> >    do correctly.  
> 
> Well, there has not been much reason to change, but since you're asking,
> I'll give it a try.

Well, your e-mail contained the personal message at the top, which gets
included in the commit log by git when doing "git am". If you want to
include personal messages, put them below a "---" at the end of the
commit log.

> >  - I've added to the commit log some information about the size
> >    increase caused by this new option. Since it's just 8 KB, it doesn't
> >    justify adding a new Buildroot Config.in option.  
> 
> I didn't understand why the different backends didn't have config options.
> Now I know.

Well, it's all a matter of whether it makes sense to add gazillions of
Buildroot options. For 8 KB of additional size, it doesn't make much
sense.

> This basically implies this has been unmaintained for a while, which
> explains a few things.
> Well, I think that it's good idea I start to take care for the package,
> as I'm indeed using it.
> Will you add my name in the DEVELOPERS file, or do I need to take action
> myself?

Please send a patch that adds yourself to the DEVELOPERS file for this
package. Thanks a lot for adopting it!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2017-08-25 12:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24  7:30 [Buildroot] [PATCH] bcusdk: enable tpuarts support in eibd Kurt Van Dijck
2017-08-24 21:11 ` Thomas Petazzoni
2017-08-25  7:15   ` Kurt Van Dijck
2017-08-25 12:31     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170825143116.52906566@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox