* [Buildroot] [PATCH next 1/2] lirc-tools: remove useless libusb-compat dependnecy
@ 2017-08-28 5:34 Baruch Siach
2017-08-28 5:34 ` [Buildroot] [PATCH next 2/2] libftdi1: bump to version 1.4 Baruch Siach
2017-08-30 20:29 ` [Buildroot] [PATCH next 1/2] lirc-tools: remove useless libusb-compat dependnecy Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Baruch Siach @ 2017-08-28 5:34 UTC (permalink / raw)
To: buildroot
The only plugin that uses libusb/libusb-compat is the ftdi plugin. This
plugin needs libftdi1 that already depends on libusb in Buildroot. So in
practice libusb-compat is never actually used; we can safely remove it.
The libusb dependency is implicit in the libftdi1 optional dependency.
Cc: Rhys Williams <github@wilberforce.co.nz>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/lirc-tools/lirc-tools.mk | 4 ----
1 file changed, 4 deletions(-)
diff --git a/package/lirc-tools/lirc-tools.mk b/package/lirc-tools/lirc-tools.mk
index 9d46c1b1b042..e767d9d7f02c 100644
--- a/package/lirc-tools/lirc-tools.mk
+++ b/package/lirc-tools/lirc-tools.mk
@@ -23,10 +23,6 @@ ifeq ($(BR2_PACKAGE_ALSA_LIB),y)
LIRC_TOOLS_DEPENDENCIES += alsa-lib
endif
-ifeq ($(BR2_PACKAGE_LIBUSB_COMPAT),y)
-LIRC_TOOLS_DEPENDENCIES += libusb-compat
-endif
-
ifeq ($(BR2_PACKAGE_PORTAUDIO),y)
LIRC_TOOLS_DEPENDENCIES += portaudio
endif
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH next 2/2] libftdi1: bump to version 1.4
2017-08-28 5:34 [Buildroot] [PATCH next 1/2] lirc-tools: remove useless libusb-compat dependnecy Baruch Siach
@ 2017-08-28 5:34 ` Baruch Siach
2017-08-30 20:30 ` Thomas Petazzoni
2017-08-30 20:29 ` [Buildroot] [PATCH next 1/2] lirc-tools: remove useless libusb-compat dependnecy Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2017-08-28 5:34 UTC (permalink / raw)
To: buildroot
Cc: Daniel Sangue <daniel.sangue@sangue.ch>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/libftdi1/libftdi1.hash | 5 +++--
package/libftdi1/libftdi1.mk | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/package/libftdi1/libftdi1.hash b/package/libftdi1/libftdi1.hash
index 0a89182449c1..40512a7fc302 100644
--- a/package/libftdi1/libftdi1.hash
+++ b/package/libftdi1/libftdi1.hash
@@ -1,2 +1,3 @@
-# Locally computed (after checking the signature from http://www.intra2net.com/en/developer/libftdi/download.php)
-sha256 9a8c95c94bfbcf36584a0a58a6e2003d9b133213d9202b76aec76302ffaa81f4 libftdi1-1.3.tar.bz2
+# Locally computed after checking the signature
+# https://www.intra2net.com/en/developer/libftdi/download/libftdi1-1.4.tar.bz2.sig
+sha256 ec36fb49080f834690c24008328a5ef42d3cf584ef4060f3a35aa4681cb31b74 libftdi1-1.4.tar.bz2
diff --git a/package/libftdi1/libftdi1.mk b/package/libftdi1/libftdi1.mk
index 6b84b953170f..c45c83a71116 100644
--- a/package/libftdi1/libftdi1.mk
+++ b/package/libftdi1/libftdi1.mk
@@ -4,7 +4,7 @@
#
################################################################################
-LIBFTDI1_VERSION = 1.3
+LIBFTDI1_VERSION = 1.4
LIBFTDI1_SOURCE = libftdi1-$(LIBFTDI1_VERSION).tar.bz2
LIBFTDI1_SITE = http://www.intra2net.com/en/developer/libftdi/download
LIBFTDI1_INSTALL_STAGING = YES
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH next 2/2] libftdi1: bump to version 1.4
2017-08-28 5:34 ` [Buildroot] [PATCH next 2/2] libftdi1: bump to version 1.4 Baruch Siach
@ 2017-08-30 20:30 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2017-08-30 20:30 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 28 Aug 2017 08:34:16 +0300, Baruch Siach wrote:
> Cc: Daniel Sangue <daniel.sangue@sangue.ch>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/libftdi1/libftdi1.hash | 5 +++--
> package/libftdi1/libftdi1.mk | 2 +-
> 2 files changed, 4 insertions(+), 3 deletions(-)
Applied to next, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH next 1/2] lirc-tools: remove useless libusb-compat dependnecy
2017-08-28 5:34 [Buildroot] [PATCH next 1/2] lirc-tools: remove useless libusb-compat dependnecy Baruch Siach
2017-08-28 5:34 ` [Buildroot] [PATCH next 2/2] libftdi1: bump to version 1.4 Baruch Siach
@ 2017-08-30 20:29 ` Thomas Petazzoni
2017-08-31 4:18 ` Baruch Siach
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2017-08-30 20:29 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 28 Aug 2017 08:34:15 +0300, Baruch Siach wrote:
> The only plugin that uses libusb/libusb-compat is the ftdi plugin. This
> plugin needs libftdi1 that already depends on libusb in Buildroot. So in
> practice libusb-compat is never actually used; we can safely remove it.
> The libusb dependency is implicit in the libftdi1 optional dependency.
Are you sure ?
From the configure.ac script:
AC_CHECK_HEADERS([usb.h libusb-1.0/libusb.h libusb.h])
AC_CHECK_LIB([usb],[usb_get_string],[usb_libs="-lusb"],,)
AM_CONDITIONAL([BUILD_USB],[test x$usb_libs != x])
AC_CHECK_LIB([usb-1.0],[libusb_lock_events],[usb_libs="$usb_libs -lusb-1.0"],,)
In addition, I do see a number of plugins linked with libusb-0.1:
$ readelf -d output/target/usr/lib/lirc/plugins/* | grep libusb-0.1
0x00000001 (NEEDED) Shared library: [libusb-0.1.so.4]
0x00000001 (NEEDED) Shared library: [libusb-0.1.so.4]
0x00000001 (NEEDED) Shared library: [libusb-0.1.so.4]
0x00000001 (NEEDED) Shared library: [libusb-0.1.so.4]
0x00000001 (NEEDED) Shared library: [libusb-0.1.so.4]
Am I missing something ?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH next 1/2] lirc-tools: remove useless libusb-compat dependnecy
2017-08-30 20:29 ` [Buildroot] [PATCH next 1/2] lirc-tools: remove useless libusb-compat dependnecy Thomas Petazzoni
@ 2017-08-31 4:18 ` Baruch Siach
2017-08-31 7:01 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2017-08-31 4:18 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Wed, Aug 30, 2017 at 10:29:46PM +0200, Thomas Petazzoni wrote:
> On Mon, 28 Aug 2017 08:34:15 +0300, Baruch Siach wrote:
> > The only plugin that uses libusb/libusb-compat is the ftdi plugin. This
> > plugin needs libftdi1 that already depends on libusb in Buildroot. So in
> > practice libusb-compat is never actually used; we can safely remove it.
> > The libusb dependency is implicit in the libftdi1 optional dependency.
>
> Are you sure ?
>
> From the configure.ac script:
>
> AC_CHECK_HEADERS([usb.h libusb-1.0/libusb.h libusb.h])
> AC_CHECK_LIB([usb],[usb_get_string],[usb_libs="-lusb"],,)
> AM_CONDITIONAL([BUILD_USB],[test x$usb_libs != x])
> AC_CHECK_LIB([usb-1.0],[libusb_lock_events],[usb_libs="$usb_libs -lusb-1.0"],,)
>
> In addition, I do see a number of plugins linked with libusb-0.1:
>
> $ readelf -d output/target/usr/lib/lirc/plugins/* | grep libusb-0.1
> 0x00000001 (NEEDED) Shared library: [libusb-0.1.so.4]
> 0x00000001 (NEEDED) Shared library: [libusb-0.1.so.4]
> 0x00000001 (NEEDED) Shared library: [libusb-0.1.so.4]
> 0x00000001 (NEEDED) Shared library: [libusb-0.1.so.4]
> 0x00000001 (NEEDED) Shared library: [libusb-0.1.so.4]
>
> Am I missing something ?
No. I missed the libusb-0.1 related symbols in configure.ac and
plugins/Makefile.am.
Marked as rejected.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH next 1/2] lirc-tools: remove useless libusb-compat dependnecy
2017-08-31 4:18 ` Baruch Siach
@ 2017-08-31 7:01 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2017-08-31 7:01 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 31 Aug 2017 07:18:55 +0300, Baruch Siach wrote:
> > Am I missing something ?
>
> No. I missed the libusb-0.1 related symbols in configure.ac and
> plugins/Makefile.am.
>
> Marked as rejected.
OK, thanks for confirming. FYI, when I saw your patch, I looked at the
Git log on this package, and found a commit from Bernd adding
the LIBUSB_COMPAT optional dependency, with a commit log saying that it
is referenced in configure.ac. That's how I started to have some doubts
on your patch :-)
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-31 7:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-28 5:34 [Buildroot] [PATCH next 1/2] lirc-tools: remove useless libusb-compat dependnecy Baruch Siach
2017-08-28 5:34 ` [Buildroot] [PATCH next 2/2] libftdi1: bump to version 1.4 Baruch Siach
2017-08-30 20:30 ` Thomas Petazzoni
2017-08-30 20:29 ` [Buildroot] [PATCH next 1/2] lirc-tools: remove useless libusb-compat dependnecy Thomas Petazzoni
2017-08-31 4:18 ` Baruch Siach
2017-08-31 7:01 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox