* [Buildroot] [PATCH v2 0/2] grub2 wchar defconfig fixes
@ 2017-09-05 0:08 Nicholas Sielicki
2017-09-05 0:08 ` [Buildroot] [PATCH v2 1/2] configs/galileo: grub2 needs wchar toolchain Nicholas Sielicki
2017-09-05 0:08 ` [Buildroot] [PATCH v2 2/2] configs/minnowboard_max-graphical: wchar/grub2 fix Nicholas Sielicki
0 siblings, 2 replies; 6+ messages in thread
From: Nicholas Sielicki @ 2017-09-05 0:08 UTC (permalink / raw)
To: buildroot
Since a version bump of grub2 (5ffafd2353f5d67) it requires a toolchain
with wide character support. Some defconfigs have lines to build grub2
(BR_TARGET_GRUB2=y) but this doesn't always take place, depending on
whether BR2_USE_WCHAR is set. Because of this, some defconfigs will fail
to successfully build images.
This v2 cuts out some unnecessary changes from v1 (ie: comments in
configs to explicitly note this dependency without any other change) and
splits up the remaining changes into individual patches. I did not test
the minnowboard change, but the galileo change is tested.
Nicholas Sielicki (2):
configs/galileo: grub2 needs wchar toolchain
configs/minnowboard_max-graphical: wchar/grub2 fix
configs/galileo_defconfig | 2 ++
configs/minnowboard_max-graphical_defconfig | 2 ++
2 files changed, 4 insertions(+)
--
2.14.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 1/2] configs/galileo: grub2 needs wchar toolchain
2017-09-05 0:08 [Buildroot] [PATCH v2 0/2] grub2 wchar defconfig fixes Nicholas Sielicki
@ 2017-09-05 0:08 ` Nicholas Sielicki
2017-09-05 19:55 ` Thomas Petazzoni
2017-10-16 21:47 ` Peter Korsgaard
2017-09-05 0:08 ` [Buildroot] [PATCH v2 2/2] configs/minnowboard_max-graphical: wchar/grub2 fix Nicholas Sielicki
1 sibling, 2 replies; 6+ messages in thread
From: Nicholas Sielicki @ 2017-09-05 0:08 UTC (permalink / raw)
To: buildroot
The galileo_defconfig has the line "BR_TARGET_GRUB2=y", but this
currently has no effect because BR_TARGET_GRUB2 cannot be selected
without BR2_TOOLCHAIN_BUILDROOT_WCHAR=y, which is not set by default.
Signed-off-by: Nicholas Sielicki <sielicki@yandex.com>
---
configs/galileo_defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configs/galileo_defconfig b/configs/galileo_defconfig
index 43639a41a..39622e331 100644
--- a/configs/galileo_defconfig
+++ b/configs/galileo_defconfig
@@ -1,4 +1,6 @@
BR2_x86_x1000=y
+# Needed for TARGET_GRUB2
+BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
# Linux headers same as kernel, a 3.14 series
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_14=y
BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 2/2] configs/minnowboard_max-graphical: wchar/grub2 fix
2017-09-05 0:08 [Buildroot] [PATCH v2 0/2] grub2 wchar defconfig fixes Nicholas Sielicki
2017-09-05 0:08 ` [Buildroot] [PATCH v2 1/2] configs/galileo: grub2 needs wchar toolchain Nicholas Sielicki
@ 2017-09-05 0:08 ` Nicholas Sielicki
2017-10-16 21:48 ` Peter Korsgaard
1 sibling, 1 reply; 6+ messages in thread
From: Nicholas Sielicki @ 2017-09-05 0:08 UTC (permalink / raw)
To: buildroot
minnowboard_max-graphical_defconfig has the line "BR_TARGET_GRUB2=y",
but this currently has no effect because BR_TARGET_GRUB2 cannot be
selected without BR2_TOOLCHAIN_BUILDROOT_WCHAR=y, which is not set by
default.
The minnowboard max defconfig was updated to fix this problem, but the
graphical variant was not updated alongside it.
Signed-off-by: Nicholas Sielicki <sielicki@yandex.com>
---
configs/minnowboard_max-graphical_defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configs/minnowboard_max-graphical_defconfig b/configs/minnowboard_max-graphical_defconfig
index ef0947cb7..2c11fb378 100644
--- a/configs/minnowboard_max-graphical_defconfig
+++ b/configs/minnowboard_max-graphical_defconfig
@@ -6,6 +6,8 @@ BR2_x86_atom=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_12=y
BR2_TOOLCHAIN_BUILDROOT_LOCALE=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
+# needed for TARGET_GRUB2
+BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
# System configuration
BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 1/2] configs/galileo: grub2 needs wchar toolchain
2017-09-05 0:08 ` [Buildroot] [PATCH v2 1/2] configs/galileo: grub2 needs wchar toolchain Nicholas Sielicki
@ 2017-09-05 19:55 ` Thomas Petazzoni
2017-10-16 21:47 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2017-09-05 19:55 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 4 Sep 2017 19:08:05 -0500, Nicholas Sielicki wrote:
> The galileo_defconfig has the line "BR_TARGET_GRUB2=y", but this
> currently has no effect because BR_TARGET_GRUB2 cannot be selected
> without BR2_TOOLCHAIN_BUILDROOT_WCHAR=y, which is not set by default.
>
> Signed-off-by: Nicholas Sielicki <sielicki@yandex.com>
> ---
> configs/galileo_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
Both applied. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 1/2] configs/galileo: grub2 needs wchar toolchain
2017-09-05 0:08 ` [Buildroot] [PATCH v2 1/2] configs/galileo: grub2 needs wchar toolchain Nicholas Sielicki
2017-09-05 19:55 ` Thomas Petazzoni
@ 2017-10-16 21:47 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2017-10-16 21:47 UTC (permalink / raw)
To: buildroot
>>>>> "Nicholas" == Nicholas Sielicki <sielicki@yandex.com> writes:
> The galileo_defconfig has the line "BR_TARGET_GRUB2=y", but this
> currently has no effect because BR_TARGET_GRUB2 cannot be selected
> without BR2_TOOLCHAIN_BUILDROOT_WCHAR=y, which is not set by default.
> Signed-off-by: Nicholas Sielicki <sielicki@yandex.com>
Committed to 2017.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 2/2] configs/minnowboard_max-graphical: wchar/grub2 fix
2017-09-05 0:08 ` [Buildroot] [PATCH v2 2/2] configs/minnowboard_max-graphical: wchar/grub2 fix Nicholas Sielicki
@ 2017-10-16 21:48 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2017-10-16 21:48 UTC (permalink / raw)
To: buildroot
>>>>> "Nicholas" == Nicholas Sielicki <sielicki@yandex.com> writes:
> minnowboard_max-graphical_defconfig has the line "BR_TARGET_GRUB2=y",
> but this currently has no effect because BR_TARGET_GRUB2 cannot be
> selected without BR2_TOOLCHAIN_BUILDROOT_WCHAR=y, which is not set by
> default.
> The minnowboard max defconfig was updated to fix this problem, but the
> graphical variant was not updated alongside it.
> Signed-off-by: Nicholas Sielicki <sielicki@yandex.com>
Committed to 2017.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-16 21:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-05 0:08 [Buildroot] [PATCH v2 0/2] grub2 wchar defconfig fixes Nicholas Sielicki
2017-09-05 0:08 ` [Buildroot] [PATCH v2 1/2] configs/galileo: grub2 needs wchar toolchain Nicholas Sielicki
2017-09-05 19:55 ` Thomas Petazzoni
2017-10-16 21:47 ` Peter Korsgaard
2017-09-05 0:08 ` [Buildroot] [PATCH v2 2/2] configs/minnowboard_max-graphical: wchar/grub2 fix Nicholas Sielicki
2017-10-16 21:48 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox