* [Buildroot] [PATCH 1/1] download/git: force gzip compression level 6
@ 2017-09-11 22:13 Petr Kulhavy
2017-09-12 6:05 ` Yann E. MORIN
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Petr Kulhavy @ 2017-09-11 22:13 UTC (permalink / raw)
To: buildroot
Force gzip compression level 6 when calculating hash of a downloaded GIT repo.
To make sure the tar->gzip->checksum chain always provides consistent result.`
The script was relying on the default compression level, which must not be
necessarily consistent among different gzip versions. The level 6 is gzip's
current default compression level.
Signed-off-by: Petr Kulhavy <brain@jikos.cz>
---
support/download/git | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/support/download/git b/support/download/git
index fc2957d..f590ff6 100755
--- a/support/download/git
+++ b/support/download/git
@@ -101,4 +101,4 @@ LC_ALL=C sort <"${basename}.list" >"${basename}.list.sorted"
# sources.buildroot.org and used in the *.hash files
tar cf - --numeric-owner --owner=0 --group=0 --mtime="${date}" --format=gnu \
-T "${basename}.list.sorted" >"${output}.tar"
-gzip -n <"${output}.tar" >"${output}"
+gzip -6 -n <"${output}.tar" >"${output}"
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] download/git: force gzip compression level 6
2017-09-11 22:13 [Buildroot] [PATCH 1/1] download/git: force gzip compression level 6 Petr Kulhavy
@ 2017-09-12 6:05 ` Yann E. MORIN
2017-09-12 21:36 ` Peter Korsgaard
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2017-09-12 6:05 UTC (permalink / raw)
To: buildroot
Petr, All,
On 2017-09-12 00:13 +0200, Petr Kulhavy spake thusly:
> Force gzip compression level 6 when calculating hash of a downloaded GIT repo.
> To make sure the tar->gzip->checksum chain always provides consistent result.`
>
> The script was relying on the default compression level, which must not be
> necessarily consistent among different gzip versions. The level 6 is gzip's
> current default compression level.
Not only is it the _current_ default, it has always been so since the
first release.
> Signed-off-by: Petr Kulhavy <brain@jikos.cz>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> support/download/git | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/download/git b/support/download/git
> index fc2957d..f590ff6 100755
> --- a/support/download/git
> +++ b/support/download/git
> @@ -101,4 +101,4 @@ LC_ALL=C sort <"${basename}.list" >"${basename}.list.sorted"
> # sources.buildroot.org and used in the *.hash files
> tar cf - --numeric-owner --owner=0 --group=0 --mtime="${date}" --format=gnu \
> -T "${basename}.list.sorted" >"${output}.tar"
> -gzip -n <"${output}.tar" >"${output}"
> +gzip -6 -n <"${output}.tar" >"${output}"
> --
> 2.7.4
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] download/git: force gzip compression level 6
2017-09-11 22:13 [Buildroot] [PATCH 1/1] download/git: force gzip compression level 6 Petr Kulhavy
2017-09-12 6:05 ` Yann E. MORIN
@ 2017-09-12 21:36 ` Peter Korsgaard
2017-09-13 5:07 ` Yann E. MORIN
2017-09-21 13:41 ` Peter Korsgaard
2017-10-16 21:54 ` Peter Korsgaard
3 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2017-09-12 21:36 UTC (permalink / raw)
To: buildroot
>>>>> "Petr" == Petr Kulhavy <brain@jikos.cz> writes:
> Force gzip compression level 6 when calculating hash of a downloaded GIT repo.
> To make sure the tar->gzip->checksum chain always provides consistent result.`
> The script was relying on the default compression level, which must not be
> necessarily consistent among different gzip versions. The level 6 is gzip's
> current default compression level.
Committed, thanks.
Is this just a theoretical issue, or something you have really run into?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] download/git: force gzip compression level 6
2017-09-12 21:36 ` Peter Korsgaard
@ 2017-09-13 5:07 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2017-09-13 5:07 UTC (permalink / raw)
To: buildroot
Peter, All,
On 2017-09-12 23:36 +0200, Peter Korsgaard spake thusly:
> >>>>> "Petr" == Petr Kulhavy <brain@jikos.cz> writes:
>
> > Force gzip compression level 6 when calculating hash of a downloaded GIT repo.
> > To make sure the tar->gzip->checksum chain always provides consistent result.`
>
> > The script was relying on the default compression level, which must not be
> > necessarily consistent among different gzip versions. The level 6 is gzip's
> > current default compression level.
>
> Committed, thanks.
>
> Is this just a theoretical issue, or something you have really run into?
Theoretical, see this mail and the ensuing discussion:
http://lists.busybox.net/pipermail/buildroot/2017-September/202162.html
Yet, for consistency, it is good to force it.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] download/git: force gzip compression level 6
2017-09-11 22:13 [Buildroot] [PATCH 1/1] download/git: force gzip compression level 6 Petr Kulhavy
2017-09-12 6:05 ` Yann E. MORIN
2017-09-12 21:36 ` Peter Korsgaard
@ 2017-09-21 13:41 ` Peter Korsgaard
2017-10-16 21:54 ` Peter Korsgaard
3 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2017-09-21 13:41 UTC (permalink / raw)
To: buildroot
>>>>> "Petr" == Petr Kulhavy <brain@jikos.cz> writes:
> Force gzip compression level 6 when calculating hash of a downloaded GIT repo.
> To make sure the tar->gzip->checksum chain always provides consistent result.`
> The script was relying on the default compression level, which must not be
> necessarily consistent among different gzip versions. The level 6 is gzip's
> current default compression level.
> Signed-off-by: Petr Kulhavy <brain@jikos.cz>
Committed to 2017.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] download/git: force gzip compression level 6
2017-09-11 22:13 [Buildroot] [PATCH 1/1] download/git: force gzip compression level 6 Petr Kulhavy
` (2 preceding siblings ...)
2017-09-21 13:41 ` Peter Korsgaard
@ 2017-10-16 21:54 ` Peter Korsgaard
3 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2017-10-16 21:54 UTC (permalink / raw)
To: buildroot
>>>>> "Petr" == Petr Kulhavy <brain@jikos.cz> writes:
> Force gzip compression level 6 when calculating hash of a downloaded GIT repo.
> To make sure the tar->gzip->checksum chain always provides consistent result.`
> The script was relying on the default compression level, which must not be
> necessarily consistent among different gzip versions. The level 6 is gzip's
> current default compression level.
> Signed-off-by: Petr Kulhavy <brain@jikos.cz>
Committed to 2017.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-16 21:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-11 22:13 [Buildroot] [PATCH 1/1] download/git: force gzip compression level 6 Petr Kulhavy
2017-09-12 6:05 ` Yann E. MORIN
2017-09-12 21:36 ` Peter Korsgaard
2017-09-13 5:07 ` Yann E. MORIN
2017-09-21 13:41 ` Peter Korsgaard
2017-10-16 21:54 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox