* [Buildroot] [PATCH] lbase64: fix build
@ 2017-09-29 16:59 Francois Perrad
2017-09-29 19:52 ` Thomas Petazzoni
2017-10-06 19:00 ` Arnout Vandecappelle
0 siblings, 2 replies; 5+ messages in thread
From: Francois Perrad @ 2017-09-29 16:59 UTC (permalink / raw)
To: buildroot
see http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/
Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
package/lbase64/lbase64.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/lbase64/lbase64.mk b/package/lbase64/lbase64.mk
index fd78a6ccd..0225fc67c 100644
--- a/package/lbase64/lbase64.mk
+++ b/package/lbase64/lbase64.mk
@@ -12,7 +12,8 @@ LBASE64_LICENSE_FILES = README
LBASE64_DEPENDENCIES = luainterpreter
define LBASE64_BUILD_CMDS
- $(MAKE1) $(TARGET_CONFIGURE_OPTS) -C $(@D) so
+ $(MAKE1) $(TARGET_CONFIGURE_OPTS) \
+ CFLAGS="$(TARGET_CFLAGS) -fPIC" -C $(@D) so
endef
define LBASE64_INSTALL_TARGET_CMDS
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] lbase64: fix build
2017-09-29 16:59 [Buildroot] [PATCH] lbase64: fix build Francois Perrad
@ 2017-09-29 19:52 ` Thomas Petazzoni
2017-09-30 8:12 ` François Perrad
2017-10-06 19:00 ` Arnout Vandecappelle
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2017-09-29 19:52 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 29 Sep 2017 18:59:06 +0200, Francois Perrad wrote:
> see http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/
>
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
Come on, "fix build" is really, really too short of a commit log.
Please extend this commit log with a decent explanation.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] lbase64: fix build
2017-09-29 19:52 ` Thomas Petazzoni
@ 2017-09-30 8:12 ` François Perrad
2017-09-30 9:34 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: François Perrad @ 2017-09-30 8:12 UTC (permalink / raw)
To: buildroot
2017-09-29 21:52 GMT+02:00 Thomas Petazzoni <
thomas.petazzoni@free-electrons.com>:
> Hello,
>
> On Fri, 29 Sep 2017 18:59:06 +0200, Francois Perrad wrote:
> > see http://autobuild.buildroot.net/results/b56/
> b567096cbfdb89b1895924051265c56204ffb512/
> >
> > Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
>
> Come on, "fix build" is really, really too short of a commit log.
> Please extend this commit log with a decent explanation.
>
>
There are 3 useful words in
http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/build-end.log
:
"recompile with -fPIC"
Fran?ois
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170930/c262e0b0/attachment.html>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] lbase64: fix build
2017-09-30 8:12 ` François Perrad
@ 2017-09-30 9:34 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2017-09-30 9:34 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 30 Sep 2017 10:12:54 +0200, Fran?ois Perrad wrote:
> There are 3 useful words in
> http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/build-end.log
> :
> "recompile with -fPIC"
Still, please write better commit logs.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] lbase64: fix build
2017-09-29 16:59 [Buildroot] [PATCH] lbase64: fix build Francois Perrad
2017-09-29 19:52 ` Thomas Petazzoni
@ 2017-10-06 19:00 ` Arnout Vandecappelle
1 sibling, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2017-10-06 19:00 UTC (permalink / raw)
To: buildroot
On 29-09-17 18:59, Francois Perrad wrote:
> see http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/
>
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
I added a commit message and applied to master, thanks.
However, wouldn't an upstreamable patch have been better?
Regards,
Arnout
> ---
> package/lbase64/lbase64.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/lbase64/lbase64.mk b/package/lbase64/lbase64.mk
> index fd78a6ccd..0225fc67c 100644
> --- a/package/lbase64/lbase64.mk
> +++ b/package/lbase64/lbase64.mk
> @@ -12,7 +12,8 @@ LBASE64_LICENSE_FILES = README
> LBASE64_DEPENDENCIES = luainterpreter
>
> define LBASE64_BUILD_CMDS
> - $(MAKE1) $(TARGET_CONFIGURE_OPTS) -C $(@D) so
> + $(MAKE1) $(TARGET_CONFIGURE_OPTS) \
> + CFLAGS="$(TARGET_CFLAGS) -fPIC" -C $(@D) so
> endef
>
> define LBASE64_INSTALL_TARGET_CMDS
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-06 19:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-29 16:59 [Buildroot] [PATCH] lbase64: fix build Francois Perrad
2017-09-29 19:52 ` Thomas Petazzoni
2017-09-30 8:12 ` François Perrad
2017-09-30 9:34 ` Thomas Petazzoni
2017-10-06 19:00 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox