* [Buildroot] [PATCH] host-lzo: default liblzo2.a install to host/lib @ 2017-10-03 13:49 Matt Weber 2017-10-03 16:42 ` Yann E. MORIN 0 siblings, 1 reply; 6+ messages in thread From: Matt Weber @ 2017-10-03 13:49 UTC (permalink / raw) To: buildroot Discovered the issue on a RHEL7.4 machine where the cmake build dynamically selected HOST_DIR/lib64 as the installation path for the library. Fixes failures like the following: host-mtd http://autobuild.buildroot.net/results/d31/d31581d2e60f35cf70312683df99c768e2ea8516/ host-squashfs http://autobuild.buildroot.net/results/d9c/d9c95231ac774ed71580754a15ebb3b121764310/ Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> --- package/lzo/lzo.mk | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package/lzo/lzo.mk b/package/lzo/lzo.mk index 27ca459..0cafba2 100644 --- a/package/lzo/lzo.mk +++ b/package/lzo/lzo.mk @@ -11,6 +11,9 @@ LZO_LICENSE_FILES = COPYING LZO_INSTALL_STAGING = YES LZO_SUPPORTS_IN_SOURCE_BUILD = NO +# Prevent dynamically using lib64 as install libdir +HOST_LZO_CONF_OPTS += -DCMAKE_INSTALL_LIBDIR=lib + ifeq ($(BR2_SHARED_LIBS)$(BR2_SHARED_STATIC_LIBS),y) LZO_CONF_OPTS += -DENABLE_SHARED=ON else -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] host-lzo: default liblzo2.a install to host/lib 2017-10-03 13:49 [Buildroot] [PATCH] host-lzo: default liblzo2.a install to host/lib Matt Weber @ 2017-10-03 16:42 ` Yann E. MORIN 2017-10-03 17:17 ` Matthew Weber 2017-10-03 19:12 ` Thomas Petazzoni 0 siblings, 2 replies; 6+ messages in thread From: Yann E. MORIN @ 2017-10-03 16:42 UTC (permalink / raw) To: buildroot Matthew, All, On 2017-10-03 08:49 -0500, Matt Weber spake thusly: > Discovered the issue on a RHEL7.4 machine where > the cmake build dynamically selected HOST_DIR/lib64 > as the installation path for the library. > > Fixes failures like the following: > host-mtd > http://autobuild.buildroot.net/results/d31/d31581d2e60f35cf70312683df99c768e2ea8516/ > host-squashfs > http://autobuild.buildroot.net/results/d9c/d9c95231ac774ed71580754a15ebb3b121764310/ > > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> > --- > package/lzo/lzo.mk | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/package/lzo/lzo.mk b/package/lzo/lzo.mk > index 27ca459..0cafba2 100644 > --- a/package/lzo/lzo.mk > +++ b/package/lzo/lzo.mk > @@ -11,6 +11,9 @@ LZO_LICENSE_FILES = COPYING > LZO_INSTALL_STAGING = YES > LZO_SUPPORTS_IN_SOURCE_BUILD = NO > > +# Prevent dynamically using lib64 as install libdir > +HOST_LZO_CONF_OPTS += -DCMAKE_INSTALL_LIBDIR=lib So, probably other packages would have the same issue, then? And indeed, we've just had Jan on IRC reporting the same issue with a new package he's adding. So I suggest that we simply symlink lib64 -> lib like we do for the target, and be done with it. Thoughts? Regards, Yann E. MORIN. > ifeq ($(BR2_SHARED_LIBS)$(BR2_SHARED_STATIC_LIBS),y) > LZO_CONF_OPTS += -DENABLE_SHARED=ON > else > -- > 1.8.3.1 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] host-lzo: default liblzo2.a install to host/lib 2017-10-03 16:42 ` Yann E. MORIN @ 2017-10-03 17:17 ` Matthew Weber 2017-10-03 18:00 ` Matthew Weber 2017-10-03 19:12 ` Thomas Petazzoni 1 sibling, 1 reply; 6+ messages in thread From: Matthew Weber @ 2017-10-03 17:17 UTC (permalink / raw) To: buildroot Yann, On Tue, Oct 3, 2017 at 11:42 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > Matthew, All, > > On 2017-10-03 08:49 -0500, Matt Weber spake thusly: >> Discovered the issue on a RHEL7.4 machine where >> the cmake build dynamically selected HOST_DIR/lib64 >> as the installation path for the library. >> >> Fixes failures like the following: >> host-mtd >> http://autobuild.buildroot.net/results/d31/d31581d2e60f35cf70312683df99c768e2ea8516/ >> host-squashfs >> http://autobuild.buildroot.net/results/d9c/d9c95231ac774ed71580754a15ebb3b121764310/ >> >> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> >> --- >> package/lzo/lzo.mk | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/package/lzo/lzo.mk b/package/lzo/lzo.mk >> index 27ca459..0cafba2 100644 >> --- a/package/lzo/lzo.mk >> +++ b/package/lzo/lzo.mk >> @@ -11,6 +11,9 @@ LZO_LICENSE_FILES = COPYING >> LZO_INSTALL_STAGING = YES >> LZO_SUPPORTS_IN_SOURCE_BUILD = NO >> >> +# Prevent dynamically using lib64 as install libdir >> +HOST_LZO_CONF_OPTS += -DCMAKE_INSTALL_LIBDIR=lib > > So, probably other packages would have the same issue, then? And indeed, > we've just had Jan on IRC reporting the same issue with a new package > he's adding. > > So I suggest that we simply symlink lib64 -> lib like we do for the > target, and be done with it. > > Thoughts? Sounds reasonable, so something we'd add in the Makefile by the following? # Compatibility symlink in case a post-build script still uses $(HOST_DIR)/usr $(HOST_DIR)/usr: $(HOST_DIR) @ln -snf . $@ Matt ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] host-lzo: default liblzo2.a install to host/lib 2017-10-03 17:17 ` Matthew Weber @ 2017-10-03 18:00 ` Matthew Weber 2017-10-03 18:15 ` Matthew Weber 0 siblings, 1 reply; 6+ messages in thread From: Matthew Weber @ 2017-10-03 18:00 UTC (permalink / raw) To: buildroot Yann, On Tue, Oct 3, 2017 at 12:17 PM, Matthew Weber <matthew.weber@rockwellcollins.com> wrote: > Yann, > > On Tue, Oct 3, 2017 at 11:42 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: >> Matthew, All, >> >> On 2017-10-03 08:49 -0500, Matt Weber spake thusly: >>> Discovered the issue on a RHEL7.4 machine where >>> the cmake build dynamically selected HOST_DIR/lib64 >>> as the installation path for the library. >>> >>> Fixes failures like the following: >>> host-mtd >>> http://autobuild.buildroot.net/results/d31/d31581d2e60f35cf70312683df99c768e2ea8516/ >>> host-squashfs >>> http://autobuild.buildroot.net/results/d9c/d9c95231ac774ed71580754a15ebb3b121764310/ >>> >>> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> >>> --- >>> package/lzo/lzo.mk | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/package/lzo/lzo.mk b/package/lzo/lzo.mk >>> index 27ca459..0cafba2 100644 >>> --- a/package/lzo/lzo.mk >>> +++ b/package/lzo/lzo.mk >>> @@ -11,6 +11,9 @@ LZO_LICENSE_FILES = COPYING >>> LZO_INSTALL_STAGING = YES >>> LZO_SUPPORTS_IN_SOURCE_BUILD = NO >>> >>> +# Prevent dynamically using lib64 as install libdir >>> +HOST_LZO_CONF_OPTS += -DCMAKE_INSTALL_LIBDIR=lib >> >> So, probably other packages would have the same issue, then? And indeed, >> we've just had Jan on IRC reporting the same issue with a new package >> he's adding. >> >> So I suggest that we simply symlink lib64 -> lib like we do for the >> target, and be done with it. >> >> Thoughts? > > Sounds reasonable, so something we'd add in the Makefile by the following? > # Compatibility symlink in case a post-build script still uses $(HOST_DIR)/usr > $(HOST_DIR)/usr: $(HOST_DIR) > @ln -snf . $@ > Something like this (testing it now) # Make a symlink lib32->lib or lib64->lib as appropriate. # MIPS64/n32 requires lib32 even though it's a 64-bit arch. ifeq ($(BR2_ARCH_IS_64)$(BR2_MIPS_NABI32),y) $(HOST_DIR)/lib64: $(HOST_DIR) @ln -snf lib $@ else $(HOST_DIR)/lib32: $(HOST_DIR) @ln -snf lib $@ endif ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] host-lzo: default liblzo2.a install to host/lib 2017-10-03 18:00 ` Matthew Weber @ 2017-10-03 18:15 ` Matthew Weber 0 siblings, 0 replies; 6+ messages in thread From: Matthew Weber @ 2017-10-03 18:15 UTC (permalink / raw) To: buildroot Yann, On Tue, Oct 3, 2017 at 1:00 PM, Matthew Weber <matthew.weber@rockwellcollins.com> wrote: > Yann, > > On Tue, Oct 3, 2017 at 12:17 PM, Matthew Weber > <matthew.weber@rockwellcollins.com> wrote: >> Yann, >> >> On Tue, Oct 3, 2017 at 11:42 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: >>> Matthew, All, >>> >>> On 2017-10-03 08:49 -0500, Matt Weber spake thusly: >>>> Discovered the issue on a RHEL7.4 machine where >>>> the cmake build dynamically selected HOST_DIR/lib64 >>>> as the installation path for the library. >>>> >>>> Fixes failures like the following: >>>> host-mtd >>>> http://autobuild.buildroot.net/results/d31/d31581d2e60f35cf70312683df99c768e2ea8516/ >>>> host-squashfs >>>> http://autobuild.buildroot.net/results/d9c/d9c95231ac774ed71580754a15ebb3b121764310/ >>>> >>>> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com> >>>> --- >>>> package/lzo/lzo.mk | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/package/lzo/lzo.mk b/package/lzo/lzo.mk >>>> index 27ca459..0cafba2 100644 >>>> --- a/package/lzo/lzo.mk >>>> +++ b/package/lzo/lzo.mk >>>> @@ -11,6 +11,9 @@ LZO_LICENSE_FILES = COPYING >>>> LZO_INSTALL_STAGING = YES >>>> LZO_SUPPORTS_IN_SOURCE_BUILD = NO >>>> >>>> +# Prevent dynamically using lib64 as install libdir >>>> +HOST_LZO_CONF_OPTS += -DCMAKE_INSTALL_LIBDIR=lib >>> >>> So, probably other packages would have the same issue, then? And indeed, >>> we've just had Jan on IRC reporting the same issue with a new package >>> he's adding. >>> >>> So I suggest that we simply symlink lib64 -> lib like we do for the >>> target, and be done with it. >>> >>> Thoughts? Proposed patch to supersede this lzo patch using the symlink approach. Tested with a 32bit and 64bit archs. https://patchwork.ozlabs.org/patch/820978/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] host-lzo: default liblzo2.a install to host/lib 2017-10-03 16:42 ` Yann E. MORIN 2017-10-03 17:17 ` Matthew Weber @ 2017-10-03 19:12 ` Thomas Petazzoni 1 sibling, 0 replies; 6+ messages in thread From: Thomas Petazzoni @ 2017-10-03 19:12 UTC (permalink / raw) To: buildroot Hello, On Tue, 3 Oct 2017 18:42:22 +0200, Yann E. MORIN wrote: > > +# Prevent dynamically using lib64 as install libdir > > +HOST_LZO_CONF_OPTS += -DCMAKE_INSTALL_LIBDIR=lib > > So, probably other packages would have the same issue, then? And indeed, > we've just had Jan on IRC reporting the same issue with a new package > he's adding. > > So I suggest that we simply symlink lib64 -> lib like we do for the > target, and be done with it. > > Thoughts? Yes, I also think we need a more general solution that fixing each package one by one. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-03 19:12 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-10-03 13:49 [Buildroot] [PATCH] host-lzo: default liblzo2.a install to host/lib Matt Weber 2017-10-03 16:42 ` Yann E. MORIN 2017-10-03 17:17 ` Matthew Weber 2017-10-03 18:00 ` Matthew Weber 2017-10-03 18:15 ` Matthew Weber 2017-10-03 19:12 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox