* [Buildroot] [PATCH v2] package/turbolua: Fix build with gcc7
@ 2017-09-26 13:37 Marcin Niestroj
2017-10-03 20:41 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Marcin Niestroj @ 2017-09-26 13:37 UTC (permalink / raw)
To: buildroot
gcc7 has -Wimplicit-fallthrough enabled by default. Together with
-Werror in turbolua makefile it gives -Werror=implicit-fallthrough=
build error.
Add upstreamable patch [1], which fixes typo in FALLTHROUGH comment,
so it makes the fallthrough explicit for gcc.
[1] https://github.com/kernelsauce/turbo/pull/323
Fixes:
http://autobuild.buildroot.net/results/6f107b62f105508044185576b071323e5d73dd83
http://autobuild.buildroot.net/results/d303929960c667a21181d0bbdab64ba8a8d56a4f
Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
---
Changes v1 -> v2 (suggested by Baruch):
* Added Signed-off-by in patch
* Added link to upstream pull request in patch
| 31 ++++++++++++++++++++++
1 file changed, 31 insertions(+)
create mode 100644 package/turbolua/0001-http-parser-Fix-typo-in-switch-FALLTHROUGH-comment.patch
--git a/package/turbolua/0001-http-parser-Fix-typo-in-switch-FALLTHROUGH-comment.patch b/package/turbolua/0001-http-parser-Fix-typo-in-switch-FALLTHROUGH-comment.patch
new file mode 100644
index 0000000000..bb27056ac6
--- /dev/null
+++ b/package/turbolua/0001-http-parser-Fix-typo-in-switch-FALLTHROUGH-comment.patch
@@ -0,0 +1,31 @@
+From 570db52d7fd3b4deffe785e60fb362e1496844ee Mon Sep 17 00:00:00 2001
+From: Marcin Niestroj <m.niestroj@grinn-global.com>
+Date: Tue, 26 Sep 2017 12:10:53 +0200
+Subject: [PATCH] http-parser: Fix typo in switch FALLTHROUGH comment
+
+This also suppresses -Wimplicit-fallthrough warning, which is enabled
+in gcc7 by default.
+
+PR for upstream: https://github.com/kernelsauce/turbo/pull/323
+
+Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
+---
+ deps/http-parser/http_parser.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/deps/http-parser/http_parser.c b/deps/http-parser/http_parser.c
+index 8cf6fb0..2ff1073 100644
+--- a/deps/http-parser/http_parser.c
++++ b/deps/http-parser/http_parser.c
+@@ -2095,7 +2095,7 @@ http_parser_parse_url(
+ case s_req_server_with_at:
+ found_at = 1;
+
+- /* FALLTROUGH */
++ /* FALLTHROUGH */
+ case s_req_server:
+ uf = UF_HOST;
+ break;
+--
+2.14.1
+
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH v2] package/turbolua: Fix build with gcc7
2017-09-26 13:37 [Buildroot] [PATCH v2] package/turbolua: Fix build with gcc7 Marcin Niestroj
@ 2017-10-03 20:41 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2017-10-03 20:41 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 26 Sep 2017 15:37:16 +0200, Marcin Niestroj wrote:
> gcc7 has -Wimplicit-fallthrough enabled by default. Together with
> -Werror in turbolua makefile it gives -Werror=implicit-fallthrough=
> build error.
>
> Add upstreamable patch [1], which fixes typo in FALLTHROUGH comment,
> so it makes the fallthrough explicit for gcc.
>
> [1] https://github.com/kernelsauce/turbo/pull/323
>
> Fixes:
> http://autobuild.buildroot.net/results/6f107b62f105508044185576b071323e5d73dd83
> http://autobuild.buildroot.net/results/d303929960c667a21181d0bbdab64ba8a8d56a4f
>
> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
> ---
> Changes v1 -> v2 (suggested by Baruch):
> * Added Signed-off-by in patch
> * Added link to upstream pull request in patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-03 20:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-26 13:37 [Buildroot] [PATCH v2] package/turbolua: Fix build with gcc7 Marcin Niestroj
2017-10-03 20:41 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox