Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 2/3] package/freeswitch-mod-bcg729: new package
Date: Sun, 8 Oct 2017 23:15:01 +0200	[thread overview]
Message-ID: <20171008231501.793fdb96@windsurf> (raw)
In-Reply-To: <20171006202829.431-2-bernd.kuhls@t-online.de>

Hello,

On Fri,  6 Oct 2017 22:28:28 +0200, Bernd Kuhls wrote:
> This package is based on the bcg729 library from Belledonne Communica-
> tions which is wrapped into a freeswitch module to provide a native
> G729.A codec.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> v4: added dependency to !BR2_STATIC_LIBS (Arnout), added license hash
> v3: bumped to latest version
> v2: renamed package from freeswitch_mod_bcg729 to freeswitch-mod-bcg729
>     (Thomas)

Do be honest, I am not a big fan of the compile commands inside
Buildroot's .mk file. Wouldn't it be possible to patch the package
build system and get the patches merged upstream, if there is an active
upstream of course?

That being said, since there has been prior discussion with Arnout on
this, I'll assume the pros/cons have been weighted, so I've applied.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2017-10-08 21:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06 20:28 [Buildroot] [PATCH v4 1/3] package/bcg729: new package Bernd Kuhls
2017-10-06 20:28 ` [Buildroot] [PATCH v4 2/3] package/freeswitch-mod-bcg729: " Bernd Kuhls
2017-10-08 21:15   ` Thomas Petazzoni [this message]
2017-10-06 20:28 ` [Buildroot] [PATCH v4 3/3] package/freeswitch: Use mod_g729 only when freeswitch-mod-bcg729 is disabled Bernd Kuhls
2017-10-08 21:15   ` Thomas Petazzoni
2017-10-08 21:13 ` [Buildroot] [PATCH v4 1/3] package/bcg729: new package Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171008231501.793fdb96@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox