* [Buildroot] [PATCH v2 1/1] msgpack: bump version to 2.1.5
@ 2017-09-18 15:58 Bradford Barr
2017-09-19 21:19 ` Arnout Vandecappelle
0 siblings, 1 reply; 4+ messages in thread
From: Bradford Barr @ 2017-09-18 15:58 UTC (permalink / raw)
To: buildroot
From: bradford barr <bradford@density.io>
Modern versions of msgpack are hosted on Github. Msgpack switched their build
systems from autotools to cmake a while back. The licence was also updated from
Apache to Boost.
Signed-off-by: bradford barr <bradford@density.io>
---
package/msgpack/msgpack.hash | 2 +-
package/msgpack/msgpack.mk | 13 +++++++++----
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/package/msgpack/msgpack.hash b/package/msgpack/msgpack.hash
index 8cd8cb6..f1033ad 100644
--- a/package/msgpack/msgpack.hash
+++ b/package/msgpack/msgpack.hash
@@ -1,2 +1,2 @@
# Locally computed:
-sha256 97a371ef950c89f48e8dba6abeccab07f1887e9ba6dab921de0f985c7d5075fe msgpack-0.5.4.tar.gz
+sha256 9c87f80fc651b900772deaef0ab154b63160c74d292529b5be6d06d6485d4640 msgpack-2.1.5.tar.gz
diff --git a/package/msgpack/msgpack.mk b/package/msgpack/msgpack.mk
index 9e23948..66dbc8d 100644
--- a/package/msgpack/msgpack.mk
+++ b/package/msgpack/msgpack.mk
@@ -4,9 +4,14 @@
#
################################################################################
-MSGPACK_VERSION = 0.5.4
-MSGPACK_SITE = http://downloads.sourceforge.net/project/msgpack/msgpack/cpp
-MSGPACK_LICENSE = Apache-2.0
+MSGPACK_VERSION = 2.1.5
+MSGPACK_SITE = $(call github,msgpack,msgpack-c,cpp-$(MSGPACK_VERSION))
+MSGPACK_LICENSE = BSL-1.0
MSGPACK_LICENSE_FILES = COPYING
+MSGPACK_INSTALL_STAGING = YES
-$(eval $(autotools-package))
+define MSGPACK_INSTALL_TARGET_CMDS
+ cp -a $(@D)/libmsgpackc.so* $(TARGET_DIR)/usr/lib
+endef
+
+$(eval $(cmake-package))
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2 1/1] msgpack: bump version to 2.1.5
2017-09-18 15:58 [Buildroot] [PATCH v2 1/1] msgpack: bump version to 2.1.5 Bradford Barr
@ 2017-09-19 21:19 ` Arnout Vandecappelle
2017-09-20 1:13 ` Bradford Barr
0 siblings, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2017-09-19 21:19 UTC (permalink / raw)
To: buildroot
I was about to apply, however:
On 18-09-17 17:58, Bradford Barr wrote:
> From: bradford barr <bradford@density.io>
>
> Modern versions of msgpack are hosted on Github. Msgpack switched their build
> systems from autotools to cmake a while back. The licence was also updated from
> Apache to Boost.
>
> Signed-off-by: bradford barr <bradford@density.io>
> ---
> package/msgpack/msgpack.hash | 2 +-
> package/msgpack/msgpack.mk | 13 +++++++++----
> 2 files changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/package/msgpack/msgpack.hash b/package/msgpack/msgpack.hash
> index 8cd8cb6..f1033ad 100644
> --- a/package/msgpack/msgpack.hash
> +++ b/package/msgpack/msgpack.hash
> @@ -1,2 +1,2 @@
> # Locally computed:
> -sha256 97a371ef950c89f48e8dba6abeccab07f1887e9ba6dab921de0f985c7d5075fe msgpack-0.5.4.tar.gz
> +sha256 9c87f80fc651b900772deaef0ab154b63160c74d292529b5be6d06d6485d4640 msgpack-2.1.5.tar.gz
> diff --git a/package/msgpack/msgpack.mk b/package/msgpack/msgpack.mk
> index 9e23948..66dbc8d 100644
> --- a/package/msgpack/msgpack.mk
> +++ b/package/msgpack/msgpack.mk
> @@ -4,9 +4,14 @@
> #
> ################################################################################
>
> -MSGPACK_VERSION = 0.5.4
> -MSGPACK_SITE = http://downloads.sourceforge.net/project/msgpack/msgpack/cpp
> -MSGPACK_LICENSE = Apache-2.0
> +MSGPACK_VERSION = 2.1.5
> +MSGPACK_SITE = $(call github,msgpack,msgpack-c,cpp-$(MSGPACK_VERSION))
> +MSGPACK_LICENSE = BSL-1.0
> MSGPACK_LICENSE_FILES = COPYING
> +MSGPACK_INSTALL_STAGING = YES
>
> -$(eval $(autotools-package))
> +define MSGPACK_INSTALL_TARGET_CMDS
> + cp -a $(@D)/libmsgpackc.so* $(TARGET_DIR)/usr/lib
> +endef
Why does the default "make install" not work?
> +
> +$(eval $(cmake-package))
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2 1/1] msgpack: bump version to 2.1.5
2017-09-19 21:19 ` Arnout Vandecappelle
@ 2017-09-20 1:13 ` Bradford Barr
2017-10-08 21:21 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Bradford Barr @ 2017-09-20 1:13 UTC (permalink / raw)
To: buildroot
On Tue, Sep 19, 2017 at 5:19 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
> I was about to apply, however:
>
> On 18-09-17 17:58, Bradford Barr wrote:
>> From: bradford barr <bradford@density.io>
>>
>> Modern versions of msgpack are hosted on Github. Msgpack switched their build
>> systems from autotools to cmake a while back. The licence was also updated from
>> Apache to Boost.
>>
>> Signed-off-by: bradford barr <bradford@density.io>
>> ---
>> package/msgpack/msgpack.hash | 2 +-
>> package/msgpack/msgpack.mk | 13 +++++++++----
>> 2 files changed, 10 insertions(+), 5 deletions(-)
>>
>> diff --git a/package/msgpack/msgpack.hash b/package/msgpack/msgpack.hash
>> index 8cd8cb6..f1033ad 100644
>> --- a/package/msgpack/msgpack.hash
>> +++ b/package/msgpack/msgpack.hash
>> @@ -1,2 +1,2 @@
>> # Locally computed:
>> -sha256 97a371ef950c89f48e8dba6abeccab07f1887e9ba6dab921de0f985c7d5075fe msgpack-0.5.4.tar.gz
>> +sha256 9c87f80fc651b900772deaef0ab154b63160c74d292529b5be6d06d6485d4640 msgpack-2.1.5.tar.gz
>> diff --git a/package/msgpack/msgpack.mk b/package/msgpack/msgpack.mk
>> index 9e23948..66dbc8d 100644
>> --- a/package/msgpack/msgpack.mk
>> +++ b/package/msgpack/msgpack.mk
>> @@ -4,9 +4,14 @@
>> #
>> ################################################################################
>>
>> -MSGPACK_VERSION = 0.5.4
>> -MSGPACK_SITE = http://downloads.sourceforge.net/project/msgpack/msgpack/cpp
>> -MSGPACK_LICENSE = Apache-2.0
>> +MSGPACK_VERSION = 2.1.5
>> +MSGPACK_SITE = $(call github,msgpack,msgpack-c,cpp-$(MSGPACK_VERSION))
>> +MSGPACK_LICENSE = BSL-1.0
>> MSGPACK_LICENSE_FILES = COPYING
>> +MSGPACK_INSTALL_STAGING = YES
>>
>> -$(eval $(autotools-package))
>> +define MSGPACK_INSTALL_TARGET_CMDS
>> + cp -a $(@D)/libmsgpackc.so* $(TARGET_DIR)/usr/lib
>> +endef
>
> Why does the default "make install" not work?
The default "make install" installs all of the header files, cmake
modules, pkg-config files, and the static library along side the
dynamic libraries. I figured it'd be best if the package just
installed the dynamic libraries on the target. Let me know if you'd
prefer the default "make install".
>
>
>> +
>> +$(eval $(cmake-package))
>>
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Thanks,
B
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2 1/1] msgpack: bump version to 2.1.5
2017-09-20 1:13 ` Bradford Barr
@ 2017-10-08 21:21 ` Thomas Petazzoni
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2017-10-08 21:21 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 19 Sep 2017 21:13:31 -0400, Bradford Barr wrote:
> The default "make install" installs all of the header files, cmake
> modules, pkg-config files, and the static library along side the
> dynamic libraries. I figured it'd be best if the package just
> installed the dynamic libraries on the target. Let me know if you'd
> prefer the default "make install".
What you did is not needed at all: Buildroot already removes header
files, pkg-config files, static libraries, etc. from $(TARGET_DIR) at
the end of the build.
If you drop your custom installation command, here is what is left from
msgpack in $(TARGET_DIR) at the end of the buid:
output/target/usr/lib/libmsgpackc.so
output/target/usr/lib/libmsgpackc.so.2.0.0
output/target/usr/lib/libmsgpackc.so.2
Which is exactly what we want.
Also, I've added LICENSE_1_0.txt to the list of license files, because
COPYING was not very useful by itself.
Applied with those changes. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-08 21:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-18 15:58 [Buildroot] [PATCH v2 1/1] msgpack: bump version to 2.1.5 Bradford Barr
2017-09-19 21:19 ` Arnout Vandecappelle
2017-09-20 1:13 ` Bradford Barr
2017-10-08 21:21 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox