From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/run-tests: export download dir
Date: Tue, 10 Oct 2017 23:33:47 +0200 [thread overview]
Message-ID: <20171010233347.5907a289@windsurf.lan> (raw)
In-Reply-To: <20170917092028.5236-1-yann.morin.1998@free.fr>
Hello,
On Sun, 17 Sep 2017 11:20:28 +0200, Yann E. MORIN wrote:
> Currently, the download directory, when specified with the -d option, is
> only used to store the files downloaded by the testing infra, not those
> downloaded by Buildroot.
>
> So, we end up with this situation:
>
> BR2_DL_DIR | -d DIR | test downloads | BR downloads
> ------------+----------+------------------+--------------
> unset | unset | [error] | [error]
> unset | set | in $(DIR) | in $(TOP_DIR)/dl
> set | unset | in $(BR2_DL_DIR) | in $(BR2_DL_DIR)
> set | set | in $(DIR) | in $(BR2_DL_DIR)
>
> This is not very consistent.
>
> We change the behaviour so that the value of -d always takes precedence,
> and is used by Buildroot as well, giving this new behaviour:
>
> BR2_DL_DIR | -d DIR | test downloads | BR downloads
> ------------+----------+------------------+--------------
> unset | unset | [error] | [error]
> unset | set | in $(DIR) | in $(DIR)
> set | unset | in $(BR2_DL_DIR) | in $(BR2_DL_DIR)
> set | set | in $(DIR) | in $(DIR)
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> support/testing/run-tests | 1 +
> 1 file changed, 1 insertion(+)
Indeed, makes sense. Applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2017-10-10 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-17 9:20 [Buildroot] [PATCH] support/run-tests: export download dir Yann E. MORIN
2017-10-10 21:33 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010233347.5907a289@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox