* [Buildroot] [PATCH v1] evemu: fix PATH_MAX related compile failure
@ 2017-10-01 18:04 Peter Seiderer
2017-10-06 18:56 ` Arnout Vandecappelle
0 siblings, 1 reply; 3+ messages in thread
From: Peter Seiderer @ 2017-10-01 18:04 UTC (permalink / raw)
To: buildroot
Fixes [1]:
find_event_devices.c: In function 'find_event_devices':
find_event_devices.c:60:14: error: 'PATH_MAX' undeclared (first use in this function)
char fname[PATH_MAX];
^~~~~~~~
[1] http://autobuild.buildroot.net/results/607/607bb29231f80a138e1b5423bc01c89e36efe78c/
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
...0001-Fix-PATH_MAX-related-compile-failure.patch | 35 ++++++++++++++++++++++
1 file changed, 35 insertions(+)
create mode 100644 package/evemu/0001-Fix-PATH_MAX-related-compile-failure.patch
diff --git a/package/evemu/0001-Fix-PATH_MAX-related-compile-failure.patch b/package/evemu/0001-Fix-PATH_MAX-related-compile-failure.patch
new file mode 100644
index 0000000000..4f4f795e07
--- /dev/null
+++ b/package/evemu/0001-Fix-PATH_MAX-related-compile-failure.patch
@@ -0,0 +1,35 @@
+From 8164f4e7707012fcfce0cd178cc326e8af8ce8bc Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <ps.report@gmx.net>
+Date: Sun, 1 Oct 2017 19:54:53 +0200
+Subject: [PATCH] Fix PATH_MAX related compile failure.
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Fixes:
+
+ find_event_devices.c: In function ?find_event_devices?:
+ find_event_devices.c:60:14: error: ?PATH_MAX? undeclared (first use in this function)
+ char fname[PATH_MAX];
+ ^~~~~~~~
+
+Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+---
+ tools/find_event_devices.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tools/find_event_devices.c b/tools/find_event_devices.c
+index 2a43d54..e5dbcd2 100644
+--- a/tools/find_event_devices.c
++++ b/tools/find_event_devices.c
+@@ -24,6 +24,7 @@
+
+ #define _GNU_SOURCE
+ #include <linux/input.h>
++#include <linux/limits.h>
+ #include <dirent.h>
+ #include <string.h>
+ #include <stdio.h>
+--
+2.14.1
+
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v1] evemu: fix PATH_MAX related compile failure
2017-10-01 18:04 [Buildroot] [PATCH v1] evemu: fix PATH_MAX related compile failure Peter Seiderer
@ 2017-10-06 18:56 ` Arnout Vandecappelle
2017-10-11 9:14 ` Peter Seiderer
0 siblings, 1 reply; 3+ messages in thread
From: Arnout Vandecappelle @ 2017-10-06 18:56 UTC (permalink / raw)
To: buildroot
Hi Peter,
On 01-10-17 20:04, Peter Seiderer wrote:
> Fixes [1]:
>
> find_event_devices.c: In function 'find_event_devices':
> find_event_devices.c:60:14: error: 'PATH_MAX' undeclared (first use in this function)
> char fname[PATH_MAX];
> ^~~~~~~~
>
> [1] http://autobuild.buildroot.net/results/607/607bb29231f80a138e1b5423bc01c89e36efe78c/
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> ...0001-Fix-PATH_MAX-related-compile-failure.patch | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 package/evemu/0001-Fix-PATH_MAX-related-compile-failure.patch
>
> diff --git a/package/evemu/0001-Fix-PATH_MAX-related-compile-failure.patch b/package/evemu/0001-Fix-PATH_MAX-related-compile-failure.patch
> new file mode 100644
> index 0000000000..4f4f795e07
> --- /dev/null
> +++ b/package/evemu/0001-Fix-PATH_MAX-related-compile-failure.patch
> @@ -0,0 +1,35 @@
> +From 8164f4e7707012fcfce0cd178cc326e8af8ce8bc Mon Sep 17 00:00:00 2001
> +From: Peter Seiderer <ps.report@gmx.net>
> +Date: Sun, 1 Oct 2017 19:54:53 +0200
> +Subject: [PATCH] Fix PATH_MAX related compile failure.
A better commit message would be "Include limits.h for PATH_MAX"
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +Fixes:
> +
> + find_event_devices.c: In function ?find_event_devices?:
> + find_event_devices.c:60:14: error: ?PATH_MAX? undeclared (first use in this function)
> + char fname[PATH_MAX];
> + ^~~~~~~~
And also add:
when building with musl.
> +
> +Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> +---
> + tools/find_event_devices.c | 1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/tools/find_event_devices.c b/tools/find_event_devices.c
> +index 2a43d54..e5dbcd2 100644
> +--- a/tools/find_event_devices.c
> ++++ b/tools/find_event_devices.c
> +@@ -24,6 +24,7 @@
> +
> + #define _GNU_SOURCE
> + #include <linux/input.h>
> ++#include <linux/limits.h>
The proper place (according to POSIX) is limits.h, not linux/limits.h.
Also, did you send the patch upstream?
Regards,
Arnout
> + #include <dirent.h>
> + #include <string.h>
> + #include <stdio.h>
> +--
> +2.14.1
> +
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v1] evemu: fix PATH_MAX related compile failure
2017-10-06 18:56 ` Arnout Vandecappelle
@ 2017-10-11 9:14 ` Peter Seiderer
0 siblings, 0 replies; 3+ messages in thread
From: Peter Seiderer @ 2017-10-11 9:14 UTC (permalink / raw)
To: buildroot
Hello Arnout,
On Fri, 6 Oct 2017 20:56:18 +0200, Arnout Vandecappelle <arnout@mind.be> wrote:
> Hi Peter,
>
> On 01-10-17 20:04, Peter Seiderer wrote:
> > Fixes [1]:
> >
> > find_event_devices.c: In function 'find_event_devices':
> > find_event_devices.c:60:14: error: 'PATH_MAX' undeclared (first use in this function)
> > char fname[PATH_MAX];
> > ^~~~~~~~
> >
> > [1] http://autobuild.buildroot.net/results/607/607bb29231f80a138e1b5423bc01c89e36efe78c/
> >
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> > ...0001-Fix-PATH_MAX-related-compile-failure.patch | 35 ++++++++++++++++++++++
> > 1 file changed, 35 insertions(+)
> > create mode 100644 package/evemu/0001-Fix-PATH_MAX-related-compile-failure.patch
> >
> > diff --git a/package/evemu/0001-Fix-PATH_MAX-related-compile-failure.patch b/package/evemu/0001-Fix-PATH_MAX-related-compile-failure.patch
> > new file mode 100644
> > index 0000000000..4f4f795e07
> > --- /dev/null
> > +++ b/package/evemu/0001-Fix-PATH_MAX-related-compile-failure.patch
> > @@ -0,0 +1,35 @@
> > +From 8164f4e7707012fcfce0cd178cc326e8af8ce8bc Mon Sep 17 00:00:00 2001
> > +From: Peter Seiderer <ps.report@gmx.net>
> > +Date: Sun, 1 Oct 2017 19:54:53 +0200
> > +Subject: [PATCH] Fix PATH_MAX related compile failure.
>
> A better commit message would be "Include limits.h for PATH_MAX"
O.k, fixed...
>
> > +MIME-Version: 1.0
> > +Content-Type: text/plain; charset=UTF-8
> > +Content-Transfer-Encoding: 8bit
> > +
> > +Fixes:
> > +
> > + find_event_devices.c: In function ?find_event_devices?:
> > + find_event_devices.c:60:14: error: ?PATH_MAX? undeclared (first use in this function)
> > + char fname[PATH_MAX];
> > + ^~~~~~~~
>
> And also add:
>
> when building with musl.
O.k, done...
>
> > +
> > +Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > +---
> > + tools/find_event_devices.c | 1 +
> > + 1 file changed, 1 insertion(+)
> > +
> > +diff --git a/tools/find_event_devices.c b/tools/find_event_devices.c
> > +index 2a43d54..e5dbcd2 100644
> > +--- a/tools/find_event_devices.c
> > ++++ b/tools/find_event_devices.c
> > +@@ -24,6 +24,7 @@
> > +
> > + #define _GNU_SOURCE
> > + #include <linux/input.h>
> > ++#include <linux/limits.h>
>
> The proper place (according to POSIX) is limits.h, not linux/limits.h.
O.k, changed...updated patch will follow...
>
> Also, did you send the patch upstream?
Not yet, but will do...
Regards,
Peter
>
> Regards,
> Arnout
>
> > + #include <dirent.h>
> > + #include <string.h>
> > + #include <stdio.h>
> > +--
> > +2.14.1
> > +
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-11 9:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-01 18:04 [Buildroot] [PATCH v1] evemu: fix PATH_MAX related compile failure Peter Seiderer
2017-10-06 18:56 ` Arnout Vandecappelle
2017-10-11 9:14 ` Peter Seiderer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox