Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dushara Jayasinghe <nidujay@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] prosody: bump to version 0.10.0
Date: Mon, 16 Oct 2017 06:53:04 +1100	[thread overview]
Message-ID: <20171015195304.GA10161@localhost> (raw)
In-Reply-To: <20171014133956.25082-1-francois.perrad@gadz.org>

Hi Francois,

I'm listed as the maintainer for Prosody simply by virtue of the
fact that I first added the Prosody package. I'm not a Prosody
dev, so these are more questions than comments...

>  	-- Not essential, but recommended
> +		"carbons"; -- Keep multiple clients in sync
> +		"pep"; -- Enables users to publish their mood, activity, playing music and more
>  		"private"; -- Private XML storage (for room bookmarks, etc.)
> +		"blocklist"; -- Allow users to block communications with other users
>  		"vcard"; -- Allow users to set vCards
I had a brief look at the release notes, and they state that the new modules that you added
are 'native', does that mean that the required libraries are automatically included in the
install?

>  	-- Other specific functionality
> -		"posix"; -- POSIX functionality, sends server to background, enables syslog, etc.
Did you mean to comment this out?

> --- These are the SSL/TLS-related settings. If you don't want
> --- to use SSL/TLS, you may comment or remove this
> -ssl = {
> -	key = "certs/localhost.key";
> -	certificate = "certs/localhost.crt";
> -}
Does Prosody start without any certificates? The config I provided was just enough to allow
Prosody to start and accessible (albeit the user needs to make adjustments to suite that site).

> -authentication = "internal_plain"
> +authentication = "internal_hashed"
That's a good idea.

>  log = {
> -	-- info = "prosody.log"; -- Change 'info' to 'debug' for verbose logging
> -	-- error = "prosody.err";
> -	"*syslog"; -- Logging to syslog
> +	info = "prosody.log"; -- Change 'info' to 'debug' for verbose logging
> +	error = "prosody.err";
Where are these files created? In root I believe. My preferance is to just use syslog. I think
the posix module needs to be enabled for syslog to work though.

> -pidfile = "/var/run/prosody/prosody.pid"
Is this intentional? I used the pidfile to allow the startup script to terminate the service.
Can you still terminate the service without this?

As I said earlier, I'm not a Prosody dev, so your changes may be perfectly valid. If so,
explaining those changes in the commit message would be useful. I've CCd the dev mailing list
in case they have additional comments.

Thanks,

Dushara

  reply	other threads:[~2017-10-15 19:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-14 13:39 [Buildroot] [PATCH] prosody: bump to version 0.10.0 Francois Perrad
2017-10-15 19:53 ` Dushara Jayasinghe [this message]
2017-10-16 18:54 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171015195304.GA10161@localhost \
    --to=nidujay@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox