From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] prosody: bump to version 0.10.0
Date: Mon, 16 Oct 2017 20:54:24 +0200 [thread overview]
Message-ID: <20171016205424.357bf369@windsurf.lan> (raw)
In-Reply-To: <20171014133956.25082-1-francois.perrad@gadz.org>
Hello,
On Sat, 14 Oct 2017 15:39:56 +0200, Francois Perrad wrote:
> this version is not restricted to Lua 5.1
> the configure step is refactored with the variable PROSODY_CONF_OPTS
>
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
Thanks for this bump. One question below though.
> -PROSODY_VERSION = 0.9.12
> +PROSODY_VERSION = 0.10.0
> PROSODY_SITE = https://prosody.im/downloads/source
> PROSODY_LICENSE = MIT
> PROSODY_LICENSE_FILES = COPYING
> -PROSODY_DEPENDENCIES = openssl libidn
> +PROSODY_DEPENDENCIES = host-luainterpreter luainterpreter libidn openssl
Why do we need host-luainterpreter? There wasn't such a dependency in
the previous version.
> -ifeq ($(BR2_PACKAGE_LUA_5_1),y)
> -PROSODY_DEPENDENCIES += lua
> -endif
> +PROSODY_CONF_OPTS = \
> + --with-lua-bin="$(HOST_DIR)/usr/bin" \
> + --with-lua="$(STAGING_DIR)/usr" \
> + --lua-version=$(LUAINTERPRETER_ABIVER) \
> + --c-compiler=$(TARGET_CC) \
> + --cflags="$(TARGET_CFLAGS)" \
> + --linker=$(TARGET_CC) \
> + --ldflags="$(TARGET_LDFLAGS) -shared" \
> + --sysconfdir=/etc/prosody \
> + --prefix="/usr"
>
> ifeq ($(BR2_PACKAGE_LUAJIT),y)
> -PROSODY_DEPENDENCIES += luajit
> +PROSODY_CONF_OPTS += --runwith=luajit
> endif
>
> define PROSODY_CONFIGURE_CMDS
> - cd $(@D) && \
> - $(TARGET_CONFIGURE_OPTS) \
> - ./configure --prefix=/usr \
> - --c-compiler=$(TARGET_CC) \
> - --cflags="$(TARGET_CFLAGS)" \
> - --linker=$(TARGET_CC) \
> - --ldflags="$(TARGET_LDFLAGS) -shared" \
> - --sysconfdir=/etc/prosody \
> - --with-lua=$(STAGING_DIR)/usr
> + cd $(@D) && ./configure $(PROSODY_CONF_OPTS)
Even though the refactoring of CONF_OPTS is related to the bump, it
would have been nice to have it as a separate patch, prior to the bump.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-10-16 18:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 13:39 [Buildroot] [PATCH] prosody: bump to version 0.10.0 Francois Perrad
2017-10-15 19:53 ` Dushara Jayasinghe
2017-10-16 18:54 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016205424.357bf369@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox