* [Buildroot] [PATCH] powertop: needs autoreconf
@ 2017-10-18 18:03 Baruch Siach
2017-10-18 18:58 ` Romain Naour
2017-10-18 20:29 ` Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Baruch Siach @ 2017-10-18 18:03 UTC (permalink / raw)
To: buildroot
Commit 01048deab60 (package/powertop: bump to version 2.9) removed
autoreconf even though the remaining patch touches Makefile.am. Fix
this.
Fixes:
http://autobuild.buildroot.net/results/3bf/3bf8daee559e2978f8602c56397afda771299032/
http://autobuild.buildroot.net/results/f9b/f9b4f113a333107a972fa51bd0347eeb0d52496f/
http://autobuild.buildroot.net/results/067/0675826888b6f89e76291c7835839344300ca9f5/
Cc: Romain Naour <romain.naour@gmail.com>
Cc: Steven Noonan <steven@uplinklabs.net>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/powertop/powertop.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/powertop/powertop.mk b/package/powertop/powertop.mk
index ce7a11875894..7c9c7ccc3f41 100644
--- a/package/powertop/powertop.mk
+++ b/package/powertop/powertop.mk
@@ -12,6 +12,8 @@ POWERTOP_DEPENDENCIES = pciutils ncurses libnl host-pkgconf \
POWERTOP_LICENSE = GPL-2.0
POWERTOP_LICENSE_FILES = COPYING
POWERTOP_CONF_ENV = LIBS=$(TARGET_NLS_LIBS)
+# Patching Makefile.am
+POWERTOP_AUTORECONF = YES
# Help powertop at finding the right ncurses library depending on
# which one is available.
--
2.14.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] powertop: needs autoreconf
2017-10-18 18:03 [Buildroot] [PATCH] powertop: needs autoreconf Baruch Siach
@ 2017-10-18 18:58 ` Romain Naour
2017-10-18 19:33 ` Baruch Siach
2017-10-18 20:29 ` Thomas Petazzoni
1 sibling, 1 reply; 5+ messages in thread
From: Romain Naour @ 2017-10-18 18:58 UTC (permalink / raw)
To: buildroot
Hi Baruch,
Le 18/10/2017 ? 20:03, Baruch Siach a ?crit?:
> Commit 01048deab60 (package/powertop: bump to version 2.9) removed
> autoreconf even though the remaining patch touches Makefile.am. Fix
> this.
Indeed...
I don't recall what happened, probably I had the intend to remove all patches
with the version bump but I finally re-added
0001-dont-force-stack-smashing-protection.patch.
The issue appear now following the automake bump 1.15.1.
>
> Fixes:
> http://autobuild.buildroot.net/results/3bf/3bf8daee559e2978f8602c56397afda771299032/
> http://autobuild.buildroot.net/results/f9b/f9b4f113a333107a972fa51bd0347eeb0d52496f/
> http://autobuild.buildroot.net/results/067/0675826888b6f89e76291c7835839344300ca9f5/
>
> Cc: Romain Naour <romain.naour@gmail.com>
> Cc: Steven Noonan <steven@uplinklabs.net>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/powertop/powertop.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/powertop/powertop.mk b/package/powertop/powertop.mk
> index ce7a11875894..7c9c7ccc3f41 100644
> --- a/package/powertop/powertop.mk
> +++ b/package/powertop/powertop.mk
> @@ -12,6 +12,8 @@ POWERTOP_DEPENDENCIES = pciutils ncurses libnl host-pkgconf \
> POWERTOP_LICENSE = GPL-2.0
> POWERTOP_LICENSE_FILES = COPYING
> POWERTOP_CONF_ENV = LIBS=$(TARGET_NLS_LIBS)
> +# Patching Makefile.am
Maybe you can name the patch here
# 0001-dont-force-stack-smashing-protection.patch
> +POWERTOP_AUTORECONF = YES
Gettextize was needed with powertop 2.27, can you check if it's still needed ?
Best regards,
Romain
>
> # Help powertop at finding the right ncurses library depending on
> # which one is available.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] powertop: needs autoreconf
2017-10-18 18:58 ` Romain Naour
@ 2017-10-18 19:33 ` Baruch Siach
2017-10-18 20:57 ` Romain Naour
0 siblings, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2017-10-18 19:33 UTC (permalink / raw)
To: buildroot
Hi Romain,
On Wed, Oct 18, 2017 at 08:58:55PM +0200, Romain Naour wrote:
> Le 18/10/2017 ? 20:03, Baruch Siach a ?crit?:
> > Commit 01048deab60 (package/powertop: bump to version 2.9) removed
> > autoreconf even though the remaining patch touches Makefile.am. Fix
> > this.
>
> Indeed...
> I don't recall what happened, probably I had the intend to remove all patches
> with the version bump but I finally re-added
> 0001-dont-force-stack-smashing-protection.patch.
>
> The issue appear now following the automake bump 1.15.1.
>
> > Fixes:
> > http://autobuild.buildroot.net/results/3bf/3bf8daee559e2978f8602c56397afda771299032/
> > http://autobuild.buildroot.net/results/f9b/f9b4f113a333107a972fa51bd0347eeb0d52496f/
> > http://autobuild.buildroot.net/results/067/0675826888b6f89e76291c7835839344300ca9f5/
> >
> > Cc: Romain Naour <romain.naour@gmail.com>
> > Cc: Steven Noonan <steven@uplinklabs.net>
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> > package/powertop/powertop.mk | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/package/powertop/powertop.mk b/package/powertop/powertop.mk
> > index ce7a11875894..7c9c7ccc3f41 100644
> > --- a/package/powertop/powertop.mk
> > +++ b/package/powertop/powertop.mk
> > @@ -12,6 +12,8 @@ POWERTOP_DEPENDENCIES = pciutils ncurses libnl host-pkgconf \
> > POWERTOP_LICENSE = GPL-2.0
> > POWERTOP_LICENSE_FILES = COPYING
> > POWERTOP_CONF_ENV = LIBS=$(TARGET_NLS_LIBS)
> > +# Patching Makefile.am
>
> Maybe you can name the patch here
> # 0001-dont-force-stack-smashing-protection.patch
>
> > +POWERTOP_AUTORECONF = YES
>
> Gettextize was needed with powertop 2.27, can you check if it's still needed ?
The build succeeds here without gettextize. The same config fails without the
patch with the same error as the autobuilder.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] powertop: needs autoreconf
2017-10-18 19:33 ` Baruch Siach
@ 2017-10-18 20:57 ` Romain Naour
0 siblings, 0 replies; 5+ messages in thread
From: Romain Naour @ 2017-10-18 20:57 UTC (permalink / raw)
To: buildroot
Hi Baruch,
Le 18/10/2017 ? 21:33, Baruch Siach a ?crit?:
> Hi Romain,
>
> On Wed, Oct 18, 2017 at 08:58:55PM +0200, Romain Naour wrote:
>> Le 18/10/2017 ? 20:03, Baruch Siach a ?crit?:
>>> Commit 01048deab60 (package/powertop: bump to version 2.9) removed
>>> autoreconf even though the remaining patch touches Makefile.am. Fix
>>> this.
>>
>> Indeed...
>> I don't recall what happened, probably I had the intend to remove all patches
>> with the version bump but I finally re-added
>> 0001-dont-force-stack-smashing-protection.patch.
>>
>> The issue appear now following the automake bump 1.15.1.
>>
>>> Fixes:
>>> http://autobuild.buildroot.net/results/3bf/3bf8daee559e2978f8602c56397afda771299032/
>>> http://autobuild.buildroot.net/results/f9b/f9b4f113a333107a972fa51bd0347eeb0d52496f/
>>> http://autobuild.buildroot.net/results/067/0675826888b6f89e76291c7835839344300ca9f5/
>>>
>>> Cc: Romain Naour <romain.naour@gmail.com>
>>> Cc: Steven Noonan <steven@uplinklabs.net>
>>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>>> ---
>>> package/powertop/powertop.mk | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/package/powertop/powertop.mk b/package/powertop/powertop.mk
>>> index ce7a11875894..7c9c7ccc3f41 100644
>>> --- a/package/powertop/powertop.mk
>>> +++ b/package/powertop/powertop.mk
>>> @@ -12,6 +12,8 @@ POWERTOP_DEPENDENCIES = pciutils ncurses libnl host-pkgconf \
>>> POWERTOP_LICENSE = GPL-2.0
>>> POWERTOP_LICENSE_FILES = COPYING
>>> POWERTOP_CONF_ENV = LIBS=$(TARGET_NLS_LIBS)
>>> +# Patching Makefile.am
>>
>> Maybe you can name the patch here
>> # 0001-dont-force-stack-smashing-protection.patch
>>
>>> +POWERTOP_AUTORECONF = YES
>>
>> Gettextize was needed with powertop 2.27, can you check if it's still needed ?
>
> The build succeeds here without gettextize. The same config fails without the
> patch with the same error as the autobuilder.
Thanks for checking :)
Best regards,
Romain
>
> baruch
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] powertop: needs autoreconf
2017-10-18 18:03 [Buildroot] [PATCH] powertop: needs autoreconf Baruch Siach
2017-10-18 18:58 ` Romain Naour
@ 2017-10-18 20:29 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2017-10-18 20:29 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 18 Oct 2017 21:03:57 +0300, Baruch Siach wrote:
> Commit 01048deab60 (package/powertop: bump to version 2.9) removed
> autoreconf even though the remaining patch touches Makefile.am. Fix
> this.
>
> Fixes:
> http://autobuild.buildroot.net/results/3bf/3bf8daee559e2978f8602c56397afda771299032/
> http://autobuild.buildroot.net/results/f9b/f9b4f113a333107a972fa51bd0347eeb0d52496f/
> http://autobuild.buildroot.net/results/067/0675826888b6f89e76291c7835839344300ca9f5/
>
> Cc: Romain Naour <romain.naour@gmail.com>
> Cc: Steven Noonan <steven@uplinklabs.net>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/powertop/powertop.mk | 2 ++
> 1 file changed, 2 insertions(+)
Applied to master after tweaking the comment to mention exactly which
patch requires autoreconf, as suggested by Romain.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-18 20:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-18 18:03 [Buildroot] [PATCH] powertop: needs autoreconf Baruch Siach
2017-10-18 18:58 ` Romain Naour
2017-10-18 19:33 ` Baruch Siach
2017-10-18 20:57 ` Romain Naour
2017-10-18 20:29 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox