From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [V2 1/3] prosody: refactor with PROSODY_CONF_OPTS variable
Date: Wed, 18 Oct 2017 22:30:10 +0200 [thread overview]
Message-ID: <20171018223010.7e2142be@windsurf.home> (raw)
In-Reply-To: <20171018164650.514-1-francois.perrad@gadz.org>
Hello,
On Wed, 18 Oct 2017 18:46:48 +0200, Francois Perrad wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> package/prosody/prosody.mk | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/package/prosody/prosody.mk b/package/prosody/prosody.mk
> index f7a325b46..5669f7707 100644
> --- a/package/prosody/prosody.mk
> +++ b/package/prosody/prosody.mk
> @@ -18,16 +18,17 @@ ifeq ($(BR2_PACKAGE_LUAJIT),y)
> PROSODY_DEPENDENCIES += luajit
> endif
>
> +PROSODY_CONF_OPTS = \
> + --with-lua=$(STAGING_DIR)/usr \
> + --c-compiler=$(TARGET_CC) \
> + --cflags="$(TARGET_CFLAGS)" \
> + --linker=$(TARGET_CC) \
> + --ldflags="$(TARGET_LDFLAGS) -shared" \
> + --sysconfdir=/etc/prosody \
> + --prefix=/usr
> +
> define PROSODY_CONFIGURE_CMDS
> - cd $(@D) && \
> - $(TARGET_CONFIGURE_OPTS) \
> - ./configure --prefix=/usr \
> - --c-compiler=$(TARGET_CC) \
> - --cflags="$(TARGET_CFLAGS)" \
> - --linker=$(TARGET_CC) \
> - --ldflags="$(TARGET_LDFLAGS) -shared" \
> - --sysconfdir=/etc/prosody \
> - --with-lua=$(STAGING_DIR)/usr
> + cd $(@D) && ./configure $(PROSODY_CONF_OPTS)
This has a pretty strong side-effect: $(TARGET_CONFIGURE_OPTS) is no
longer passed in the environment. It is unrelated to the refactoring,
and not explained anywhere in the commit log.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-10-18 20:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 16:46 [Buildroot] [V2 1/3] prosody: refactor with PROSODY_CONF_OPTS variable Francois Perrad
2017-10-18 16:46 ` [Buildroot] [V2 2/3] prosody: bump to version 0.10.0 Francois Perrad
2017-10-21 10:39 ` Thomas Petazzoni
2017-10-18 16:46 ` [Buildroot] [V2 3/3] prosody: remove tweaked configuration Francois Perrad
2017-10-18 20:31 ` Thomas Petazzoni
2017-10-19 10:20 ` Dushara Jayasinghe
2017-10-18 20:30 ` Thomas Petazzoni [this message]
2017-10-21 9:47 ` [Buildroot] [V2 1/3] prosody: refactor with PROSODY_CONF_OPTS variable Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018223010.7e2142be@windsurf.home \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox