Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dushara Jayasinghe <nidujay@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [V2 3/3] prosody: remove tweaked configuration
Date: Thu, 19 Oct 2017 21:20:45 +1100	[thread overview]
Message-ID: <20171019102045.GA4544@localhost> (raw)
In-Reply-To: <20171018223136.49cbc0de@windsurf.home>

Hi,

On Wed, Oct 18, 2017 at 10:31:36PM +0200, Thomas Petazzoni wrote:
> Hello,
> 
> On Wed, 18 Oct 2017 18:46:50 +0200, Francois Perrad wrote:
> > Upgrading a tweaked configuration is painful,
> > so stay with the upstream configuration which is already installed.
> > 
> > Everybody could make its own configuration in its rootfs_overlay.
> > 
> > Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> > ---
> >  package/prosody/prosody.cfg.lua | 184 ----------------------------------------
> >  package/prosody/prosody.mk      |  11 ---
> >  2 files changed, 195 deletions(-)
> >  delete mode 100644 package/prosody/prosody.cfg.lua
> 
> I'd like to have the opinion of the package submitter, Dushara
> Jayasinghe, on this patch. Dushara, can you comment on why you added a
> custom prosody.cfg, as opposed to using the one provided in the
> upstream package?

My primary motive was for the package to 'just work'. 

1. Prosody requires the posix module to be enabled for proper deamonization
2. Logging by default is to files and not syslog (for this too, the
   posix module is required)
3. I added a service startup script. However, in order to terminate the
   service cleanly, a pidfile is required (due to lua being the process
   name). Prosody has a config option to create the pidfile.

Hope that helps.

Dushara

  reply	other threads:[~2017-10-19 10:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-18 16:46 [Buildroot] [V2 1/3] prosody: refactor with PROSODY_CONF_OPTS variable Francois Perrad
2017-10-18 16:46 ` [Buildroot] [V2 2/3] prosody: bump to version 0.10.0 Francois Perrad
2017-10-21 10:39   ` Thomas Petazzoni
2017-10-18 16:46 ` [Buildroot] [V2 3/3] prosody: remove tweaked configuration Francois Perrad
2017-10-18 20:31   ` Thomas Petazzoni
2017-10-19 10:20     ` Dushara Jayasinghe [this message]
2017-10-18 20:30 ` [Buildroot] [V2 1/3] prosody: refactor with PROSODY_CONF_OPTS variable Thomas Petazzoni
2017-10-21  9:47 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171019102045.GA4544@localhost \
    --to=nidujay@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox