Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] lvm2: make basic package available under musl
Date: Sun, 29 Oct 2017 20:57:07 +0100	[thread overview]
Message-ID: <20171029205707.4f82a902@windsurf> (raw)
In-Reply-To: <20171027114716.29198-1-peter@korsgaard.com>

Hello,

On Fri, 27 Oct 2017 13:47:16 +0200, Peter Korsgaard wrote:

>  config BR2_PACKAGE_LVM2_STANDARD_INSTALL
>  	bool "standard install instead of only dmsetup"
> +	# http://lists.busybox.net/pipermail/buildroot/2016-August/170592.html
> +	depends on !BR2_TOOLCHAIN_USES_MUSL
>  	default y if !BR2_PACKAGE_LVM2_DMSETUP_ONLY # legacy 2013.11
>  	help
>  	  Install the standard suite of lvm2 programs. When this option
> @@ -34,10 +34,15 @@ config BR2_PACKAGE_LVM2_STANDARD_INSTALL
>  
>  config BR2_PACKAGE_LVM2_APP_LIBRARY
>  	bool "install application library"
> +	# http://lists.busybox.net/pipermail/buildroot/2016-August/170592.html
> +	depends on !BR2_TOOLCHAIN_USES_MUSL
>  	select BR2_PACKAGE_LVM2_STANDARD_INSTALL
>  	help
>  	  Install application library (liblvm2app).
>  
> +comment "lvm2 standard install needs a glibc or uClibc toolchain"
> +	depends on BR2_TOOLCHAIN_USES_MUSL

For consistency, I've moved this comment below the "standard install"
option, and added another comment for the "application library" option.

> +
>  endif
>  
>  comment "lvm2 needs a glibc or uClibc toolchain w/ threads, dynamic library"

You had forgotten to update this comment: lvm2 no longer needs glibc or
uClibc, and you also had forgotten to drop the BR2_TOOLCHAIN_USES_MUSL
part of this comment dependencies.

Applied with those nits fixed. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-10-29 19:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27 11:47 [Buildroot] [PATCH] lvm2: make basic package available under musl Peter Korsgaard
2017-10-29 19:57 ` Thomas Petazzoni [this message]
2017-10-30  8:43   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171029205707.4f82a902@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox