From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] lvm2: make basic package available under musl
Date: Mon, 30 Oct 2017 09:43:23 +0100 [thread overview]
Message-ID: <8760axjaac.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20171029205707.4f82a902@windsurf> (Thomas Petazzoni's message of "Sun, 29 Oct 2017 20:57:07 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Hi,
>> Install application library (liblvm2app).
>>
>> +comment "lvm2 standard install needs a glibc or uClibc toolchain"
>> + depends on BR2_TOOLCHAIN_USES_MUSL
> For consistency, I've moved this comment below the "standard install"
> option, and added another comment for the "application library" option.
Ok. In the general case this would screw up indentation of further sub
option, but as the dependencies are the same this won't happen here.
>> comment "lvm2 needs a glibc or uClibc toolchain w/ threads, dynamic library"
> You had forgotten to update this comment: lvm2 no longer needs glibc or
> uClibc, and you also had forgotten to drop the BR2_TOOLCHAIN_USES_MUSL
> part of this comment dependencies.
Ups, thanks for fixing it!
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2017-10-30 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 11:47 [Buildroot] [PATCH] lvm2: make basic package available under musl Peter Korsgaard
2017-10-29 19:57 ` Thomas Petazzoni
2017-10-30 8:43 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760axjaac.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox