[Buildroot] Analysis of build results for 2017-10-30

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Hello,

On Wed, 1 Nov 2017 10:01:14 +0000, Alexey Brodkin wrote:

> As a matter of fact the same problem happens on ARM if GCC 7 is used.
> That's my defconfig:
> --------------------------->8---------------------  
> BR2_arm=y
> BR2_GCC_VERSION_7_X=y
> --------------------------->8---------------------  

I was surprised because our configuration
https://git.buildroot.org/buildroot/tree/support/config-fragments/autobuild/br-arm-cortex-a9-glibc.config
is using gcc 7.x. But what I missed is that it's a glibc configuration,
and argp-standalone is only available for !glibc configurations.

So that explains it all.

> --------------------------->8---------------------  
> make argp-standalone
> ...
> .../output/build/argp-standalone-1.3/argp-help.c:1217: undefined reference to `argp_fmtstream_set_wmargin'
> .../output/build/argp-standalone-1.3/argp-help.c:1199: undefined reference to `argp_fmtstream_puts'
> collect2: error: ld returned 1 exit status
> --------------------------->8---------------------  
> 
> Speaking about a fix for this problem I guess more elegant could be:
> --------------------------->8---------------------  
> ?argp-fmtstream.h | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/argp-fmtstream.h b/argp-fmtstream.h
> index 2dd0925..cb0bead 100644
> --- a/argp-fmtstream.h
> +++ b/argp-fmtstream.h
> @@ -215,7 +215,7 @@ extern int __argp_fmtstream_ensure (argp_fmtstream_t __fs, size_t __amount);
> ?#if defined(__GNUC__) && !defined(__GNUC_STDC_INLINE__)
> ?#define ARGP_FS_EI extern inline
> ?#else
> -#define ARGP_FS_EI inline
> +#define ARGP_FS_EI inline __attribute__((__always_inline__))
> ?#endif
> ?#endif
> --------------------------->8---------------------  
> 
> If that looks fine to you guys Eugeniy will send out that fix.

The gnu89-inline solution is the one also used by Alpine Linux,
https://git.alpinelinux.org/cgit/aports/tree/main/argp-standalone/gnu89-inline.patch,
so I believe it's good enough.

I'll apply Matt's patch after changing the commit log.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com