[Buildroot] [PATCH 1/1] package/python-networkmanager: Bump to version 2.0.1

[Buildroot] [PATCH 1/1] package/python-networkmanager: Bump to version 2.0.1

[Petr Vorel]

Package config files generated with utils/scanpypi tool, adjusted.
Dropped some dependencies which are handled by packages
python-networkmanager depends on.

+ simplified help text

Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
Hope I didn't do any breakage with droppingg dependencies.
---
 package/python-networkmanager/Config.in                  | 14 ++++----------
 package/python-networkmanager/python-networkmanager.hash |  6 +++---
 package/python-networkmanager/python-networkmanager.mk   |  9 +++++----
 3 files changed, 12 insertions(+), 17 deletions(-)

diff --git a/package/python-networkmanager/Config.in b/package/python-networkmanager/Config.in
index fcbce5748d..5ddf665536 100644
--- a/package/python-networkmanager/Config.in
+++ b/package/python-networkmanager/Config.in
@@ -1,15 +1,9 @@
 config BR2_PACKAGE_PYTHON_NETWORKMANAGER
 	bool "python-networkmanager"
 	depends on BR2_PACKAGE_NETWORK_MANAGER # runtime
-	depends on BR2_USE_WCHAR # dbus-python
-	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus-python
-	depends on BR2_PACKAGE_DBUS # dbus-python
-	select BR2_PACKAGE_DBUS_PYTHON
+	select BR2_PACKAGE_DBUS_PYTHON # runtime
+	select BR2_PACKAGE_PYTHON_SIX # runtime
 	help
-	  python-networkmanager wraps NetworkManagers D-Bus interface
-	  so you can be less verbose when talking to NetworkManager
-	  from python. All interfaces have been wrapped in classes,
-	  properties are exposed as python properties and function
-	  calls are forwarded to the correct interface.
+	  Easy communication with NetworkManager.
 
-	  https://pypi.python.org/pypi/python-networkmanager/
+	  http://github.com/seveas/python-networkmanager
diff --git a/package/python-networkmanager/python-networkmanager.hash b/package/python-networkmanager/python-networkmanager.hash
index cbd6febcd1..1fed4befb7 100644
--- a/package/python-networkmanager/python-networkmanager.hash
+++ b/package/python-networkmanager/python-networkmanager.hash
@@ -1,3 +1,3 @@
-# md5 from https://pypi.python.org/pypi?:action=show_md5&digest=97c84c19b84b1124903a06379b107f77, sha256 locally computed
-md5	97c84c19b84b1124903a06379b107f77  python-networkmanager-1.2.1.tar.gz
-sha256	7107c07383f8077cfac33fdbb3c4cda4de40be20a6b20d30840055eb519a0e89  python-networkmanager-1.2.1.tar.gz
+# md5 from https://pypi.python.org/pypi/python-networkmanager/json, sha256 locally computed
+md5	5fc644a65463031295c6b7dd51a0f1bd  python-networkmanager-2.0.1.tar.gz
+sha256	bc36507506ad29bfdac941b0987ebd1cc9633c9a9291d7378e229e4515a0a517  python-networkmanager-2.0.1.tar.gz
diff --git a/package/python-networkmanager/python-networkmanager.mk b/package/python-networkmanager/python-networkmanager.mk
index d0e4011421..2b3eb6458c 100644
--- a/package/python-networkmanager/python-networkmanager.mk
+++ b/package/python-networkmanager/python-networkmanager.mk
@@ -4,10 +4,11 @@
 #
 ################################################################################
 
-PYTHON_NETWORKMANAGER_VERSION = 1.2.1
-PYTHON_NETWORKMANAGER_SITE = https://pypi.python.org/packages/e7/b1/09993250ceea9e03bc65fbabcd5286540200292c011b22237b2963c11471
-PYTHON_NETWORKMANAGER_SETUP_TYPE = distutils
-PYTHON_NETWORKMANAGER_LICENSE = GPL-3.0+
+PYTHON_NETWORKMANAGER_VERSION = 2.0.1
+PYTHON_NETWORKMANAGER_SOURCE = python-networkmanager-$(PYTHON_NETWORKMANAGER_VERSION).tar.gz
+PYTHON_NETWORKMANAGER_SITE = https://pypi.python.org/packages/d7/f9/5cbd99fd24a072875ce048e48d1754285f137aab447de8fee63b6cba990a
+PYTHON_NETWORKMANAGER_SETUP_TYPE = setuptools
+PYTHON_NETWORKMANAGER_LICENSE = zlib/libpng License
 PYTHON_NETWORKMANAGER_LICENSE_FILES = COPYING
 PYTHON_NETWORKMANAGER_DEPENDENCIES = dbus-python
 
-- 
2.14.2

[Buildroot] [PATCH 1/1] package/python-networkmanager: Bump to version 2.0.1

[Thomas Petazzoni]

Hello,

On Thu,  2 Nov 2017 21:23:28 +0100, Petr Vorel wrote:

>  config BR2_PACKAGE_PYTHON_NETWORKMANAGER
>  	bool "python-networkmanager"
>  	depends on BR2_PACKAGE_NETWORK_MANAGER # runtime
> -	depends on BR2_USE_WCHAR # dbus-python
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus-python
> -	depends on BR2_PACKAGE_DBUS # dbus-python

We want to keep those "depends on", because they match the select of
dbus-python. Yes, perhaps network-manager has the same dependencies
today, but we don't want to rely on that.

> -	select BR2_PACKAGE_DBUS_PYTHON
> +	select BR2_PACKAGE_DBUS_PYTHON # runtime
> +	select BR2_PACKAGE_PYTHON_SIX # runtime

This seems to be a new runtime dependency, it would be worth mentioning
in the commit log.

>  	help
> -	  python-networkmanager wraps NetworkManagers D-Bus interface
> -	  so you can be less verbose when talking to NetworkManager
> -	  from python. All interfaces have been wrapped in classes,
> -	  properties are exposed as python properties and function
> -	  calls are forwarded to the correct interface.
> +	  Easy communication with NetworkManager.

The original help text looks a look better, why drop it?

Did you use scanpypi to generate this new package perhaps?
> -PYTHON_NETWORKMANAGER_VERSION = 1.2.1
> -PYTHON_NETWORKMANAGER_SITE = https://pypi.python.org/packages/e7/b1/09993250ceea9e03bc65fbabcd5286540200292c011b22237b2963c11471
> -PYTHON_NETWORKMANAGER_SETUP_TYPE = distutils
> -PYTHON_NETWORKMANAGER_LICENSE = GPL-3.0+
> +PYTHON_NETWORKMANAGER_VERSION = 2.0.1
> +PYTHON_NETWORKMANAGER_SOURCE = python-networkmanager-$(PYTHON_NETWORKMANAGER_VERSION).tar.gz
> +PYTHON_NETWORKMANAGER_SITE = https://pypi.python.org/packages/d7/f9/5cbd99fd24a072875ce048e48d1754285f137aab447de8fee63b6cba990a
> +PYTHON_NETWORKMANAGER_SETUP_TYPE = setuptools
> +PYTHON_NETWORKMANAGER_LICENSE = zlib/libpng License

To me, the license looks exactly like the Zlib license
(https://zlib.net/zlib_license.html) and not like the libpng license
(http://libpng.org/pub/png/src/libpng-LICENSE.txt). So perhaps:

PYTHON_NETWORKMANAGER_LICENSE = Zlib

would be more accurate here (and would have the advantage of using a
SPDX license code).

Could you look into those different comments and submit an updated
version?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com