[Buildroot] [PATCH 1/2] package: add python-raven

[Buildroot] [PATCH 1/2] package: add python-raven

[Joseph Kogut]

Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
 package/Config.in                      |  1 +
 package/python-raven/Config.in         |  6 ++++++
 package/python-raven/python-raven.hash |  3 +++
 package/python-raven/python-raven.mk   | 14 ++++++++++++++
 4 files changed, 24 insertions(+)
 create mode 100644 package/python-raven/Config.in
 create mode 100644 package/python-raven/python-raven.hash
 create mode 100644 package/python-raven/python-raven.mk

diff --git a/package/Config.in b/package/Config.in
index dbfb288d53..efb69b8f10 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -875,6 +875,7 @@ menu "External python modules"
 	source "package/python-pyxb/Config.in"
 	source "package/python-pyyaml/Config.in"
 	source "package/python-pyzmq/Config.in"
+	source "package/python-raven/Config.in"
 	source "package/python-requests/Config.in"
 	source "package/python-requests-toolbelt/Config.in"
 	source "package/python-rpi-gpio/Config.in"
diff --git a/package/python-raven/Config.in b/package/python-raven/Config.in
new file mode 100644
index 0000000000..1fbd1d8c03
--- /dev/null
+++ b/package/python-raven/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_PYTHON_RAVEN
+	bool "python-raven"
+	help
+	  Raven is a client for Sentry (https://getsentry.com).
+
+	  https://github.com/getsentry/raven-python
diff --git a/package/python-raven/python-raven.hash b/package/python-raven/python-raven.hash
new file mode 100644
index 0000000000..1de6975658
--- /dev/null
+++ b/package/python-raven/python-raven.hash
@@ -0,0 +1,3 @@
+# md5 from https://pypi.python.org/pypi/raven/json, sha256 locally computed
+md5	a08d910e05a228d55cb3388910930d66  raven-6.2.1.tar.gz
+sha256	c0a30bcc3e3206059f79656d80362ce080b1c991c95d867edce559a7294570fe  raven-6.2.1.tar.gz
diff --git a/package/python-raven/python-raven.mk b/package/python-raven/python-raven.mk
new file mode 100644
index 0000000000..cb40839343
--- /dev/null
+++ b/package/python-raven/python-raven.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-raven
+#
+################################################################################
+
+PYTHON_RAVEN_VERSION = 6.2.1
+PYTHON_RAVEN_SOURCE = raven-$(PYTHON_RAVEN_VERSION).tar.gz
+PYTHON_RAVEN_SITE = https://pypi.python.org/packages/c1/97/38e74c7521737c965281b43440b274955e211b1d5319c256d8525d9d2cad
+PYTHON_RAVEN_SETUP_TYPE = setuptools
+PYTHON_RAVEN_LICENSE = BSD-3-Clause
+PYTHON_RAVEN_LICENSE_FILES = LICENSE
+
+$(eval $(python-package))
-- 
2.15.0

[Buildroot] [PATCH 2/2] DEVELOPERS: add myself as maintainer for python-raven

[Joseph Kogut]

Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
 DEVELOPERS | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/DEVELOPERS b/DEVELOPERS
index 632d87a829..e3f74b3bf0 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -779,6 +779,9 @@ F:	package/pdbg/
 F:	board/qemu/ppc64le-pseries/
 F:	configs/qemu_ppc64le_pseries_defconfig
 
+N:	Joseph Kogut <joseph.kogut@gmail.com>
+F:	package/python-raven/
+
 N:	Johan Derycke <johanderycke@gmail.com>
 F:	package/python-libconfig/
 
-- 
2.15.0

[Buildroot] [PATCH 1/2] package: add python-raven

[Thomas Petazzoni]

Hello,

Thanks for this new contribution! Looks pretty good, just a few minor
nits or questions.

First, the title of the commit should be:

	python-raven: new package

(We like to have consistent naming for commit titles, as it allows to
more easily grep through the Git history).

On Thu,  2 Nov 2017 09:34:18 -0700, Joseph Kogut wrote:
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> ---
>  package/Config.in                      |  1 +
>  package/python-raven/Config.in         |  6 ++++++
>  package/python-raven/python-raven.hash |  3 +++
>  package/python-raven/python-raven.mk   | 14 ++++++++++++++
>  4 files changed, 24 insertions(+)

Please include the change to the DEVELOPERS file in the same patch, no
need to make it a separate patch.

> diff --git a/package/python-raven/Config.in b/package/python-raven/Config.in
> new file mode 100644
> index 0000000000..1fbd1d8c03
> --- /dev/null
> +++ b/package/python-raven/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_PYTHON_RAVEN
> +	bool "python-raven"

It really doesn't have *any* runtime dependency on other Python
modules? I.e if you build just python-raven and the minimal python
interpreter, it works?

I.e, if you build:

BR2_PACKAGE_PYTHON=y
BR2_PACKAGE_PYTHON_RAVEN=y

does it build and run on the target?

> +PYTHON_RAVEN_VERSION = 6.2.1

There is a 6.3.0 version available, any reason not to use this one ?

> +PYTHON_RAVEN_SOURCE = raven-$(PYTHON_RAVEN_VERSION).tar.gz
> +PYTHON_RAVEN_SITE = https://pypi.python.org/packages/c1/97/38e74c7521737c965281b43440b274955e211b1d5319c256d8525d9d2cad
> +PYTHON_RAVEN_SETUP_TYPE = setuptools
> +PYTHON_RAVEN_LICENSE = BSD-3-Clause
> +PYTHON_RAVEN_LICENSE_FILES = LICENSE

Other than that looks good. Could you respin an updated version that
takes into account those comments?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 1/2] package: add python-raven

[Joseph Kogut]

Thomas,

Thanks for the feedback,

> Please include the change to the DEVELOPERS file in the same patch, no
need to make it a separate patch.

The manual states at the end of section 21.5.1:

> If you are interested in getting notified of build failures and of further
> changes in the packages you added or modified, please add yourself to the
> DEVELOPERS file. This should be done in a separate patch of the series.

Did I misunderstand this section, or should the documentation be updated?

> It really doesn't have *any* runtime dependency on other Python
modules? I.e if you build just python-raven and the minimal python
interpreter, it works?

Now that you mention it, it doesn't have any external requirements,
but I'm unsure as to whether or not it requires any optional core
modules. I would assume that it needs urllib at least. I'll test it
and find out.

> Could you respin an updated version that
takes into account those comments?

Absolutely, thanks for taking the time to review this.

[Buildroot] [PATCH 1/2] package: add python-raven

[Thomas Petazzoni]

Hello,

On Fri, 3 Nov 2017 12:08:43 -0700, Joseph Kogut wrote:

> > If you are interested in getting notified of build failures and of further
> > changes in the packages you added or modified, please add yourself to the
> > DEVELOPERS file. This should be done in a separate patch of the series.  
> 
> Did I misunderstand this section, or should the documentation be updated?

The documentation should be updated. Back when we initially introduced
the DEVELOPERS file, we indeed thought that having a separate patch for
the DEVELOPERS file change was best, but we then changed our mind. I
thought we had updated our documentation, but apparently not. Do you
think you could send a patch fixing this?

> > It really doesn't have *any* runtime dependency on other Python  
> modules? I.e if you build just python-raven and the minimal python
> interpreter, it works?
> 
> Now that you mention it, it doesn't have any external requirements,
> but I'm unsure as to whether or not it requires any optional core
> modules. I would assume that it needs urllib at least. I'll test it
> and find out.

Enable just BR2_PACKAGE_PYTHON=y and BR2_PACKAGE_PYTHON_RAVEN=y, build
this, boot, and check that python-raven works correctly on the target.
That's the only way to be sure :)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com