From: Florian Fainelli <f.fainelli@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ethtool: Allow enabling/disabling pretty printing
Date: Sun, 5 Nov 2017 17:29:06 -0800 [thread overview]
Message-ID: <20171106012906.22000-1-f.fainelli@gmail.com> (raw)
Ethtool has a configure script option allowing the enabling or disabling of
pretty printing for drivers, SFP modules etc which can save a significant
amount of bytes on the root filesystem. Allow selecting that, and turn it on by
default (like ethtool's configure script).
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
package/ethtool/Config.in | 10 ++++++++++
package/ethtool/ethtool.mk | 2 ++
2 files changed, 12 insertions(+)
diff --git a/package/ethtool/Config.in b/package/ethtool/Config.in
index 09704979e864..77795a838971 100644
--- a/package/ethtool/Config.in
+++ b/package/ethtool/Config.in
@@ -5,3 +5,13 @@ config BR2_PACKAGE_ETHTOOL
ethernet-based network interface.
https://www.kernel.org/pub/software/network/ethtool/
+
+if BR2_PACKAGE_ETHTOOL
+
+ config BR2_PACKAGE_ETHTOOL_PRETTY_PRINT
+ bool "enable pretty printing"
+ default y
+ help
+ Enables ethtool's pretty printing for drivers
+ and SFP modules.
+endif
diff --git a/package/ethtool/ethtool.mk b/package/ethtool/ethtool.mk
index 991df499a8fd..d8ebba5fae05 100644
--- a/package/ethtool/ethtool.mk
+++ b/package/ethtool/ethtool.mk
@@ -9,5 +9,7 @@ ETHTOOL_SOURCE = ethtool-$(ETHTOOL_VERSION).tar.xz
ETHTOOL_SITE = $(BR2_KERNEL_MIRROR)/software/network/ethtool
ETHTOOL_LICENSE = GPL-2.0
ETHTOOL_LICENSE_FILES = COPYING
+ETHTOOL_CONF_OPTS = \
+ $(if $(BR2_PACKAGE_ETHTOOL_PRETTY_PRINT),--enable-pretty-dump,--disable-pretty-dump)
$(eval $(autotools-package))
--
2.14.1
next reply other threads:[~2017-11-06 1:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 1:29 Florian Fainelli [this message]
2017-11-06 5:30 ` [Buildroot] [PATCH] ethtool: Allow enabling/disabling pretty printing Baruch Siach
2017-11-06 5:36 ` Florian Fainelli
2017-11-06 8:52 ` Peter Korsgaard
2017-11-06 9:05 ` Thomas Petazzoni
2017-11-06 9:07 ` Baruch Siach
2017-11-06 9:19 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106012906.22000-1-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox