From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ethtool: Allow enabling/disabling pretty printing
Date: Mon, 06 Nov 2017 09:52:37 +0100 [thread overview]
Message-ID: <87zi7zyeju.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20171106012906.22000-1-f.fainelli@gmail.com> (Florian Fainelli's message of "Sun, 5 Nov 2017 17:29:06 -0800")
>>>>> "Florian" == Florian Fainelli <f.fainelli@gmail.com> writes:
> Ethtool has a configure script option allowing the enabling or disabling of
> pretty printing for drivers, SFP modules etc which can save a significant
> amount of bytes on the root filesystem. Allow selecting that, and turn it on by
> default (like ethtool's configure script).
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> package/ethtool/Config.in | 10 ++++++++++
> package/ethtool/ethtool.mk | 2 ++
> 2 files changed, 12 insertions(+)
> diff --git a/package/ethtool/Config.in b/package/ethtool/Config.in
> index 09704979e864..77795a838971 100644
> --- a/package/ethtool/Config.in
> +++ b/package/ethtool/Config.in
> @@ -5,3 +5,13 @@ config BR2_PACKAGE_ETHTOOL
> ethernet-based network interface.
> https://www.kernel.org/pub/software/network/ethtool/
> +
> +if BR2_PACKAGE_ETHTOOL
> +
> + config BR2_PACKAGE_ETHTOOL_PRETTY_PRINT
> + bool "enable pretty printing"
> + default y
> + help
> + Enables ethtool's pretty printing for drivers
> + and SFP modules.
> +endif
We don't indent sub options in Config.in, and normally don't do the if
BR2_PACKAGE_FOO ... endif unless there are several sub options - so I've
fixed that and committed, thanks.
Consider running utils/check-package on your patches before sending as
it would have complained about this.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2017-11-06 8:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 1:29 [Buildroot] [PATCH] ethtool: Allow enabling/disabling pretty printing Florian Fainelli
2017-11-06 5:30 ` Baruch Siach
2017-11-06 5:36 ` Florian Fainelli
2017-11-06 8:52 ` Peter Korsgaard [this message]
2017-11-06 9:05 ` Thomas Petazzoni
2017-11-06 9:07 ` Baruch Siach
2017-11-06 9:19 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi7zyeju.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox