[Buildroot] [git commit] luajit: only available on x86(-64) hosts

[Buildroot] [git commit] luajit: only available on x86(-64) hosts

[Arnout Vandecappelle]

commit: https://git.buildroot.net/buildroot/commit/?id=9b9347ee9f8e531dd177b437e8ea5387e29fc35e
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

The -m32 compiler flag is used for 32bit builds and host-luajit has
limited architecture support. Building for a 32-bit target on a 32-bit
host should always work, but we haven't tested that and it's very
unlikely that someone needs it. So just limit to x86(-64) hosts.

Fixes:
http://autobuild.buildroot.net/results/5f5b5edb058efe976c003678e21bcc28a87cc828/

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
[Arnout: clarify that it might work on 32-bit hosts for a 32-bit target]
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/luajit/Config.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/luajit/Config.in b/package/luajit/Config.in
index 1a27c43..6b9c6e6 100644
--- a/package/luajit/Config.in
+++ b/package/luajit/Config.in
@@ -1,5 +1,8 @@
 config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
 	bool
+	# -m32 flag is used for 32bit builds and host-luajit has
+	# limited architecture support
+	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	default y if BR2_i386 || \
 		(BR2_x86_64 && BR2_HOSTARCH='x86_64') || \
 		BR2_powerpc || BR2_arm || BR2_armeb || \

[Buildroot] [git commit] luajit: only available on x86(-64) hosts

[Thomas Petazzoni]

Hello,

On Sun, 5 Nov 2017 16:51:59 +0100, Arnout Vandecappelle
(Essensium/Mind) wrote:

> diff --git a/package/luajit/Config.in b/package/luajit/Config.in
> index 1a27c43..6b9c6e6 100644
> --- a/package/luajit/Config.in
> +++ b/package/luajit/Config.in
> @@ -1,5 +1,8 @@
>  config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
>  	bool
> +	# -m32 flag is used for 32bit builds and host-luajit has
> +	# limited architecture support
> +	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>  	default y if BR2_i386 || \
>  		(BR2_x86_64 && BR2_HOSTARCH='x86_64') || \
>  		BR2_powerpc || BR2_arm || BR2_armeb || \

I said it during the review, and apparently my comment was not taken
into account: I'm not entirely happy with this change, because it's
really host-luajit that has an architecture dependency, and not luajit.
So all packages that use host-luajit (without needing luajit) should
also have this dependency. I know the only package in this situation
today was moarvm, and it was fixed, but only because I pointed out this
problem, which will pop up again in the future if we keep this
implementation.

Perhaps we should have package/luajit/Config.in.host with just a blind
BR2_PACKAGE_HOST_LUAJIT_ARCH_SUPPORTS, and make
BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS depend on it. Yes, I'm being pedantic
here, but the fact that moarvm was initially overlooked is a good
indication that a clearer dependency would be useful.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [git commit] luajit: only available on x86(-64) hosts

[François Perrad]

moarvm could be build without any host lua (Lua or LuaJIT),
it embeds its own minilua for bootstrapping.
see https://patchwork.ozlabs.org/patch/601314/

Fran?ois

2017-11-06 10:12 GMT+01:00 Thomas Petazzoni <
thomas.petazzoni@free-electrons.com>:

> Hello,
>
> On Sun, 5 Nov 2017 16:51:59 +0100, Arnout Vandecappelle
> (Essensium/Mind) wrote:
>
> > diff --git a/package/luajit/Config.in b/package/luajit/Config.in
> > index 1a27c43..6b9c6e6 100644
> > --- a/package/luajit/Config.in
> > +++ b/package/luajit/Config.in
> > @@ -1,5 +1,8 @@
> >  config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
> >       bool
> > +     # -m32 flag is used for 32bit builds and host-luajit has
> > +     # limited architecture support
> > +     depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
> >       default y if BR2_i386 || \
> >               (BR2_x86_64 && BR2_HOSTARCH='x86_64') || \
> >               BR2_powerpc || BR2_arm || BR2_armeb || \
>
> I said it during the review, and apparently my comment was not taken
> into account: I'm not entirely happy with this change, because it's
> really host-luajit that has an architecture dependency, and not luajit.
> So all packages that use host-luajit (without needing luajit) should
> also have this dependency. I know the only package in this situation
> today was moarvm, and it was fixed, but only because I pointed out this
> problem, which will pop up again in the future if we keep this
> implementation.
>
> Perhaps we should have package/luajit/Config.in.host with just a blind
> BR2_PACKAGE_HOST_LUAJIT_ARCH_SUPPORTS, and make
> BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS depend on it. Yes, I'm being pedantic
> here, but the fact that moarvm was initially overlooked is a good
> indication that a clearer dependency would be useful.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20171106/a594cb97/attachment.html>

[Buildroot] [git commit] luajit: only available on x86(-64) hosts

[Peter Korsgaard]

>>>>> "Fran?ois" == Fran?ois Perrad <fperrad@gmail.com> writes:

 > moarvm could be build without any host lua (Lua or LuaJIT),
 > it embeds its own minilua for bootstrapping.
 > see https://patchwork.ozlabs.org/patch/601314/

Correct, and since 2017.10 you even cannot use an external lua:

https://github.com/MoarVM/MoarVM/blob/master/docs/ChangeLog


-- 
Bye, Peter Korsgaard

[Buildroot] [git commit] luajit: only available on x86(-64) hosts

[Arnout Vandecappelle]

On 06-11-17 10:12, Thomas Petazzoni wrote:
> Hello,
> 
> On Sun, 5 Nov 2017 16:51:59 +0100, Arnout Vandecappelle
> (Essensium/Mind) wrote:
> 
>> diff --git a/package/luajit/Config.in b/package/luajit/Config.in
>> index 1a27c43..6b9c6e6 100644
>> --- a/package/luajit/Config.in
>> +++ b/package/luajit/Config.in
>> @@ -1,5 +1,8 @@
>>  config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
>>  	bool
>> +	# -m32 flag is used for 32bit builds and host-luajit has
>> +	# limited architecture support
>> +	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>>  	default y if BR2_i386 || \
>>  		(BR2_x86_64 && BR2_HOSTARCH='x86_64') || \
>>  		BR2_powerpc || BR2_arm || BR2_armeb || \
> 
> I said it during the review, and apparently my comment was not taken
> into account:

 Yes, sorry about that. I had read it too quickly and interpreted it as just
saying that moarvm had to be fixed as well.

> I'm not entirely happy with this change, because it's
> really host-luajit that has an architecture dependency, and not luajit.
> So all packages that use host-luajit (without needing luajit) should
> also have this dependency. I know the only package in this situation
> today was moarvm, and it was fixed, but only because I pointed out this
> problem, which will pop up again in the future if we keep this
> implementation.
> 
> Perhaps we should have package/luajit/Config.in.host with just a blind
> BR2_PACKAGE_HOST_LUAJIT_ARCH_SUPPORTS, and make
> BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS depend on it. 

 Sounds like a great idea, go for it!

 Regards,
 Arnout

> Yes, I'm being pedantic
> here, but the fact that moarvm was initially overlooked is a good
> indication that a clearer dependency would be useful.
> 
> Thomas
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF