Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Duskett <aduskett@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [NEXT v2 4/7] libpjsip: enable ffmpeg support
Date: Tue, 14 Nov 2017 11:07:09 -0500	[thread overview]
Message-ID: <20171114160712.20086-4-aduskett@gmail.com> (raw)
In-Reply-To: <20171114160712.20086-1-aduskett@gmail.com>

If FFmpeg is selected, libpjsip should depend on it.
Specifying --with-ffmpeg= is necessary because passing --enable-FFmpeg
actually disables FFmpeg when cross compiling.

Signed-off-by: Adam Duskett <aduskett@gmail.com>
---
Changes v1 -> v2:
  - Remove the option to enable or disable FFmpeg support in favor of
    just depending on FFmpeg if it's selected by the user.
  - Add explination as to why with-ffmpeg is being passed to libpjsip (Arnout)

 package/libpjsip/libpjsip.mk | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/package/libpjsip/libpjsip.mk b/package/libpjsip/libpjsip.mk
index 3c9d789..982e088 100644
--- a/package/libpjsip/libpjsip.mk
+++ b/package/libpjsip/libpjsip.mk
@@ -29,7 +29,6 @@ LIBPJSIP_CONF_OPTS = \
 	--disable-speex-codec \
 	--disable-speex-aec \
 	--disable-resample \
-	--disable-video \
 	--disable-opencore-amr \
 	--disable-g7221-codec \
 	--disable-ilbc-codec \
@@ -41,7 +40,6 @@ LIBPJSIP_CONF_OPTS = \
 	--disable-g722-codec \
 	--disable-libsamplerate \
 	--disable-sdl \
-	--disable-ffmpeg \
 	--disable-v4l2 \
 	--disable-openh264 \
 	--disable-libyuv \
@@ -75,4 +73,13 @@ LIBPJSIP_DEPENDENCIES += portaudio
 LIBPJSIP_CONF_OPTS += --with-external-pa
 endif
 
+# Passing --enable-ffmpeg actually disables it. Instead, --with-ffmpeg
+# must be passed to compile ffmpeg support.
+ifeq ($(BR2_PACKAGE_FFMPEG),y)
+LIBPJSIP_DEPENDENCIES += ffmpeg
+LIBPJSIP_CONF_OPTS += --with-ffmpeg=$(STAGING_DIR)/usr
+else
+LIBPJSIP_CONF_OPTS += --disable-ffmpeg
+endif
+
 $(eval $(autotools-package))
-- 
2.13.6

  parent reply	other threads:[~2017-11-14 16:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14 16:07 [Buildroot] [NEXT v2 1/7] libpjsip: remove disable-ext-sound option Adam Duskett
2017-11-14 16:07 ` [Buildroot] [NEXT v2 2/7] libpjsip: enable alsa support Adam Duskett
2017-11-14 17:00   ` Thomas Petazzoni
2017-11-14 16:07 ` [Buildroot] [NEXT v2 3/7] libpjsip: enable portaudio support Adam Duskett
2017-11-14 16:07 ` Adam Duskett [this message]
2017-11-19 13:58   ` [Buildroot] [NEXT v2 4/7] libpjsip: enable ffmpeg support Arnout Vandecappelle
2017-11-14 16:07 ` [Buildroot] [NEXT v2 5/7] libpjsip: enable v4l2 support Adam Duskett
2017-11-14 16:07 ` [Buildroot] [NEXT v2 6/7] libpjsip: add dependency-less codecs Adam Duskett
2017-11-14 16:07 ` [Buildroot] [NEXT v2 7/7] libpjsip: add codecs with dependencies Adam Duskett
2017-11-18 17:08 ` [Buildroot] [NEXT v2 1/7] libpjsip: remove disable-ext-sound option Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171114160712.20086-4-aduskett@gmail.com \
    --to=aduskett@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox