From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [NEXT v2 2/7] libpjsip: enable alsa support
Date: Tue, 14 Nov 2017 18:00:48 +0100 [thread overview]
Message-ID: <20171114180048.7933434f@windsurf.lan> (raw)
In-Reply-To: <20171114160712.20086-2-aduskett@gmail.com>
Hello,
On Tue, 14 Nov 2017 11:07:07 -0500, Adam Duskett wrote:
> If alsa-lib is selected, libpjsip should depend on it.
> Also, remove --disable-sound in the configure options or else sound would
> still be disabled.
>
> Signed-off-by: Adam Duskett <aduskett@gmail.com>
> ---
> Changes v1 -> v2:
> - Remove the option to enable or disable alsa support in favor of
> just depending on alsa-lib if it's selected by the user.
Why? This seems completely backward with the typical Buildroot
practices.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-11-14 17:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 16:07 [Buildroot] [NEXT v2 1/7] libpjsip: remove disable-ext-sound option Adam Duskett
2017-11-14 16:07 ` [Buildroot] [NEXT v2 2/7] libpjsip: enable alsa support Adam Duskett
2017-11-14 17:00 ` Thomas Petazzoni [this message]
2017-11-14 16:07 ` [Buildroot] [NEXT v2 3/7] libpjsip: enable portaudio support Adam Duskett
2017-11-14 16:07 ` [Buildroot] [NEXT v2 4/7] libpjsip: enable ffmpeg support Adam Duskett
2017-11-19 13:58 ` Arnout Vandecappelle
2017-11-14 16:07 ` [Buildroot] [NEXT v2 5/7] libpjsip: enable v4l2 support Adam Duskett
2017-11-14 16:07 ` [Buildroot] [NEXT v2 6/7] libpjsip: add dependency-less codecs Adam Duskett
2017-11-14 16:07 ` [Buildroot] [NEXT v2 7/7] libpjsip: add codecs with dependencies Adam Duskett
2017-11-18 17:08 ` [Buildroot] [NEXT v2 1/7] libpjsip: remove disable-ext-sound option Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114180048.7933434f@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox