From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libupnp: add 1.8.3 version
Date: Wed, 15 Nov 2017 13:43:42 +0100 [thread overview]
Message-ID: <20171115134342.60226366@windsurf.lan> (raw)
In-Reply-To: <20171114193821.25188-1-fontaine.fabrice@gmail.com>
Hello,
On Tue, 14 Nov 2017 20:38:21 +0100, Fabrice Fontaine wrote:
> diff --git a/package/libupnp/Config.in b/package/libupnp/Config.in
> index 7c6c37607..0a8e98c97 100644
> --- a/package/libupnp/Config.in
> +++ b/package/libupnp/Config.in
> @@ -10,5 +10,19 @@ config BR2_PACKAGE_LIBUPNP
>
> http://pupnp.sourceforge.net/
>
> +choice
> + prompt "libupnp version"
> + default BR2_PACKAGE_LIBUPNP_1_6
> + help
> + Select the version of libupnp API you wish to use.
> +
> +config BR2_PACKAGE_LIBUPNP_1_6
> + bool "libupnp 1.6.x"
> +
> +config BR2_PACKAGE_LIBUPNP_1_8
> + bool "libupnp 1.8.x"
> +
> +endchoice
I believe we should perhaps instead add a separate libupnp18 package,
all those "depends on" to decide which package should be visible
depending on the version of libupnp that is currently selected are a
bit annoying. But don't rewrite your patch right now: wait for other
Buildroot developers to give their opinion on this matter.
Is it possible to install both libupnp 1.6 and libupnp 1.8 in the same
system without any conflict ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-11-15 12:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 19:38 [Buildroot] [PATCH 1/1] libupnp: add 1.8.3 version Fabrice Fontaine
2017-11-15 12:43 ` Thomas Petazzoni [this message]
2017-11-15 21:04 ` Fabrice Fontaine
2017-11-15 21:22 ` Thomas Petazzoni
2017-11-15 21:32 ` Arnout Vandecappelle
2017-11-15 22:08 ` Fabrice Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115134342.60226366@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox