From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libupnp: add 1.8.3 version
Date: Wed, 15 Nov 2017 22:22:57 +0100 [thread overview]
Message-ID: <20171115222257.10defebb@windsurf.lan> (raw)
In-Reply-To: <CAPi7W81AhUJjdFm5F-7MJmKQ3XVO8FtHFU5NoR+hGrWvBSSSuw@mail.gmail.com>
Hello,
On Wed, 15 Nov 2017 22:04:10 +0100, Fabrice Fontaine wrote:
> > > +choice
> > > + prompt "libupnp version"
> > > + default BR2_PACKAGE_LIBUPNP_1_6
> > > + help
> > > + Select the version of libupnp API you wish to use.
> > > +
> > > +config BR2_PACKAGE_LIBUPNP_1_6
> > > + bool "libupnp 1.6.x"
> > > +
> > > +config BR2_PACKAGE_LIBUPNP_1_8
> > > + bool "libupnp 1.8.x"
> > > +
> > > +endchoice
> >
> > I believe we should perhaps instead add a separate libupnp18 package,
> > all those "depends on" to decide which package should be visible
> > depending on the version of libupnp that is currently selected are a
> > bit annoying. But don't rewrite your patch right now: wait for other
> > Buildroot developers to give their opinion on this matter.
> >
> > Is it possible to install both libupnp 1.6 and libupnp 1.8 in the same
> > system without any conflict ?
> >
> Unfortunately no, it was possible in 1.8.0 and 1.8.1 but we had to rollback
> due to the vlc developer who wasn't happy with this change:
> https://github.com/mrjimenez/pupnp/commit/07f504c61bd9e4d93eb3d373ffc852
> 7cafe0b9af
OK, the reasoning makes sense.
What is the transition plan ? Will the different Buildroot packages that
use the 1.6 version be upgraded to use 1.8 at some point in the
reasonably near future ? Or will we have to keep both versions forever ?
Peter, Arnout, what are your thoughts on how to handle this?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-11-15 21:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 19:38 [Buildroot] [PATCH 1/1] libupnp: add 1.8.3 version Fabrice Fontaine
2017-11-15 12:43 ` Thomas Petazzoni
2017-11-15 21:04 ` Fabrice Fontaine
2017-11-15 21:22 ` Thomas Petazzoni [this message]
2017-11-15 21:32 ` Arnout Vandecappelle
2017-11-15 22:08 ` Fabrice Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115222257.10defebb@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox