* [Buildroot] [PATCH 1/1] linphone: add libupnp dependency
@ 2017-11-26 21:26 Fabrice Fontaine
2017-11-27 8:31 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Fontaine @ 2017-11-26 21:26 UTC (permalink / raw)
To: buildroot
linphone is compatible with libupnp but not with libupnp18 so disable
upnp if libupnp is not enabled
Fixes:
- http://autobuild.buildroot.net/results/473c686f9bc5335d25b720cf1b0c45389138a7b4
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/linphone/linphone.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/linphone/linphone.mk b/package/linphone/linphone.mk
index fb5e18db6..a10d6bb20 100644
--- a/package/linphone/linphone.mk
+++ b/package/linphone/linphone.mk
@@ -50,4 +50,11 @@ else
LINPHONE_CONF_OPTS += --disable-libv4l1 --disable-libv4l2
endif
+ifeq ($(BR2_PACKAGE_LIBUPNP),y)
+LINPHONE_DEPENDENCIES += libupnp
+LINPHONE_CONF_OPTS += --enable-upnp
+else
+LINPHONE_CONF_OPTS += --disable-upnp
+endif
+
$(eval $(autotools-package))
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] linphone: add libupnp dependency
2017-11-26 21:26 [Buildroot] [PATCH 1/1] linphone: add libupnp dependency Fabrice Fontaine
@ 2017-11-27 8:31 ` Thomas Petazzoni
2017-12-20 20:45 ` Peter Korsgaard
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2017-11-27 8:31 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 26 Nov 2017 22:26:40 +0100, Fabrice Fontaine wrote:
> linphone is compatible with libupnp but not with libupnp18 so disable
> upnp if libupnp is not enabled
>
> Fixes:
> - http://autobuild.buildroot.net/results/473c686f9bc5335d25b720cf1b0c45389138a7b4
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/linphone/linphone.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
Even though it fixes a build failure that happens only in next, I've
pushed this patch to the master branch, because we generally consider
adding such optional dependencies patches to be bug fixes.
So: applied to master with a reworked commit log. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] linphone: add libupnp dependency
2017-11-27 8:31 ` Thomas Petazzoni
@ 2017-12-20 20:45 ` Peter Korsgaard
0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2017-12-20 20:45 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> Hello,
> On Sun, 26 Nov 2017 22:26:40 +0100, Fabrice Fontaine wrote:
>> linphone is compatible with libupnp but not with libupnp18 so disable
>> upnp if libupnp is not enabled
>>
>> Fixes:
>> - http://autobuild.buildroot.net/results/473c686f9bc5335d25b720cf1b0c45389138a7b4
>>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>> ---
>> package/linphone/linphone.mk | 7 +++++++
>> 1 file changed, 7 insertions(+)
> Even though it fixes a build failure that happens only in next, I've
> pushed this patch to the master branch, because we generally consider
> adding such optional dependencies patches to be bug fixes.
> So: applied to master with a reworked commit log. Thanks!
Committed to 2017.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-20 20:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-26 21:26 [Buildroot] [PATCH 1/1] linphone: add libupnp dependency Fabrice Fontaine
2017-11-27 8:31 ` Thomas Petazzoni
2017-12-20 20:45 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox