Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH][NEXT] gst1-imx: add missing dependency for imxv4l2videosink plugin
Date: Thu, 30 Nov 2017 13:41:54 +0100	[thread overview]
Message-ID: <20171130134154.75c9d523@windsurf.home> (raw)
In-Reply-To: <20171130111122.7774-1-gary.bisson@boundarydevices.com>

Hello,

On Thu, 30 Nov 2017 12:11:22 +0100, Gary Bisson wrote:
> The plugin source code uses V4L2_COLORSPACE_DEFAULT macro which was
> defined in kernel 4.2, so make sure the toolchain headers match this
> requirement.
> 
> Fixes:
> http://autobuild.buildroot.net/results/48dd782161fa5e8860b5ea00a5d60207cb623108/
> http://autobuild.buildroot.net/results/f970c782b5bfbcf66ff3ba200b060d3653ff2630/
> 
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> ---
>  package/gstreamer1/gst1-imx/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/gstreamer1/gst1-imx/Config.in b/package/gstreamer1/gst1-imx/Config.in
> index 9b977bdde8..cedd917019 100644
> --- a/package/gstreamer1/gst1-imx/Config.in
> +++ b/package/gstreamer1/gst1-imx/Config.in
> @@ -87,6 +87,7 @@ config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC
>  config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSINK
>  	bool "imxv4l2videosink"
>  	select BR2_PACKAGE_GST1_PLUGINS_BAD
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2

Thanks! However you need to add the corresponding Config.in comment.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-11-30 12:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30 11:11 [Buildroot] [PATCH][NEXT] gst1-imx: add missing dependency for imxv4l2videosink plugin Gary Bisson
2017-11-30 12:41 ` Thomas Petazzoni [this message]
2017-11-30 13:47   ` Gary Bisson
2017-11-30 13:57     ` Thomas Petazzoni
2017-11-30 14:05       ` Gary Bisson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171130134154.75c9d523@windsurf.home \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox