Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH][NEXT] gst1-imx: add missing dependency for imxv4l2videosink plugin
Date: Thu, 30 Nov 2017 14:57:38 +0100	[thread overview]
Message-ID: <20171130145738.52f660a9@windsurf.lan> (raw)
In-Reply-To: <20171130134705.hh3vk4vfgvidl7l2@t450s.lan>

Hello,

On Thu, 30 Nov 2017 14:47:05 +0100, Gary Bisson wrote:

> > Thanks! However you need to add the corresponding Config.in comment.  
> 
> Is a simple mention of the macro sufficient?
> 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2 # V4L2_COLORSPACE_DEFAULT
> 
> Or would rather have a full sentence above the 'depends'?

I'm talking about a Config.in comment, i.e

comment "feature foobaz needs kernel headers >= 4.2"
	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-11-30 13:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30 11:11 [Buildroot] [PATCH][NEXT] gst1-imx: add missing dependency for imxv4l2videosink plugin Gary Bisson
2017-11-30 12:41 ` Thomas Petazzoni
2017-11-30 13:47   ` Gary Bisson
2017-11-30 13:57     ` Thomas Petazzoni [this message]
2017-11-30 14:05       ` Gary Bisson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171130145738.52f660a9@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox