Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 8/8] gitlab-ci: run check-package
Date: Fri, 1 Dec 2017 16:23:44 +0100	[thread overview]
Message-ID: <20171201152344.GB2885@scaer> (raw)
In-Reply-To: <20171201105453.2d415b5a@windsurf.lan>

Thomas, All,

On 2017-12-01 10:54 +0100, Thomas Petazzoni spake thusly:
> On Thu, 30 Nov 2017 16:34:58 +0100, Yann E. MORIN wrote:
> > On 2017-11-30 08:59 +0100, Thomas Petazzoni spake thusly:
> > > On Thu, 30 Nov 2017 00:08:45 +0100, Yann E. MORIN wrote:  
> > > > +check-package:
> > > > +    script:
> > > > +        - find . -type f -name '*.mk' -exec ./utils/check-package {} +  
> > > 
> > > Does it run without warning on all .mk files?  
[--SNIP--]
> > So I would at least limit it to Config.in, .mk, .hash, .patch files.
> > And even that generates 305+566+230 = 1101 warnings.
> 
> That's indeed a lot. In addition, I want the thing to "fail" if there
> are some warnings, otherwise Gitlab CI will not report the job as
> failed.

Agreed.

> So, let's do this:
> 
>  1. Fix check-package to avoid the false warning on asterisk

Waiting for Ricardo's change to trickle in. Ricardo, can you send an
official patch, please?

>  2. Add the Gitlab CI job testing only .mk files, but making sure that
>     if there is a single warning, it returns with a non-zero error code
>     so that the job is considered as failed if we have a warning

Then this series is ready as it is, minus the comment in asterisk.mk.

>  3. Over time, fix warnings in Config.in and .hash files, until the
>     point where we can enable checking them in Gitlab CI as well.

Agreed.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2017-12-01 15:23 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29 23:08 [Buildroot] [PATCH 0/8] Fix warnings reported by check-package Yann E. MORIN
2017-11-29 23:08 ` [Buildroot] [PATCH 1/8] package/lttng-tools: fix typo in variable name Yann E. MORIN
2017-11-30  7:58   ` Thomas Petazzoni
2017-11-29 23:08 ` [Buildroot] [PATCH 2/8] package/checkpolicy: rename variable Yann E. MORIN
2017-12-01 21:55   ` Thomas Petazzoni
2017-11-29 23:08 ` [Buildroot] [PATCH 3/8] package/am335x-pru-package: " Yann E. MORIN
2017-12-01 21:56   ` Thomas Petazzoni
2017-11-29 23:08 ` [Buildroot] [PATCH 4/8] package/lockfile-progs: " Yann E. MORIN
2017-12-01 21:56   ` Thomas Petazzoni
2017-11-29 23:08 ` [Buildroot] [PATCH 5/8] packages: remove "consecutive empty lines" Yann E. MORIN
2017-12-01 21:56   ` Thomas Petazzoni
2017-11-29 23:08 ` [Buildroot] [PATCH 6/8] packages: fix trailing spaces and slash Yann E. MORIN
2017-12-01 21:57   ` Thomas Petazzoni
2017-11-29 23:08 ` [Buildroot] [PATCH 7/8] package/asterisk: add comment about a check-package false positive Yann E. MORIN
2017-11-30  8:00   ` Thomas Petazzoni
2017-11-30 11:19     ` Ricardo Martincoski
2017-11-30 12:57       ` Thomas Petazzoni
2017-12-01 22:00   ` Thomas Petazzoni
2017-12-02  4:28   ` [Buildroot] [PATCH 1/1] check-package: avoid false warning of useless flag Ricardo Martincoski
2017-12-02 11:03     ` Yann E. MORIN
2017-12-02 13:10       ` Thomas Petazzoni
2017-12-02 13:54         ` Yann E. MORIN
2017-12-02 14:08           ` Thomas Petazzoni
2017-12-03 17:48             ` Arnout Vandecappelle
2017-12-02 13:52     ` Thomas Petazzoni
2017-11-29 23:08 ` [Buildroot] [PATCH 8/8] gitlab-ci: run check-package Yann E. MORIN
2017-11-30  7:59   ` Thomas Petazzoni
2017-11-30 15:34     ` Yann E. MORIN
2017-12-01  9:54       ` Thomas Petazzoni
2017-12-01 15:23         ` Yann E. MORIN [this message]
2017-12-02  4:33       ` Ricardo Martincoski
2017-12-01 22:00   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171201152344.GB2885@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox