From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] check-package: avoid false warning of useless flag
Date: Sat, 2 Dec 2017 14:52:33 +0100 [thread overview]
Message-ID: <20171202145233.62c248e9@windsurf.lan> (raw)
In-Reply-To: <1512188904-31366-1-git-send-email-ricardo.martincoski@datacom.ind.br>
Hello,
On Sat, 2 Dec 2017 02:28:24 -0200, Ricardo Martincoski wrote:
> Just AUTORECONF = NO is redundant.
> Just HOST_AUTORECONF = NO is redundant.
> But the combination of AUTORECONF = YES + HOST_AUTORECONF = NO is valid.
>
> So basically for all variables that have inheritance between target and
> host, having the host variant of the variable set the variable value
> back to its default is correct if the target variable is set.
>
> Instead of increasing complexity of the script to fully detect this
> case, ignore the host flag set to its default value as it can be
> overriding a non-default value inherited from the equivalent target
> flag.
>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> Reported-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br>
> ---
> Part of commit log copied from Thomas' e-mail. I hope you don't mind.
> ---
> utils/checkpackagelib/lib_mk.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-12-02 13:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 23:08 [Buildroot] [PATCH 0/8] Fix warnings reported by check-package Yann E. MORIN
2017-11-29 23:08 ` [Buildroot] [PATCH 1/8] package/lttng-tools: fix typo in variable name Yann E. MORIN
2017-11-30 7:58 ` Thomas Petazzoni
2017-11-29 23:08 ` [Buildroot] [PATCH 2/8] package/checkpolicy: rename variable Yann E. MORIN
2017-12-01 21:55 ` Thomas Petazzoni
2017-11-29 23:08 ` [Buildroot] [PATCH 3/8] package/am335x-pru-package: " Yann E. MORIN
2017-12-01 21:56 ` Thomas Petazzoni
2017-11-29 23:08 ` [Buildroot] [PATCH 4/8] package/lockfile-progs: " Yann E. MORIN
2017-12-01 21:56 ` Thomas Petazzoni
2017-11-29 23:08 ` [Buildroot] [PATCH 5/8] packages: remove "consecutive empty lines" Yann E. MORIN
2017-12-01 21:56 ` Thomas Petazzoni
2017-11-29 23:08 ` [Buildroot] [PATCH 6/8] packages: fix trailing spaces and slash Yann E. MORIN
2017-12-01 21:57 ` Thomas Petazzoni
2017-11-29 23:08 ` [Buildroot] [PATCH 7/8] package/asterisk: add comment about a check-package false positive Yann E. MORIN
2017-11-30 8:00 ` Thomas Petazzoni
2017-11-30 11:19 ` Ricardo Martincoski
2017-11-30 12:57 ` Thomas Petazzoni
2017-12-01 22:00 ` Thomas Petazzoni
2017-12-02 4:28 ` [Buildroot] [PATCH 1/1] check-package: avoid false warning of useless flag Ricardo Martincoski
2017-12-02 11:03 ` Yann E. MORIN
2017-12-02 13:10 ` Thomas Petazzoni
2017-12-02 13:54 ` Yann E. MORIN
2017-12-02 14:08 ` Thomas Petazzoni
2017-12-03 17:48 ` Arnout Vandecappelle
2017-12-02 13:52 ` Thomas Petazzoni [this message]
2017-11-29 23:08 ` [Buildroot] [PATCH 8/8] gitlab-ci: run check-package Yann E. MORIN
2017-11-30 7:59 ` Thomas Petazzoni
2017-11-30 15:34 ` Yann E. MORIN
2017-12-01 9:54 ` Thomas Petazzoni
2017-12-01 15:23 ` Yann E. MORIN
2017-12-02 4:33 ` Ricardo Martincoski
2017-12-01 22:00 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171202145233.62c248e9@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox