[Buildroot] [PATCH v2 branch/next] uboot-tools: fix dtc invocation

[Buildroot] [PATCH v2 branch/next] uboot-tools: fix dtc invocation

[yegorslists at googlemail.com]

From: Yegor Yefremov <yegorslists@googlemail.com>

Since uboot 2017.09 path to dtc will be configured via Kconfig. As BR
skips this step for uboot-tools building one has to provide
CONFIG_MKIMAGE_DTC_PATH=dtc on the build command line. Otherwise
mkimage will not be able to create FIT images, i.e.:

mkimage -f kernel-fit.its kernel-fit.itb

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
Changes v1 -> v2:
  - pass CONFIG_MKIMAGE_DTC_PATH=dtc on the build command line
    instead of patching the Makefile (suggested by Thomas Petazzoni)

 package/uboot-tools/uboot-tools.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/uboot-tools/uboot-tools.mk b/package/uboot-tools/uboot-tools.mk
index 04b526883f..4c559185af 100644
--- a/package/uboot-tools/uboot-tools.mk
+++ b/package/uboot-tools/uboot-tools.mk
@@ -22,7 +22,7 @@ UBOOT_TOOLS_MAKE_OPTS = CROSS_COMPILE="$(TARGET_CROSS)" \
 	STRIP=$(TARGET_STRIP)
 
 ifeq ($(BR2_PACKAGE_UBOOT_TOOLS_FIT_SUPPORT),y)
-UBOOT_TOOLS_MAKE_OPTS += CONFIG_FIT=y
+UBOOT_TOOLS_MAKE_OPTS += CONFIG_FIT=y CONFIG_MKIMAGE_DTC_PATH=dtc
 UBOOT_TOOLS_DEPENDENCIES += dtc
 endif
 
@@ -85,7 +85,7 @@ HOST_UBOOT_TOOLS_MAKE_OPTS = HOSTCC="$(HOSTCC)" \
 	HOSTLDFLAGS="$(HOST_LDFLAGS)"
 
 ifeq ($(BR2_PACKAGE_HOST_UBOOT_TOOLS_FIT_SUPPORT),y)
-HOST_UBOOT_TOOLS_MAKE_OPTS += CONFIG_FIT=y
+HOST_UBOOT_TOOLS_MAKE_OPTS += CONFIG_FIT=y CONFIG_MKIMAGE_DTC_PATH=dtc
 HOST_UBOOT_TOOLS_DEPENDENCIES += host-dtc
 endif
 
-- 
2.11.0

[Buildroot] [PATCH v2 branch/next] uboot-tools: fix dtc invocation

[Thomas Petazzoni]

Hello,

On Fri,  1 Dec 2017 13:40:20 +0100, yegorslists at googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Since uboot 2017.09 path to dtc will be configured via Kconfig. As BR
> skips this step for uboot-tools building one has to provide
> CONFIG_MKIMAGE_DTC_PATH=dtc on the build command line. Otherwise
> mkimage will not be able to create FIT images, i.e.:
> 
> mkimage -f kernel-fit.its kernel-fit.itb
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> Changes v1 -> v2:
>   - pass CONFIG_MKIMAGE_DTC_PATH=dtc on the build command line
>     instead of patching the Makefile (suggested by Thomas Petazzoni)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2 branch/next] uboot-tools: fix dtc invocation

[Peter Korsgaard]

>>>>> "yegorslists" == yegorslists  <yegorslists@googlemail.com> writes:

 > From: Yegor Yefremov <yegorslists@googlemail.com>
 > Since uboot 2017.09 path to dtc will be configured via Kconfig. As BR
 > skips this step for uboot-tools building one has to provide
 > CONFIG_MKIMAGE_DTC_PATH=dtc on the build command line. Otherwise
 > mkimage will not be able to create FIT images, i.e.:

 > mkimage -f kernel-fit.its kernel-fit.itb

 > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
 > ---
 > Changes v1 -> v2:
 >   - pass CONFIG_MKIMAGE_DTC_PATH=dtc on the build command line
 >     instead of patching the Makefile (suggested by Thomas Petazzoni)

Committed to 2017.11.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v2 branch/next] uboot-tools: fix dtc invocation

[Trent Piepho]

On Wed, 2017-12-27 at 10:40 +0100, Peter Korsgaard wrote:
> > > > > > "yegorslists" == yegorslists  <yegorslists@googlemail.com> writes:
> 
>  > From: Yegor Yefremov <yegorslists@googlemail.com>
>  > Since uboot 2017.09 path to dtc will be configured via Kconfig. As BR

This isn't quite right, the change to u-boot that pulls in the dtc path
via a Kconfig setting was part of uboot 2017.11-rc1.  The version of u-
boot tools in buildroot 2017.11.x, uboot 2017.09, does not have the
change and works correctly without this patch.

However, the patch does no harm: it just supplies an unused variable on
the command line.

>  > skips this step for uboot-tools building one has to provide
>  > CONFIG_MKIMAGE_DTC_PATH=dtc on the build command line. Otherwise
>  > mkimage will not be able to create FIT images, i.e.:
> 

[Buildroot] [PATCH v2 branch/next] uboot-tools: fix dtc invocation

[Peter Korsgaard]

>>>>> "Trent" == Trent Piepho <tpiepho@impinj.com> writes:

 > On Wed, 2017-12-27 at 10:40 +0100, Peter Korsgaard wrote:
 >> > > > > > "yegorslists" == yegorslists  <yegorslists@googlemail.com> writes:
 >> 
 >> > From: Yegor Yefremov <yegorslists@googlemail.com>
 >> > Since uboot 2017.09 path to dtc will be configured via Kconfig. As BR

 > This isn't quite right, the change to u-boot that pulls in the dtc path
 > via a Kconfig setting was part of uboot 2017.11-rc1.  The version of u-
 > boot tools in buildroot 2017.11.x, uboot 2017.09, does not have the
 > change and works correctly without this patch.

 > However, the patch does no harm: it just supplies an unused variable on
 > the command line.

Ahh, ok - Thanks for the heads up.

-- 
Bye, Peter Korsgaard