* [Buildroot] [PATCH v1] qt5quickcontrols2: fix examples compile without Qt widgets module
@ 2017-11-25 21:54 Peter Seiderer
2017-12-01 22:30 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Peter Seiderer @ 2017-11-25 21:54 UTC (permalink / raw)
To: buildroot
Add upstream suggested patch to fix flatstyle example configure
(needs widgets module).
Fixes:
cd flatstyle/ && ( test -e Makefile || .../host/bin/qmake -o Makefile .../build/qt5quickcontrols2-5.9.2/examples/quickcontrols2/flatstyle/flatstyle.pro ) && make -f Makefile
Project ERROR: Unknown module(s) in QT: widgets
make[1]: *** [Makefile:202: sub-flatstyle-make_first] Error 3
make[1]: Leaving directory '.../build/qt5quickcontrols2-5.9.2/examples/quickcontrols2'
make: *** [Makefile:45: sub-quickcontrols2-make_first] Error 2
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Note: tested with patch '[PATCH v5] qt5: remove Qt Quick dependency on opengl'
applied.
---
...01-Example-flatstyle-needs-widgets-module.patch | 31 ++++++++++++++++++++++
1 file changed, 31 insertions(+)
create mode 100644 package/qt5/qt5quickcontrols2/5.9.2/0001-Example-flatstyle-needs-widgets-module.patch
diff --git a/package/qt5/qt5quickcontrols2/5.9.2/0001-Example-flatstyle-needs-widgets-module.patch b/package/qt5/qt5quickcontrols2/5.9.2/0001-Example-flatstyle-needs-widgets-module.patch
new file mode 100644
index 0000000000..17e3b3610e
--- /dev/null
+++ b/package/qt5/qt5quickcontrols2/5.9.2/0001-Example-flatstyle-needs-widgets-module.patch
@@ -0,0 +1,31 @@
+From 10d92524cd6736c767c9ce55a1d9b9f1a2a69a9f Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <ps.report@gmx.net>
+Date: Sat, 25 Nov 2017 22:26:58 +0100
+Subject: [PATCH] Example flatstyle needs widgets module
+
+Fixes compile with disabled widgets module.
+
+Task-number: QTBUG-64761
+Change-Id: I743884d77d51e89061d87cab006bab0cafc9ddb7
+
+Upstream: https://codereview.qt-project.org/212583
+Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+---
+ examples/quickcontrols2/quickcontrols2.pro | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/examples/quickcontrols2/quickcontrols2.pro b/examples/quickcontrols2/quickcontrols2.pro
+index 858759f..8310e9b 100644
+--- a/examples/quickcontrols2/quickcontrols2.pro
++++ b/examples/quickcontrols2/quickcontrols2.pro
+@@ -6,5 +6,6 @@ SUBDIRS += \
+ contactlist \
+ sidepanel \
+ swipetoremove \
+- flatstyle \
+ wearable
++
++qtHaveModule(widgets): SUBDIRS += flatstyle
+--
+2.7.4
+
--
2.15.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH v1] qt5quickcontrols2: fix examples compile without Qt widgets module
2017-11-25 21:54 [Buildroot] [PATCH v1] qt5quickcontrols2: fix examples compile without Qt widgets module Peter Seiderer
@ 2017-12-01 22:30 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2017-12-01 22:30 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 25 Nov 2017 22:54:25 +0100, Peter Seiderer wrote:
> Add upstream suggested patch to fix flatstyle example configure
> (needs widgets module).
>
> Fixes:
>
> cd flatstyle/ && ( test -e Makefile || .../host/bin/qmake -o Makefile .../build/qt5quickcontrols2-5.9.2/examples/quickcontrols2/flatstyle/flatstyle.pro ) && make -f Makefile
> Project ERROR: Unknown module(s) in QT: widgets
> make[1]: *** [Makefile:202: sub-flatstyle-make_first] Error 3
> make[1]: Leaving directory '.../build/qt5quickcontrols2-5.9.2/examples/quickcontrols2'
> make: *** [Makefile:45: sub-quickcontrols2-make_first] Error 2
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Note: tested with patch '[PATCH v5] qt5: remove Qt Quick dependency on opengl'
> applied.
> ---
> ...01-Example-flatstyle-needs-widgets-module.patch | 31 ++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 package/qt5/qt5quickcontrols2/5.9.2/0001-Example-flatstyle-needs-widgets-module.patch
Applied to master after changing the patch location so that it applies
to the 5.9.3 version (I verified, it still applies correctly).
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-01 22:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-25 21:54 [Buildroot] [PATCH v1] qt5quickcontrols2: fix examples compile without Qt widgets module Peter Seiderer
2017-12-01 22:30 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox