[Buildroot] [PATCH 1/1] webp: add mandatory host-pkgconf dependency

[Buildroot] [PATCH 1/1] webp: add mandatory host-pkgconf dependency

[Fabrice Fontaine]

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/webp/webp.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/webp/webp.mk b/package/webp/webp.mk
index e86e798d9..cb2ec5b15 100644
--- a/package/webp/webp.mk
+++ b/package/webp/webp.mk
@@ -9,6 +9,7 @@ WEBP_SOURCE = libwebp-$(WEBP_VERSION).tar.gz
 WEBP_SITE = http://downloads.webmproject.org/releases/webp
 WEBP_LICENSE = BSD-3-Clause
 WEBP_LICENSE_FILES = COPYING
+WEBP_DEPENDENCIES = host-pkgconf
 WEBP_INSTALL_STAGING = YES
 
 WEBP_CONF_OPTS += \
-- 
2.14.1

[Buildroot] [PATCH 1/1] webp: add mandatory host-pkgconf dependency

[Thomas Petazzoni]

Hello,

On Sat,  2 Dec 2017 15:11:57 +0100, Fabrice Fontaine wrote:
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Could you give a few more details here? From a quick grep in the webp
code, I don't see PKG_CHECK_MODULES() used anywhere, not pkg-config
used. I quite probably missed it, but if it's not obvious, a slightly
more verbose commit log would be nice.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] webp: add mandatory host-pkgconf dependency

[Fabrice Fontaine]

Hello,

2017-12-02 15:24 GMT+01:00 Thomas Petazzoni <
thomas.petazzoni@free-electrons.com>:

> Hello,
>
> On Sat,  2 Dec 2017 15:11:57 +0100, Fabrice Fontaine wrote:
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
> Could you give a few more details here? From a quick grep in the webp
> code, I don't see PKG_CHECK_MODULES() used anywhere, not pkg-config
> used. I quite probably missed it, but if it's not obvious, a slightly
> more verbose commit log would be nice.
>
My bad, this is a mistake, I saw that there was a pkgconfigdir option but
it is not used to find packages but to install webp files.

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
>
Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20171202/8af32676/attachment.html>