* [Buildroot] [PATCH] pimd: new package
@ 2017-12-02 15:24 Sergio Prado
2017-12-02 16:15 ` Marcus Folkesson
2017-12-02 23:19 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Sergio Prado @ 2017-12-02 15:24 UTC (permalink / raw)
To: buildroot
pimd is a lightweight stand-alone PIM-SM v2 multicast routing daemon.
Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
---
DEVELOPERS | 1 +
package/Config.in | 1 +
package/pimd/Config.in | 8 ++++++++
package/pimd/pimd.hash | 3 +++
package/pimd/pimd.mk | 20 ++++++++++++++++++++
5 files changed, 33 insertions(+)
create mode 100644 package/pimd/Config.in
create mode 100644 package/pimd/pimd.hash
create mode 100644 package/pimd/pimd.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index 27b22f4f0fed..1a998f3dfc12 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1518,6 +1518,7 @@ F: configs/linksprite_pcduino_defconfig
N: Sergio Prado <sergio.prado@e-labworks.com>
F: package/libgdiplus/
F: package/mongodb/
+F: package/pimd/
F: package/stella/
F: package/tunctl/
F: package/ubus/
diff --git a/package/Config.in b/package/Config.in
index aa111e48e6fb..104859fcd1c1 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1410,6 +1410,7 @@ menu "Networking"
source "package/openzwave/Config.in"
source "package/ortp/Config.in"
source "package/paho-mqtt-c/Config.in"
+ source "package/pimd/Config.in"
source "package/qdecoder/Config.in"
source "package/qpid-proton/Config.in"
source "package/rabbitmq-c/Config.in"
diff --git a/package/pimd/Config.in b/package/pimd/Config.in
new file mode 100644
index 000000000000..d6a579bda258
--- /dev/null
+++ b/package/pimd/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_PIMD
+ bool "pimd"
+ depends on BR2_USE_MMU # fork()
+ help
+ pimd is a lightweight stand-alone PIM-SM v2 multicast routing
+ daemon.
+
+ http://troglobit.com/project/pimd/
diff --git a/package/pimd/pimd.hash b/package/pimd/pimd.hash
new file mode 100644
index 000000000000..20252a6d4ed7
--- /dev/null
+++ b/package/pimd/pimd.hash
@@ -0,0 +1,3 @@
+# Locally computed:
+sha256 c77a9812751f114490a28a6839b16aac8b020c8d9fd6aa22bf3880c054e19f1d pimd-2.3.2.tar.gz
+sha256 3379436c16caccdef9b40a49fbdfdbb45aad8ecb05870834490b8fb080126009 LICENSE
diff --git a/package/pimd/pimd.mk b/package/pimd/pimd.mk
new file mode 100644
index 000000000000..cd9427094a61
--- /dev/null
+++ b/package/pimd/pimd.mk
@@ -0,0 +1,20 @@
+################################################################################
+#
+# pimd
+#
+################################################################################
+
+PIMD_VERSION = 2.3.2
+PIMD_SOURCE = pimd-$(PIMD_VERSION).tar.gz
+PIMD_SITE = https://github.com/troglobit/pimd/releases/download/$(PIMD_VERSION)
+
+PIMD_LICENSE = BSD-3-Clause
+PIMD_LICENSE_FILES = LICENSE
+
+PIMD_MAKE_OPTS = CROSS=$(TARGET_CROSS) CC=$(TARGET_CC)
+
+ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC)$(BR2_TOOLCHAIN_USES_MUSL),y)
+PIMD_CONF_OPTS = --embedded-libc
+endif
+
+$(eval $(autotools-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] pimd: new package
2017-12-02 15:24 [Buildroot] [PATCH] pimd: new package Sergio Prado
@ 2017-12-02 16:15 ` Marcus Folkesson
2017-12-04 10:15 ` Sergio Prado
2017-12-02 23:19 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Marcus Folkesson @ 2017-12-02 16:15 UTC (permalink / raw)
To: buildroot
Hi,
On Sat, Dec 02, 2017 at 01:24:02PM -0200, Sergio Prado wrote:
> pimd is a lightweight stand-alone PIM-SM v2 multicast routing daemon.
> diff --git a/package/pimd/pimd.mk b/package/pimd/pimd.mk
> new file mode 100644
> index 000000000000..cd9427094a61
> --- /dev/null
> +++ b/package/pimd/pimd.mk
> @@ -0,0 +1,20 @@
> +################################################################################
> +#
> +# pimd
> +#
> +################################################################################
> +
> +PIMD_VERSION = 2.3.2
> +PIMD_SOURCE = pimd-$(PIMD_VERSION).tar.gz
> +PIMD_SITE = https://github.com/troglobit/pimd/releases/download/$(PIMD_VERSION)
> +
> +PIMD_LICENSE = BSD-3-Clause
> +PIMD_LICENSE_FILES = LICENSE
LICENSE.mrouted Should also be listed in PIMD_LICENSE_FILES.
From LICENSE:
Part of this program has been derived from mrouted.
The mrouted program is covered by the license in the accompanying file
named "LICENSE.mrouted".
> +
> +PIMD_MAKE_OPTS = CROSS=$(TARGET_CROSS) CC=$(TARGET_CC)
> +
> +ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC)$(BR2_TOOLCHAIN_USES_MUSL),y)
> +PIMD_CONF_OPTS = --embedded-libc
> +endif
> +
> +$(eval $(autotools-package))
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Best regards
Marcus Folkesson
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] pimd: new package
2017-12-02 15:24 [Buildroot] [PATCH] pimd: new package Sergio Prado
2017-12-02 16:15 ` Marcus Folkesson
@ 2017-12-02 23:19 ` Thomas Petazzoni
2017-12-04 10:18 ` Sergio Prado
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2017-12-02 23:19 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 2 Dec 2017 13:24:02 -0200, Sergio Prado wrote:
> diff --git a/package/pimd/pimd.mk b/package/pimd/pimd.mk
> new file mode 100644
> index 000000000000..cd9427094a61
> --- /dev/null
> +++ b/package/pimd/pimd.mk
> @@ -0,0 +1,20 @@
> +################################################################################
> +#
> +# pimd
> +#
> +################################################################################
> +
> +PIMD_VERSION = 2.3.2
> +PIMD_SOURCE = pimd-$(PIMD_VERSION).tar.gz
> +PIMD_SITE = https://github.com/troglobit/pimd/releases/download/$(PIMD_VERSION)
> +
> +PIMD_LICENSE = BSD-3-Clause
> +PIMD_LICENSE_FILES = LICENSE
> +
> +PIMD_MAKE_OPTS = CROSS=$(TARGET_CROSS) CC=$(TARGET_CC)
> +
> +ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC)$(BR2_TOOLCHAIN_USES_MUSL),y)
> +PIMD_CONF_OPTS = --embedded-libc
> +endif
> +
> +$(eval $(autotools-package))
I was a bit confused at first, because when I looked at the code in
http://troglobit.com/project/pimd/, it was using a traditional
configure.ac and Makefile.am, which surely shouldn't require passing
CROSS and CC at build time, and which also doesn't have any
--embedded-libc option.
The reason is that 2.3.2, which was released in March 2016, predates
the introduction of autotools as the build system.
Therefore, I see two possibilities here:
- You stick with 2.3.2. In this case, you should use generic-package
and not autotools-package, because at 2.3.2, pimd is clearly not an
autotools-package. It's not because it works by chance with the
current autotools-package infrastructure that a future subtle change
in the autotools-package infrastructure, which is valid for real
autotools package, will break this non-autotools package.
- You move to the latest Git commit, which really uses an autotools
based build system.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] pimd: new package
2017-12-02 16:15 ` Marcus Folkesson
@ 2017-12-04 10:15 ` Sergio Prado
2017-12-04 10:21 ` Marcus Folkesson
0 siblings, 1 reply; 6+ messages in thread
From: Sergio Prado @ 2017-12-04 10:15 UTC (permalink / raw)
To: buildroot
Hi Marcus,
> LICENSE.mrouted Should also be listed in PIMD_LICENSE_FILES.
>
> From LICENSE:
> Part of this program has been derived from mrouted.
> The mrouted program is covered by the license in the accompanying file
> named "LICENSE.mrouted".
Thanks for noticing that. I'll change and send V2.
Best regards,
Sergio Prado
Embedded Labworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20171204/23ce4c43/attachment.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] pimd: new package
2017-12-02 23:19 ` Thomas Petazzoni
@ 2017-12-04 10:18 ` Sergio Prado
0 siblings, 0 replies; 6+ messages in thread
From: Sergio Prado @ 2017-12-04 10:18 UTC (permalink / raw)
To: buildroot
Hi Thomas,
> I was a bit confused at first, because when I looked at the code in
> http://troglobit.com/project/pimd/, it was using a traditional
> configure.ac and Makefile.am, which surely shouldn't require passing
> CROSS and CC at build time, and which also doesn't have any
> --embedded-libc option.
>
> The reason is that 2.3.2, which was released in March 2016, predates
> the introduction of autotools as the build system.
>
> Therefore, I see two possibilities here:
>
> - You stick with 2.3.2. In this case, you should use generic-package
> and not autotools-package, because at 2.3.2, pimd is clearly not an
> autotools-package. It's not because it works by chance with the
> current autotools-package infrastructure that a future subtle change
> in the autotools-package infrastructure, which is valid for real
> autotools package, will break this non-autotools package.
>
> - You move to the latest Git commit, which really uses an autotools
> based build system.
OK. I'll change to the generic-package infrastructure.
Best regards,
Sergio Prado
Embedded Labworks
https:/e-labworks.com/en
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20171204/ec94da93/attachment.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] pimd: new package
2017-12-04 10:15 ` Sergio Prado
@ 2017-12-04 10:21 ` Marcus Folkesson
0 siblings, 0 replies; 6+ messages in thread
From: Marcus Folkesson @ 2017-12-04 10:21 UTC (permalink / raw)
To: buildroot
Hi,
On Mon, Dec 04, 2017 at 08:15:58AM -0200, Sergio Prado wrote:
> Hi Marcus,
>
> > LICENSE.mrouted Should also be listed in PIMD_LICENSE_FILES.
> >
> > From LICENSE:
> > Part of this program has been derived from mrouted.
> > The mrouted program is covered by the license in the accompanying file
> > named "LICENSE.mrouted".
>
> Thanks for noticing that. I'll change and send V2.
Just remember to calculate hash for LICENSE.mrouted as well :-)
Best regards
Marcus Folkesson
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-04 10:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-02 15:24 [Buildroot] [PATCH] pimd: new package Sergio Prado
2017-12-02 16:15 ` Marcus Folkesson
2017-12-04 10:15 ` Sergio Prado
2017-12-04 10:21 ` Marcus Folkesson
2017-12-02 23:19 ` Thomas Petazzoni
2017-12-04 10:18 ` Sergio Prado
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox