Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/linux-tools: fixes build of iio with 4.14+ kernels
@ 2017-12-08 11:52 julien.boibessot at free.fr
  2017-12-12  6:30 ` Thomas Petazzoni
  2017-12-27 11:54 ` Peter Korsgaard
  0 siblings, 2 replies; 5+ messages in thread
From: julien.boibessot at free.fr @ 2017-12-08 11:52 UTC (permalink / raw)
  To: buildroot

From: Julien BOIBESSOT <julien.boibessot@armadeus.com>

Since this commit [1], iio build has been moved to other linux-tools build
system. Installation dir is now given by DESTDIR, like for all other linux-tools.
I kept INSTALL_DIR env and 'install' target to be compatible with oldest
kernels.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/tools/iio/Makefile?h=v4.14.4&id=18956cf2d78a8d4a5959e20240f04ce8d5a6c121

Signed-off-by: Julien BOIBESSOT <julien.boibessot@armadeus.com>
---
 package/linux-tools/linux-tool-iio.mk.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/linux-tools/linux-tool-iio.mk.in b/package/linux-tools/linux-tool-iio.mk.in
index 60d6249..a8cc89e 100644
--- a/package/linux-tools/linux-tool-iio.mk.in
+++ b/package/linux-tools/linux-tool-iio.mk.in
@@ -19,9 +19,11 @@ define IIO_BUILD_CMDS
 		$(IIO_MAKE_OPTS)
 endef
 
+# DESTDIR used since kernel version 4.14
 define IIO_INSTALL_TARGET_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools/iio \
 		$(IIO_MAKE_OPTS) \
 		INSTALL_ROOT=$(TARGET_DIR) \
+		DESTDIR=$(TARGET_DIR) \
 		install
 endef
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] package/linux-tools: fixes build of iio with 4.14+ kernels
  2017-12-08 11:52 [Buildroot] [PATCH] package/linux-tools: fixes build of iio with 4.14+ kernels julien.boibessot at free.fr
@ 2017-12-12  6:30 ` Thomas Petazzoni
  2017-12-12  9:35   ` Julien Boibessot
  2017-12-27 11:54 ` Peter Korsgaard
  1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2017-12-12  6:30 UTC (permalink / raw)
  To: buildroot

Hello,

On Fri,  8 Dec 2017 12:52:18 +0100, julien.boibessot at free.fr wrote:
> From: Julien BOIBESSOT <julien.boibessot@armadeus.com>
> 
> Since this commit [1], iio build has been moved to other linux-tools build
> system. Installation dir is now given by DESTDIR, like for all other linux-tools.
> I kept INSTALL_DIR env and 'install' target to be compatible with oldest
> kernels.
> 
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/tools/iio/Makefile?h=v4.14.4&id=18956cf2d78a8d4a5959e20240f04ce8d5a6c121
> 
> Signed-off-by: Julien BOIBESSOT <julien.boibessot@armadeus.com>
> ---
>  package/linux-tools/linux-tool-iio.mk.in | 2 ++
>  1 file changed, 2 insertions(+)

Applied to master after improving the commit log. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] package/linux-tools: fixes build of iio with 4.14+ kernels
  2017-12-12  6:30 ` Thomas Petazzoni
@ 2017-12-12  9:35   ` Julien Boibessot
  2017-12-12 10:41     ` Thomas Petazzoni
  0 siblings, 1 reply; 5+ messages in thread
From: Julien Boibessot @ 2017-12-12  9:35 UTC (permalink / raw)
  To: buildroot

On 12/12/2017 07:30, Thomas Petazzoni wrote:
> Hello,
>
> On Fri,  8 Dec 2017 12:52:18 +0100, julien.boibessot at free.fr wrote:
>> From: Julien BOIBESSOT <julien.boibessot@armadeus.com>
>>
>> Since this commit [1], iio build has been moved to other linux-tools build
>> system. Installation dir is now given by DESTDIR, like for all other linux-tools.
>> I kept INSTALL_DIR env and 'install' target to be compatible with oldest
>> kernels.
>>
>> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/tools/iio/Makefile?h=v4.14.4&id=18956cf2d78a8d4a5959e20240f04ce8d5a6c121
>>
>> Signed-off-by: Julien BOIBESSOT <julien.boibessot@armadeus.com>
>> ---
>>  package/linux-tools/linux-tool-iio.mk.in | 2 ++
>>  1 file changed, 2 insertions(+)
> Applied to master after improving the commit log. Thanks!

Thanks Thomas, should I send the same for 2017.02 ?

Regards,
Julien

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] package/linux-tools: fixes build of iio with 4.14+ kernels
  2017-12-12  9:35   ` Julien Boibessot
@ 2017-12-12 10:41     ` Thomas Petazzoni
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2017-12-12 10:41 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue, 12 Dec 2017 10:35:24 +0100, Julien Boibessot wrote:

> > Applied to master after improving the commit log. Thanks!  
> 
> Thanks Thomas, should I send the same for 2017.02 ?

Not needed, Peter will apply it to the 2017.02.x branch.

Ideally, when you know a patch is needed for 2017.02.x, it would be
nice to indicate that under the --- sign that follows the
Signed-off-by. This way, it is clear for Peter that the submitter wants
the patch in 2017.02.x.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] package/linux-tools: fixes build of iio with 4.14+ kernels
  2017-12-08 11:52 [Buildroot] [PATCH] package/linux-tools: fixes build of iio with 4.14+ kernels julien.boibessot at free.fr
  2017-12-12  6:30 ` Thomas Petazzoni
@ 2017-12-27 11:54 ` Peter Korsgaard
  1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2017-12-27 11:54 UTC (permalink / raw)
  To: buildroot

>>>>> "julien" == julien boibessot <julien.boibessot@free.fr> writes:

 > From: Julien BOIBESSOT <julien.boibessot@armadeus.com>
 > Since this commit [1], iio build has been moved to other linux-tools build
 > system. Installation dir is now given by DESTDIR, like for all other linux-tools.
 > I kept INSTALL_DIR env and 'install' target to be compatible with oldest
 > kernels.

 > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/tools/iio/Makefile?h=v4.14.4&id=18956cf2d78a8d4a5959e20240f04ce8d5a6c121

 > Signed-off-by: Julien BOIBESSOT <julien.boibessot@armadeus.com>

Committed to 2017.11.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-12-27 11:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-08 11:52 [Buildroot] [PATCH] package/linux-tools: fixes build of iio with 4.14+ kernels julien.boibessot at free.fr
2017-12-12  6:30 ` Thomas Petazzoni
2017-12-12  9:35   ` Julien Boibessot
2017-12-12 10:41     ` Thomas Petazzoni
2017-12-27 11:54 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox