* [Buildroot] [PATCH v2] lynx: new package
@ 2017-12-12 18:41 Mario Lang
2017-12-12 21:13 ` Adrian Perez de Castro
2017-12-13 7:43 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Mario Lang @ 2017-12-12 18:41 UTC (permalink / raw)
To: buildroot
Signed-off-by: Mario Lang <mlang@blind.guru>
---
Changes in v2:
* Add optional support for BR2_PACKAGE_NCURSES_WCHAR
* Add optional dependency on slang
* Add homepage URL to config help
DEVELOPERS | 3 +++
package/Config.in | 1 +
package/lynx/Config.in | 8 ++++++++
package/lynx/lynx.hash | 3 +++
package/lynx/lynx.mk | 38 ++++++++++++++++++++++++++++++++++++++
5 files changed, 53 insertions(+)
create mode 100644 package/lynx/Config.in
create mode 100644 package/lynx/lynx.hash
create mode 100644 package/lynx/lynx.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index 77e3344fa4..63809f1afb 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1040,6 +1040,9 @@ F: package/polkit/
F: package/sg3_utils/
F: package/udisks/
+N: Mario Lang <mlang@blind.guru>
+F: package/lynx/
+
N: Mario Rugiero <mrugiero@gmail.com>
F: package/ratpoison/
diff --git a/package/Config.in b/package/Config.in
index cb2141b8f3..c3ebbfc8c4 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1699,6 +1699,7 @@ menu "Networking applications"
source "package/linuxptp/Config.in"
source "package/lldpd/Config.in"
source "package/lrzsz/Config.in"
+ source "package/lynx/Config.in"
source "package/macchanger/Config.in"
source "package/memcached/Config.in"
source "package/mii-diag/Config.in"
diff --git a/package/lynx/Config.in b/package/lynx/Config.in
new file mode 100644
index 0000000000..4a8674fd6d
--- /dev/null
+++ b/package/lynx/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LYNX
+ bool "lynx"
+ select BR2_PACKAGE_NCURSES if !BR2_PACKAGE_SLANG
+ select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_GNUTLS
+ help
+ The Text Web-Browser.
+
+ http://lynx.invisible-island.net/
diff --git a/package/lynx/lynx.hash b/package/lynx/lynx.hash
new file mode 100644
index 0000000000..c39475aa23
--- /dev/null
+++ b/package/lynx/lynx.hash
@@ -0,0 +1,3 @@
+# Locally calculated:
+sha256 04318a100b052d079d0018fa371aa28cfb41ab68db3a959f3b75c2170eea1bc8 lynx2.8.9dev.16.tar.bz2
+sha256 8406a30ff3134ec23cf752d1ceda92ddaabbe41b4f2dc07ea3cfa139de12d6d6 COPYING
diff --git a/package/lynx/lynx.mk b/package/lynx/lynx.mk
new file mode 100644
index 0000000000..a95326a14a
--- /dev/null
+++ b/package/lynx/lynx.mk
@@ -0,0 +1,38 @@
+################################################################################
+#
+# lynx
+#
+################################################################################
+
+LYNX_VERSION = 2.8.9dev.16
+LYNX_SOURCE = lynx$(LYNX_VERSION).tar.bz2
+LYNX_SITE = ftp://ftp.invisible-island.net/lynx/tarballs
+LYNX_LICENSE = GPL-2.0
+LYNX_LICENSE_FILES = COPYING
+
+LYNX_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
+
+ifeq ($(BR2_PACKAGE_NCURSES),y)
+LYNX_DEPENDENCIES += ncurses
+LYNX_CONF_OPTS += --with-screen=ncurses$(if $(BR2_PACKAGE_NCURSES_WCHAR),w)
+else ifeq ($(BR2_PACKAGE_SLANG),y)
+LYNX_DEPENDENCIES += slang
+LYNX_CONF_OPTS += --with-screen=slang
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LYNX_DEPENDENCIES += openssl
+LYNX_CONF_OPTS += --with-ssl
+else ifeq ($(BR2_PACKAGE_GNUTLS),y)
+LYNX_DEPENDENCIES += gnutls
+LYNX_CONF_OPTS += --with-gnutls
+endif
+
+ifeq ($(BR2_PACKAGE_ZLIB),y)
+LYNX_DEPENDENCIES += zlib
+LYNX_CONF_OPTS += --with-zlib
+else
+LYNX_CONF_OPTS += --without-zlib
+endif
+
+$(eval $(autotools-package))
--
2.15.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2] lynx: new package
2017-12-12 18:41 [Buildroot] [PATCH v2] lynx: new package Mario Lang
@ 2017-12-12 21:13 ` Adrian Perez de Castro
2017-12-13 7:43 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Adrian Perez de Castro @ 2017-12-12 21:13 UTC (permalink / raw)
To: buildroot
Hi Mario,
On Tue, 12 Dec 2017 19:41:28 +0100, Mario Lang <mlang@blind.guru> wrote:
> Signed-off-by: Mario Lang <mlang@blind.guru>
> ---
> Changes in v2:
> * Add optional support for BR2_PACKAGE_NCURSES_WCHAR
> * Add optional dependency on slang
> * Add homepage URL to config help
>
> DEVELOPERS | 3 +++
> package/Config.in | 1 +
> package/lynx/Config.in | 8 ++++++++
> package/lynx/lynx.hash | 3 +++
> package/lynx/lynx.mk | 38 ++++++++++++++++++++++++++++++++++++++
> 5 files changed, 53 insertions(+)
> create mode 100644 package/lynx/Config.in
> create mode 100644 package/lynx/lynx.hash
> create mode 100644 package/lynx/lynx.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 77e3344fa4..63809f1afb 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1040,6 +1040,9 @@ F: package/polkit/
> F: package/sg3_utils/
> F: package/udisks/
>
> +N: Mario Lang <mlang@blind.guru>
> +F: package/lynx/
> +
> N: Mario Rugiero <mrugiero@gmail.com>
> F: package/ratpoison/
>
> diff --git a/package/Config.in b/package/Config.in
> index cb2141b8f3..c3ebbfc8c4 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1699,6 +1699,7 @@ menu "Networking applications"
> source "package/linuxptp/Config.in"
> source "package/lldpd/Config.in"
> source "package/lrzsz/Config.in"
> + source "package/lynx/Config.in"
> source "package/macchanger/Config.in"
> source "package/memcached/Config.in"
> source "package/mii-diag/Config.in"
> diff --git a/package/lynx/Config.in b/package/lynx/Config.in
> new file mode 100644
> index 0000000000..4a8674fd6d
> --- /dev/null
> +++ b/package/lynx/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_LYNX
> + bool "lynx"
> + select BR2_PACKAGE_NCURSES if !BR2_PACKAGE_SLANG
> + select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_GNUTLS
> + help
> + The Text Web-Browser.
> +
> + http://lynx.invisible-island.net/
> diff --git a/package/lynx/lynx.hash b/package/lynx/lynx.hash
> new file mode 100644
> index 0000000000..c39475aa23
> --- /dev/null
> +++ b/package/lynx/lynx.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated:
> +sha256 04318a100b052d079d0018fa371aa28cfb41ab68db3a959f3b75c2170eea1bc8 lynx2.8.9dev.16.tar.bz2
> +sha256 8406a30ff3134ec23cf752d1ceda92ddaabbe41b4f2dc07ea3cfa139de12d6d6 COPYING
> diff --git a/package/lynx/lynx.mk b/package/lynx/lynx.mk
> new file mode 100644
> index 0000000000..a95326a14a
> --- /dev/null
> +++ b/package/lynx/lynx.mk
> @@ -0,0 +1,38 @@
> +################################################################################
> +#
> +# lynx
> +#
> +################################################################################
> +
> +LYNX_VERSION = 2.8.9dev.16
> +LYNX_SOURCE = lynx$(LYNX_VERSION).tar.bz2
> +LYNX_SITE = ftp://ftp.invisible-island.net/lynx/tarballs
> +LYNX_LICENSE = GPL-2.0
> +LYNX_LICENSE_FILES = COPYING
> +
> +LYNX_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
> +
> +ifeq ($(BR2_PACKAGE_NCURSES),y)
> +LYNX_DEPENDENCIES += ncurses
> +LYNX_CONF_OPTS += --with-screen=ncurses$(if $(BR2_PACKAGE_NCURSES_WCHAR),w)
> +else ifeq ($(BR2_PACKAGE_SLANG),y)
> +LYNX_DEPENDENCIES += slang
> +LYNX_CONF_OPTS += --with-screen=slang
> +endif
> +
> +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +LYNX_DEPENDENCIES += openssl
> +LYNX_CONF_OPTS += --with-ssl
> +else ifeq ($(BR2_PACKAGE_GNUTLS),y)
> +LYNX_DEPENDENCIES += gnutls
> +LYNX_CONF_OPTS += --with-gnutls
> +endif
> +
> +ifeq ($(BR2_PACKAGE_ZLIB),y)
> +LYNX_DEPENDENCIES += zlib
> +LYNX_CONF_OPTS += --with-zlib
> +else
> +LYNX_CONF_OPTS += --without-zlib
> +endif
> +
> +$(eval $(autotools-package))
> --
> 2.15.0
Thanks for updating the patch. Looks all neat to me now :-)
Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>
--
Adri?n ?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20171212/da6effef/attachment.asc>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2] lynx: new package
2017-12-12 18:41 [Buildroot] [PATCH v2] lynx: new package Mario Lang
2017-12-12 21:13 ` Adrian Perez de Castro
@ 2017-12-13 7:43 ` Thomas Petazzoni
2017-12-18 10:17 ` Thomas Petazzoni
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2017-12-13 7:43 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 12 Dec 2017 19:41:28 +0100, Mario Lang wrote:
> +config BR2_PACKAGE_LYNX
> + bool "lynx"
> + select BR2_PACKAGE_NCURSES if !BR2_PACKAGE_SLANG
Sadly, this causes a recursive dependency:
package/slang/Config.in:1:error: recursive dependency detected!
package/slang/Config.in:1: symbol BR2_PACKAGE_SLANG is selected by BR2_PACKAGE_NCURSES
package/ncurses/Config.in:1: symbol BR2_PACKAGE_NCURSES is selected by BR2_PACKAGE_SLANG
configuration written to /home/thomas/projets/buildroot/.config
It's not clear from the log, but I guess it's because the mc package
does it the other way around: select slang if !ncurses.
So, I've changed your lynx package to also do select slang if !ncurses.
I had to propagate the BR2_USE_MMU dependency of slang to lynx as a
consequence.
Applied with this fixed.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2] lynx: new package
2017-12-13 7:43 ` Thomas Petazzoni
@ 2017-12-18 10:17 ` Thomas Petazzoni
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2017-12-18 10:17 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 13 Dec 2017 08:43:41 +0100, Thomas Petazzoni wrote:
> package/slang/Config.in:1:error: recursive dependency detected!
> package/slang/Config.in:1: symbol BR2_PACKAGE_SLANG is selected by BR2_PACKAGE_NCURSES
> package/ncurses/Config.in:1: symbol BR2_PACKAGE_NCURSES is selected by BR2_PACKAGE_SLANG
> configuration written to /home/thomas/projets/buildroot/.config
>
> It's not clear from the log, but I guess it's because the mc package
> does it the other way around: select slang if !ncurses.
>
> So, I've changed your lynx package to also do select slang if !ncurses.
> I had to propagate the BR2_USE_MMU dependency of slang to lynx as a
> consequence.
We have some build failures on lynx:
http://autobuild.buildroot.net/?reason=lynx-2.8.9dev.16
I'm adding Matt Weber in Cc since so far the 3 failures all occurred on
his autobuilder, so it might be related to his setup.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-18 10:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-12 18:41 [Buildroot] [PATCH v2] lynx: new package Mario Lang
2017-12-12 21:13 ` Adrian Perez de Castro
2017-12-13 7:43 ` Thomas Petazzoni
2017-12-18 10:17 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox