[Buildroot] [PATCH 1/1] utils/scanpypi: increase error message verbosity

[Buildroot] [PATCH 1/1] utils/scanpypi: increase error message verbosity

[Alexey Roslyakov]

When package installation fails it is good to know what happened.

Signed-off-by: Alexey Roslyakov <alexey.roslyakov@gmail.com>
---
 utils/scanpypi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/utils/scanpypi b/utils/scanpypi
index 02384f2569..939c26a187 100755
--- a/utils/scanpypi
+++ b/utils/scanpypi
@@ -608,9 +608,9 @@ def main():
                 else:
                     raise
                 continue
-            except AttributeError:
-                print('Error: Could not install package {pkg}'.format(
-                    pkg=package.real_name))
+            except AttributeError as error:
+                print('Error: Could not install package {pkg}: {error}'.format(
+                    pkg=package.real_name, error=error))
                 continue
 
             # Package requirement are an argument of the setup function
-- 
2.13.6

[Buildroot] [PATCH 1/1] utils/scanpypi: increase error message verbosity

[Yegor Yefremov]

Hi Alexey,

On Mon, Dec 18, 2017 at 3:00 PM, Alexey Roslyakov
<alexey.roslyakov@gmail.com> wrote:
> When package installation fails it is good to know what happened.
>
> Signed-off-by: Alexey Roslyakov <alexey.roslyakov@gmail.com>

Nice catch.

Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

Yegor

> ---
>  utils/scanpypi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/utils/scanpypi b/utils/scanpypi
> index 02384f2569..939c26a187 100755
> --- a/utils/scanpypi
> +++ b/utils/scanpypi
> @@ -608,9 +608,9 @@ def main():
>                  else:
>                      raise
>                  continue
> -            except AttributeError:
> -                print('Error: Could not install package {pkg}'.format(
> -                    pkg=package.real_name))
> +            except AttributeError as error:
> +                print('Error: Could not install package {pkg}: {error}'.format(
> +                    pkg=package.real_name, error=error))
>                  continue
>
>              # Package requirement are an argument of the setup function
> --
> 2.13.6
>

[Buildroot] [PATCH 1/1] utils/scanpypi: increase error message verbosity

[Thomas Petazzoni]

Hello,

On Mon, 18 Dec 2017 21:00:16 +0700, Alexey Roslyakov wrote:
> When package installation fails it is good to know what happened.
> 
> Signed-off-by: Alexey Roslyakov <alexey.roslyakov@gmail.com>
> ---
>  utils/scanpypi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] utils/scanpypi: increase error message verbosity

[Yegor Yefremov]

On Mon, Dec 18, 2017 at 3:19 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Mon, 18 Dec 2017 21:00:16 +0700, Alexey Roslyakov wrote:
>> When package installation fails it is good to know what happened.
>>
>> Signed-off-by: Alexey Roslyakov <alexey.roslyakov@gmail.com>
>> ---
>>  utils/scanpypi | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> Applied to master, thanks.

@Alexey do you have more scanpypi patches in the queue? I've reworked
the license type detection [1]. I'd also like to add licence file
checksum to the *.hash file creation.

[1] http://patchwork.ozlabs.org/patch/837807/

Yegor

[Buildroot] [PATCH 1/1] utils/scanpypi: increase error message verbosity

[Alexey Roslyakov]

Yegor,
no, I don't have anything at the moment.

All best.

On 18 December 2017 at 21:56, Yegor Yefremov <yegorslists@googlemail.com>
wrote:

> On Mon, Dec 18, 2017 at 3:19 PM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
> > Hello,
> >
> > On Mon, 18 Dec 2017 21:00:16 +0700, Alexey Roslyakov wrote:
> >> When package installation fails it is good to know what happened.
> >>
> >> Signed-off-by: Alexey Roslyakov <alexey.roslyakov@gmail.com>
> >> ---
> >>  utils/scanpypi | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > Applied to master, thanks.
>
> @Alexey do you have more scanpypi patches in the queue? I've reworked
> the license type detection [1]. I'd also like to add licence file
> checksum to the *.hash file creation.
>
> [1] http://patchwork.ozlabs.org/patch/837807/
>
> Yegor
>



-- 
With best regards,
  Alexey Roslyakov
Email: alexey.roslyakov at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20171219/6bb1d959/attachment.html>