* [Buildroot] [git commit] package/qt5/qt5scxml: needs qt5declarative package
@ 2017-12-27 21:07 Thomas Petazzoni
2017-12-27 21:26 ` Peter Seiderer
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2017-12-27 21:07 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=187d24701ded6bec598e4aec272033f33f158de7
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
qt5scxml package needs qml-private module which is delivered by
qt5declarative.
Fixes:
http://autobuild.buildroot.net/results/9e650f6147f7858be74782806f4b8d2aac4c689a/
Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
[Thomas: add missing dependency on BR2_PACKAGE_QT5_JSCORE_AVAILABLE,
adjust commit log.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
package/qt5/qt5scxml/Config.in | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/qt5/qt5scxml/Config.in b/package/qt5/qt5scxml/Config.in
index 4ae6a5b..469bdc1 100644
--- a/package/qt5/qt5scxml/Config.in
+++ b/package/qt5/qt5scxml/Config.in
@@ -1,7 +1,9 @@
config BR2_PACKAGE_QT5SCXML
bool "qt5scxml"
depends on BR2_PACKAGE_QT5_VERSION_LATEST
+ depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE
select BR2_PACKAGE_QT5BASE
+ select BR2_PACKAGE_QT5DECLARATIVE
help
Qt is a cross-platform application and UI framework for
developers using C++.
@@ -12,4 +14,5 @@ config BR2_PACKAGE_QT5SCXML
https://doc.qt.io/qt-5/qtscxml-index.html
comment "qt5scxml needs at least qt-5.9"
+ depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE
depends on !BR2_PACKAGE_QT5_VERSION_LATEST
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] package/qt5/qt5scxml: needs qt5declarative package
2017-12-27 21:07 [Buildroot] [git commit] package/qt5/qt5scxml: needs qt5declarative package Thomas Petazzoni
@ 2017-12-27 21:26 ` Peter Seiderer
2017-12-27 21:42 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Peter Seiderer @ 2017-12-27 21:26 UTC (permalink / raw)
To: buildroot
Hello Thomas, Bartosz,
sorry for sending an additional patch for the same failure (should have checked
my e-mails first)...
But some additional comments below...
On Wed, 27 Dec 2017 22:07:01 +0100, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> commit: https://git.buildroot.net/buildroot/commit/?id=187d24701ded6bec598e4aec272033f33f158de7
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> qt5scxml package needs qml-private module which is delivered by
> qt5declarative.
>
> Fixes:
>
> http://autobuild.buildroot.net/results/9e650f6147f7858be74782806f4b8d2aac4c689a/
>
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
> [Thomas: add missing dependency on BR2_PACKAGE_QT5_JSCORE_AVAILABLE,
> adjust commit log.]
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> package/qt5/qt5scxml/Config.in | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/qt5/qt5scxml/Config.in b/package/qt5/qt5scxml/Config.in
> index 4ae6a5b..469bdc1 100644
> --- a/package/qt5/qt5scxml/Config.in
> +++ b/package/qt5/qt5scxml/Config.in
> @@ -1,7 +1,9 @@
> config BR2_PACKAGE_QT5SCXML
> bool "qt5scxml"
> depends on BR2_PACKAGE_QT5_VERSION_LATEST
> + depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE
Better:
depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE # qt5declarative
> select BR2_PACKAGE_QT5BASE
Not sure if an explicit select is needed, but qt5declarative selects the following:
select BR2_PACKAGE_QT5BASE_GUI # qt5declarative
select BR2_PACKAGE_QT5XMLPATTERNS # qt5declarative
> + select BR2_PACKAGE_QT5DECLARATIVE
> help
> Qt is a cross-platform application and UI framework for
> developers using C++.
> @@ -12,4 +14,5 @@ config BR2_PACKAGE_QT5SCXML
> https://doc.qt.io/qt-5/qtscxml-index.html
>
> comment "qt5scxml needs at least qt-5.9"
> + depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE
> depends on !BR2_PACKAGE_QT5_VERSION_LATEST
And missing from both versions:
diff --git a/package/qt5/qt5scxml/qt5scxml.mk b/package/qt5/qt5scxml/qt5scxml.mk
index 4b1f97973d..3deef99aaf 100644
--- a/package/qt5/qt5scxml/qt5scxml.mk
+++ b/package/qt5/qt5scxml/qt5scxml.mk
@@ -7,7 +7,7 @@
QT5SCXML_VERSION = $(QT5_VERSION)
QT5SCXML_SITE = $(QT5_SITE)
QT5SCXML_SOURCE = qtscxml-opensource-src-$(QT5SCXML_VERSION).tar.xz
-QT5SCXML_DEPENDENCIES = qt5base
+QT5SCXML_DEPENDENCIES = qt5base qt5xmlpatterns qt5declarative
QT5SCXML_INSTALL_STAGING = YES
QT5SCXML_LICENSE = GPL-2.0+ or LGPL-3.0, GPL-3.0 with exception(tools), GFDL-1.3 (docs)
Regards,
Peter
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] package/qt5/qt5scxml: needs qt5declarative package
2017-12-27 21:26 ` Peter Seiderer
@ 2017-12-27 21:42 ` Thomas Petazzoni
2017-12-27 22:17 ` Peter Seiderer
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2017-12-27 21:42 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 27 Dec 2017 22:26:16 +0100, Peter Seiderer wrote:
> > diff --git a/package/qt5/qt5scxml/Config.in b/package/qt5/qt5scxml/Config.in
> > index 4ae6a5b..469bdc1 100644
> > --- a/package/qt5/qt5scxml/Config.in
> > +++ b/package/qt5/qt5scxml/Config.in
> > @@ -1,7 +1,9 @@
> > config BR2_PACKAGE_QT5SCXML
> > bool "qt5scxml"
> > depends on BR2_PACKAGE_QT5_VERSION_LATEST
> > + depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE
>
> Better:
> depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE # qt5declarative
True.
> > select BR2_PACKAGE_QT5BASE
>
> Not sure if an explicit select is needed, but qt5declarative selects the following:
>
> select BR2_PACKAGE_QT5BASE_GUI # qt5declarative
> select BR2_PACKAGE_QT5XMLPATTERNS # qt5declarative
So why does your patch also selects them, if they are already
implicitly selected by qt5declarative ?
> diff --git a/package/qt5/qt5scxml/qt5scxml.mk b/package/qt5/qt5scxml/qt5scxml.mk
> index 4b1f97973d..3deef99aaf 100644
> --- a/package/qt5/qt5scxml/qt5scxml.mk
> +++ b/package/qt5/qt5scxml/qt5scxml.mk
> @@ -7,7 +7,7 @@
> QT5SCXML_VERSION = $(QT5_VERSION)
> QT5SCXML_SITE = $(QT5_SITE)
> QT5SCXML_SOURCE = qtscxml-opensource-src-$(QT5SCXML_VERSION).tar.xz
> -QT5SCXML_DEPENDENCIES = qt5base
> +QT5SCXML_DEPENDENCIES = qt5base qt5xmlpatterns qt5declarative
True for qt5declarative. But for qt5xmlpatterns? Is it directly used by
qt5scxml? If not, then adding it is not necessary, as qt5declarative
already has a dependency on it.
Could you send a follow-up patch doing the remaining fixes?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] package/qt5/qt5scxml: needs qt5declarative package
2017-12-27 21:42 ` Thomas Petazzoni
@ 2017-12-27 22:17 ` Peter Seiderer
2017-12-27 22:27 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Peter Seiderer @ 2017-12-27 22:17 UTC (permalink / raw)
To: buildroot
Hello Thomas,
On Wed, 27 Dec 2017 22:42:06 +0100, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Wed, 27 Dec 2017 22:26:16 +0100, Peter Seiderer wrote:
>
>
> > > diff --git a/package/qt5/qt5scxml/Config.in b/package/qt5/qt5scxml/Config.in
> > > index 4ae6a5b..469bdc1 100644
> > > --- a/package/qt5/qt5scxml/Config.in
> > > +++ b/package/qt5/qt5scxml/Config.in
> > > @@ -1,7 +1,9 @@
> > > config BR2_PACKAGE_QT5SCXML
> > > bool "qt5scxml"
> > > depends on BR2_PACKAGE_QT5_VERSION_LATEST
> > > + depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE
> >
> > Better:
> > depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE # qt5declarative
>
> True.
>
> > > select BR2_PACKAGE_QT5BASE
> >
> > Not sure if an explicit select is needed, but qt5declarative selects the following:
> >
> > select BR2_PACKAGE_QT5BASE_GUI # qt5declarative
> > select BR2_PACKAGE_QT5XMLPATTERNS # qt5declarative
>
> So why does your patch also selects them, if they are already
> implicitly selected by qt5declarative ?
Thanks for the reasoning, but one more question: with this logic
the above 'select BR2_PACKAGE_QT5BASE' could be removed (but the
below dependency on qt5base without the corresponding select seems
ugly)?
>
> > diff --git a/package/qt5/qt5scxml/qt5scxml.mk b/package/qt5/qt5scxml/qt5scxml.mk
> > index 4b1f97973d..3deef99aaf 100644
> > --- a/package/qt5/qt5scxml/qt5scxml.mk
> > +++ b/package/qt5/qt5scxml/qt5scxml.mk
> > @@ -7,7 +7,7 @@
> > QT5SCXML_VERSION = $(QT5_VERSION)
> > QT5SCXML_SITE = $(QT5_SITE)
> > QT5SCXML_SOURCE = qtscxml-opensource-src-$(QT5SCXML_VERSION).tar.xz
> > -QT5SCXML_DEPENDENCIES = qt5base
> > +QT5SCXML_DEPENDENCIES = qt5base qt5xmlpatterns qt5declarative
>
> True for qt5declarative. But for qt5xmlpatterns? Is it directly used by
> qt5scxml? If not, then adding it is not necessary, as qt5declarative
> already has a dependency on it.
>
> Could you send a follow-up patch doing the remaining fixes?
O.k, will do...
Regards,
Peter
>
> Thanks a lot!
>
> Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] package/qt5/qt5scxml: needs qt5declarative package
2017-12-27 22:17 ` Peter Seiderer
@ 2017-12-27 22:27 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2017-12-27 22:27 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 27 Dec 2017 23:17:00 +0100, Peter Seiderer wrote:
> > > select BR2_PACKAGE_QT5BASE_GUI # qt5declarative
> > > select BR2_PACKAGE_QT5XMLPATTERNS # qt5declarative
> >
> > So why does your patch also selects them, if they are already
> > implicitly selected by qt5declarative ?
>
> Thanks for the reasoning, but one more question: with this logic
> the above 'select BR2_PACKAGE_QT5BASE' could be removed (but the
> below dependency on qt5base without the corresponding select seems
> ugly)?
We don't have a very clear cut approach on this. I believe the best
reasoning is: if the package uses *directly* qt5base, then it should
explicitly select it and have it in <pkg>_DEPENDENCIES. If it's only
indirectly used through another package, then selecting this "another
package" is enough.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-27 22:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-27 21:07 [Buildroot] [git commit] package/qt5/qt5scxml: needs qt5declarative package Thomas Petazzoni
2017-12-27 21:26 ` Peter Seiderer
2017-12-27 21:42 ` Thomas Petazzoni
2017-12-27 22:17 ` Peter Seiderer
2017-12-27 22:27 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox