Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 2/2] docs/manual: document meson-based packages
Date: Thu, 28 Dec 2017 23:25:39 +0100	[thread overview]
Message-ID: <20171228222539.GH3428@scaer> (raw)
In-Reply-To: <20171228232210.5dda9865@windsurf>

Thomas, All,

On 2017-12-28 23:22 +0100, Thomas Petazzoni spake thusly:
> On Sun, 29 Oct 2017 14:10:52 +0100, Eric Le Bihan wrote:
> > Add instructions for adding a package which uses the Meson build system.
> > 
> > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> > Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> 
> I've applied to the master branch, after adding an entry in the
> DEVELOPERS file. I also have one comment/question below.
> 
> 
> > +27: define FOO_CONFIGURE_CMDS
> > +28: 	rm -rf $(@D)/build
> > +29: 	mkdir -p $(@D)/build
> 
> Is this really needed? It's not really nice to have to do this. But
> perhaps meson really insists in having an empty build directory ?

IIRC, I made the same comment in a  previous iteration of this patch, and
yes, meson really insists on having an empty build directory, otherwise it
fails loudly... :-/

This should have been part of the commit log *and* should be clearly
stated in the manual that this is required.

Regards,
Yann E. MORIN.

> Thanks!
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2017-12-28 22:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-29 13:10 [Buildroot] [PATCH v4 0/2] Add support for Meson build Eric Le Bihan
2017-10-29 13:10 ` [Buildroot] [PATCH v4 1/2] meson: new package Eric Le Bihan
2017-11-24 10:54   ` Yegor Yefremov
2017-12-28 22:21   ` Thomas Petazzoni
2017-10-29 13:10 ` [Buildroot] [PATCH v4 2/2] docs/manual: document meson-based packages Eric Le Bihan
2017-11-24 13:51   ` Yegor Yefremov
2017-12-28 22:22   ` Thomas Petazzoni
2017-12-28 22:25     ` Yann E. MORIN [this message]
2017-12-28 22:35       ` Thomas Petazzoni
2017-12-28 22:46         ` Yann E. MORIN
2017-11-24 10:54 ` [Buildroot] [PATCH v4 0/2] Add support for Meson build Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171228222539.GH3428@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox