[Buildroot] [PATCHv2] package/nut: don't build in parallel

[Buildroot] [PATCHv2] package/nut: don't build in parallel

[Yann E. MORIN]

The conditions are not trivial to reproduce, but it can happen that the
headers are not fully regenerated by the time they are included.

This only happens when a python and/or perl interpreter are available,
with a high number of jobs and a high load.

Fixes:
    http://autobuild.buildroot.org/results/523/5231ff39a0839ec5e1962662004214d4b0773068/
    http://autobuild.buildroot.org/results/5a7/5a75d44c028e77b58f0fd9ab794952f2b477dd84/

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Peter Korsgaard <peter@korsgaard.com>

---
Changes v1 -> v2:
  - drop non-upstreamable patch, but just do not build in parallel (Peter)
---
 package/nut/nut.mk | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/nut/nut.mk b/package/nut/nut.mk
index 332ccf9071..4ea9947128 100644
--- a/package/nut/nut.mk
+++ b/package/nut/nut.mk
@@ -14,6 +14,9 @@ NUT_DEPENDENCIES = host-pkgconf
 # Our patch changes m4 macros, so we need to autoreconf
 NUT_AUTORECONF = YES
 
+# Race condition in tools generation
+NUT_MAKE = $(MAKE1)
+
 # Put the PID files in a read-write place (/var/run is a tmpfs)
 # since the default location (/var/state/ups) maybe readonly.
 NUT_CONF_OPTS = \
-- 
2.11.0

[Buildroot] [PATCHv2] package/nut: don't build in parallel

[Thomas Petazzoni]

Hello,

On Thu, 28 Dec 2017 14:43:18 +0100, Yann E. MORIN wrote:
> The conditions are not trivial to reproduce, but it can happen that the
> headers are not fully regenerated by the time they are included.
> 
> This only happens when a python and/or perl interpreter are available,
> with a high number of jobs and a high load.
> 
> Fixes:
>     http://autobuild.buildroot.org/results/523/5231ff39a0839ec5e1962662004214d4b0773068/
>     http://autobuild.buildroot.org/results/5a7/5a75d44c028e77b58f0fd9ab794952f2b477dd84/
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> 
> ---
> Changes v1 -> v2:
>   - drop non-upstreamable patch, but just do not build in parallel (Peter)
> ---
>  package/nut/nut.mk | 3 +++
>  1 file changed, 3 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCHv2] package/nut: don't build in parallel

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > The conditions are not trivial to reproduce, but it can happen that the
 > headers are not fully regenerated by the time they are included.

 > This only happens when a python and/or perl interpreter are available,
 > with a high number of jobs and a high load.

 > Fixes:
 >     http://autobuild.buildroot.org/results/523/5231ff39a0839ec5e1962662004214d4b0773068/
 >     http://autobuild.buildroot.org/results/5a7/5a75d44c028e77b58f0fd9ab794952f2b477dd84/

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Peter Korsgaard <peter@korsgaard.com>

 > ---
 > Changes v1 -> v2:
 >   - drop non-upstreamable patch, but just do not build in parallel (Peter)

Committed to 2017.11.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCHv2] package/nut: don't build in parallel

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > The conditions are not trivial to reproduce, but it can happen that the
 > headers are not fully regenerated by the time they are included.

 > This only happens when a python and/or perl interpreter are available,
 > with a high number of jobs and a high load.

 > Fixes:
 >     http://autobuild.buildroot.org/results/523/5231ff39a0839ec5e1962662004214d4b0773068/
 >     http://autobuild.buildroot.org/results/5a7/5a75d44c028e77b58f0fd9ab794952f2b477dd84/

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Peter Korsgaard <peter@korsgaard.com>

 > ---
 > Changes v1 -> v2:
 >   - drop non-upstreamable patch, but just do not build in parallel (Peter)

Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard