[Buildroot] [PATCH] nilfs-utils: needs threads support

[Buildroot] [PATCH] nilfs-utils: needs threads support

[Baruch Siach]

nilfs-utils uses the sem_* family of functions from the realtime
extension. Technically this is not part of pthreads. But in uClibc
enabling threads enables also UCLIBC_HAS_REALTIME.

Fixes:
http://autobuild.buildroot.net/results/c5d/c5d93b6ab5b260fe5db46298b956a9ae765c828a/
http://autobuild.buildroot.net/results/9d6/9d6a248f9acbb58b6c2893de58978c6013332415/

Cc: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/nilfs-utils/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/nilfs-utils/Config.in b/package/nilfs-utils/Config.in
index 2763af54fd24..0c6b7a0ce861 100644
--- a/package/nilfs-utils/Config.in
+++ b/package/nilfs-utils/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_NILFS_UTILS
 	bool "nilfs-utils"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # sem_open()
 	depends on BR2_USE_MMU # util-linux libmount, libblkid
 	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
 	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
@@ -9,3 +10,6 @@ config BR2_PACKAGE_NILFS_UTILS
 	  Tools for creating and managing NILFS2 filesystems.
 
 	  https://github.com/nilfs-dev/nilfs-utils
+
+comment "nilfs-utils needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
-- 
2.15.1

[Buildroot] [PATCH] nilfs-utils: needs threads support

[Thomas Petazzoni]

Hello,

On Tue,  2 Jan 2018 13:42:23 +0200, Baruch Siach wrote:
> nilfs-utils uses the sem_* family of functions from the realtime
> extension. Technically this is not part of pthreads. But in uClibc
> enabling threads enables also UCLIBC_HAS_REALTIME.
> 
> Fixes:
> http://autobuild.buildroot.net/results/c5d/c5d93b6ab5b260fe5db46298b956a9ae765c828a/
> http://autobuild.buildroot.net/results/9d6/9d6a248f9acbb58b6c2893de58978c6013332415/
> 
> Cc: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/nilfs-utils/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] nilfs-utils: needs threads support

[Kurt Van Dijck]

> nilfs-utils uses the sem_* family of functions from the realtime
> extension. Technically this is not part of pthreads. But in uClibc
> enabling threads enables also UCLIBC_HAS_REALTIME.

I got to testing nilfs-utils on different compilers, and got a similar
conclusion: uclibc without threads has no semaphores.

you can add:

Acked-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>

> 
> Fixes:
> http://autobuild.buildroot.net/results/c5d/c5d93b6ab5b260fe5db46298b956a9ae765c828a/
> http://autobuild.buildroot.net/results/9d6/9d6a248f9acbb58b6c2893de58978c6013332415/
> 
> Cc: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/nilfs-utils/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/nilfs-utils/Config.in b/package/nilfs-utils/Config.in
> index 2763af54fd24..0c6b7a0ce861 100644
> --- a/package/nilfs-utils/Config.in
> +++ b/package/nilfs-utils/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_NILFS_UTILS
>  	bool "nilfs-utils"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # sem_open()
>  	depends on BR2_USE_MMU # util-linux libmount, libblkid
>  	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
>  	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
> @@ -9,3 +10,6 @@ config BR2_PACKAGE_NILFS_UTILS
>  	  Tools for creating and managing NILFS2 filesystems.
>  
>  	  https://github.com/nilfs-dev/nilfs-utils
> +
> +comment "nilfs-utils needs a toolchain w/ threads"
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS
> -- 
> 2.15.1
>